Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/#review131261 --- Patch looks great! Reviews applied: [46874] Passed command: expo

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/ --- (Updated May 1, 2016, 8:31 a.m.) Review request for mesos. Repository: mesos

Re: Review Request 46779: Clarified and improved maintenance docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46779/ --- (Updated May 1, 2016, 8:49 a.m.) Review request for mesos and Jie Yu. Changes

Re: Review Request 46779: Clarified and improved maintenance docs.

> On April 29, 2016, 10:02 p.m., Joseph Wu wrote: > > docs/maintenance.md, lines 269-273 > > > > > > I would put this paragraph in a `>NOTE:` Personally I'd opt to keep this as-is: other paragraphs in the same secti

Re: Review Request 46872: Updated quota.md and weights.md for set quota and update weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46872/#review131263 --- Patch looks great! Reviews applied: [46872] Passed command: expo

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

> On May 1, 2016, 5:53 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1082 > > > > > > One issue is that some tasks without rootfs but with volume or network > > info may also ha

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/ --- (Updated May 1, 2016, 9:11 a.m.) Review request for mesos, Guangya Liu and Jie

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/ --- (Updated May 1, 2016, 9:54 a.m.) Review request for mesos, Guangya Liu and Jie

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

> On May 1, 2016, 5:53 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1082 > > > > > > One issue is that some tasks without rootfs but with volume or network > > info may also ha

Re: Review Request 46875: Some cleanup in weights_handler.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46875/#review131266 --- Patch looks great! Reviews applied: [46875] Passed command: expo

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

> On 五月 1, 2016, 5:53 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1082 > > > > > > One issue is that some tasks without rootfs but with volume or network > > info may also hav

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

> On May 1, 2016, 5:53 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1082 > > > > > > One issue is that some tasks without rootfs but with volume or network > > info may also ha

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/#review131269 --- Patch looks great! Reviews applied: [46807, 46873] Passed comman

Re: Review Request 46807: Simplified the rootfs preparation logic for command tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46807/#review131271 --- Ship it! Would make another pass today. - Gilbert Song On Ap

Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46866/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46867/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Review Request 46868: Added authorization to '/metrics/snapshot'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46868/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46869/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Review Request 46870: Added MetricsTests with authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46870/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46876/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46867/ --- (Updated May 1, 2016, 10:43 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46868: Added authorization to '/metrics/snapshot'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46868/ --- (Updated May 1, 2016, 10:43 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46876/#review131272 --- Bad patch! Reviews applied: [46876, 46870, 46869, 46868, 46867, 4

Re: Review Request 46868: Added authorization to '/metrics/snapshot'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46868/ --- (Updated May 2, 2016, 12:01 a.m.) Review request for mesos, Alexander Rojas and

Review Request 46883: Added authorization callback for '/metrics/snapshot'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46883/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Re: Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46869/ --- (Updated May 2, 2016, 12:03 a.m.) Review request for mesos, Alexander Rojas and

Review Request 46880: Added authorization to '/logging/toggle'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46880/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Review Request 46881: Added authorization callback for '/logging/toggle'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46881/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Review Request 46882: Added a LoggingTest with authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46882/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Re: Review Request 46188: Added the missing 'break' when handling ERROR event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46188/ --- (Updated May 2, 2016, 9:06 a.m.) Review request for mesos, Anand Mazumdar and V

Re: Review Request 46609: Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46609/ --- (Updated May 2, 2016, 9:07 a.m.) Review request for mesos, Anand Mazumdar and V

Re: Review Request 46882: Added a LoggingTest with authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46882/#review131274 --- Patch looks great! Reviews applied: [46866, 46867, 46868, 46883,

Re: Review Request 46807: Simplified the rootfs preparation logic for command tasks.

> On 五月 1, 2016, 6:12 p.m., Gilbert Song wrote: > > Would make another pass today. I also did some test with docker image, docker volume, appc image, all works well. - Guangya --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 46609: Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46609/#review131276 --- Patch looks great! Reviews applied: [46188, 46204, 46609] Passed