Re: Review Request 47442: Windows: Enable `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47442/#review133495 --- Bad patch! Reviews applied: [47442] Failed command:

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- (Updated 五月 17, 2016, 5:29 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/#review133493 --- Patch looks great! Reviews applied: [47089] Passed command:

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

> On May 16, 2016, 6:06 p.m., Alexander Rukletsov wrote: > > src/master/master.hpp, line 1022 > > > > > > Do you still need `request`? We still need `jsonp` argument to be passed. I feel keeping request captured

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133491 --- src/master/quota_handler.cpp (lines 518 - 520)

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/ --- (Updated May 17, 2016, 5:06 a.m.) Review request for mesos, Adam B and

Re: Review Request 47367: Removed references to HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47367/#review133486 --- Patch looks great! Reviews applied: [47363, 47364, 47365, 47431,

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/#review133483 --- include/mesos/appc/spec.proto (line 58)

Re: Review Request 47436: Fixed some typos in oversubscription test and allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47436/#review133481 --- Patch looks great! Reviews applied: [47436] Passed command:

Re: Review Request 47442: Windows: Enable `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47442/ --- (Updated May 17, 2016, 2:27 a.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

> On May 13, 2016, 8:37 p.m., Benjamin Mahler wrote: > > src/tests/health_check_tests.cpp, line 1059 > > > > > > It looks like the clock needs to be paused before the task is launched? > > Otherwise we may have

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/ --- (Updated May 17, 2016, 2:14 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 47442: Windows: Enable `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objwects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47442/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris

Re: Review Request 47367: Removed references to HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47367/ --- (Updated May 17, 2016, 1:53 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/ --- (Updated May 17, 2016, 1:33 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

> On May 13, 2016, 8:37 p.m., Benjamin Mahler wrote: > > src/tests/health_check_tests.cpp, line 1015 > > > > > > Why did this change? Yes, we need this so that we could check the stdout/stderr from console if it

Review Request 47436: Fixed some typos in oversubscription test and allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47436/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Repository:

Re: Review Request 44209: Do not need to close the ifstream explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44209/ --- (Updated 五月 17, 2016, 12:14 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44209: Closed the input ifstream before return error.

> On 五月 16, 2016, 5:47 p.m., Anand Mazumdar wrote: > > Why do we need to close it explicitly? `ifstream` already follows the RAII > > idiom i.e. things are cleaned up upon destruction. What am I missing? Thanks Anand, got it,

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/ --- (Updated May 16, 2016, 11:51 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

> On May 15, 2016, 12:55 a.m., Vinod Kone wrote: > > include/mesos/v1/executor.hpp, line 38 > > > > > > We don't name our interfaces as *Interface :) Is there an alternative > > name we could use? > > > >

Re: Review Request 47364: Set env variable used to toggle executor implementation.

> On May 15, 2016, 12:55 a.m., Vinod Kone wrote: > > src/slave/containerizer/containerizer.cpp, line 364 > > > > > > How about > > > > MESOS_HTTP_API > > > > Also, should this be only set if it's a

Re: Review Request 47365: Moved code from HTTP command executor to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47365/ --- (Updated May 16, 2016, 11:50 p.m.) Review request for mesos and Vinod Kone.

Review Request 47431: Renamed `HttpCommandExecutor` to `CommandExecutor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47431/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5302

Re: Review Request 47365: Moved code from HTTP command executor to command executor.

> On May 15, 2016, 12:55 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 104 > > > > > > s/HttpCommandExecutor/CommandExecutor/ Updated in https://reviews.apache.org/r/47431 - Anand

Re: Review Request 47366: Made the command executor use the adapter interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47366/ --- (Updated May 16, 2016, 11:49 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review133438 --- Patch looks great! Reviews applied: [47374] Passed command:

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/#review133429 --- src/executor/v0_v1executor.cpp (lines 17 - 19)

Re: Review Request 47412: Windows: Use Winsock class in slave and containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47412/#review133432 --- Fix it, then Ship it! src/slave/containerizer/mesos/main.cpp

Re: Review Request 47411: Agent: Changed the names of symbols that are ambiguous on MSVC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47411/#review133430 --- Fix it, then Ship it! src/docker/docker.hpp (lines 123 - 124)

Re: Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47404/#review133426 --- Fix it, then Ship it!

Re: Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47403/#review133425 --- Fix it, then Ship it!

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/ --- (Updated May 16, 2016, 1:02 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47391: Stout: Removed warning in Windows implementation of `stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47391/#review133424 --- Fix it, then Ship it!

Re: Review Request 47390: Stout: Removed implicit conversions in `permissions.hpp` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47390/#review133423 --- Ship it! Ship It! - Joris Van Remoortere On May 14, 2016,

Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47389/#review133422 --- 3rdparty/stout/include/stout/os/constants.hpp (lines 20 - 28)

Re: Review Request 47387: Stout: Implemented `fsync.hpp` for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47387/#review133419 --- Fix it, then Ship it!

Re: Review Request 47388: Stout: Included missing headers in some files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47388/#review133420 --- Ship it! Ship It! - Joris Van Remoortere On May 14, 2016,

Re: Review Request 47324: Update leveldb to 1.18.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133415 --- Ship it! Tested on s390x, SLES12SP1. - Bing Li On May 14,

Re: Review Request 47260: Added 'ReviveAndSuppress' test for the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47260/#review133408 --- Ship it! Ship It! - Dario Rexin On May 12, 2016, 4:01 p.m.,

Re: Review Request 47401: Corrected using order in authorizer.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47401/#review133404 --- Ship it! Ship It! - Alexander Rukletsov On May 15, 2016,

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/#review131462 --- include/mesos/resources.hpp (line 167)

Re: Review Request 45605: Introduced HTB class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45605/#review133400 --- src/linux/routing/queueing/htb.cpp (line 119)

Re: Review Request 45606: Added default class to htb qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45606/#review133398 --- src/linux/routing/queueing/htb.cpp (line 49)

Re: Review Request 45607: Move HTB qdisc out of containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45607/#review133397 --- src/linux/routing/queueing/fq_codel.hpp (line 44)

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/#review133390 --- src/slave/containerizer/mesos/containerizer.cpp (line 953)

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/ --- (Updated May 16, 2016, 11:10 a.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133388 --- Okay, almost there. We should be good after one more pass.

Re: Review Request 47213: Added FlagsBase::toVector method as an alternative to stringify(flags).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47213/ --- (Updated May 16, 2016, 11 a.m.) Review request for mesos, Adam B, Artem

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/#review131398 --- Haven't looked at tests but given the anticipated change in the

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47214/ --- (Updated May 16, 2016, 11:01 a.m.) Review request for mesos, Adam B, Artem

Re: Review Request 44209: Closed the input ifstream before return error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44209/#review133392 --- Why do we need to close it explicitly? `ifstream` already follows

Re: Review Request 47281: Mesos::master::allocation namespace removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47281/#review133382 --- Fix it, then Ship it! Ship It! src/local/local.cpp

Re: Review Request 47362: Added a test for the SSL head-of-line blocking issue in MESOS-5340.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47362/#review133375 --- 3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 730 - 731)

Re: Review Request 47209: Establish TCP connection after backing off.

> On May 14, 2016, 2:01 a.m., Qian Zhang wrote: > > src/slave/slave.cpp, line 1020 > > > > > > If we do the link here, that means we still establish TCP connection > > with master right after a new master is

Re: Review Request 47412: Windows: Use Winsock class in slave and containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47412/#review133367 --- Patch looks great! Reviews applied: [47052, 47053, 47221, 47054,

Review Request 47412: Windows: Use Winsock class in slave and containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47412/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Review Request 47411: Agent: Changed the names of symbols that are ambiguous on MSVC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47411/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Review Request 47409: Libprocess: Implemented `HANDLE` versions of file descriptor functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47409/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Review Request 47410: CMake: Added build targets for Mesos executables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47410/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 47406: Rename all flag variables from keyword 'slave' to 'agent'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47406/#review133343 --- Patch looks great! Reviews applied: [45200, 47406] Passed

Re: Review Request 46093: Enhanced the error message for invalid duration unit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46093/#review133342 --- Patch looks great! Reviews applied: [46093] Passed command:

Re: Review Request 39848: Validated revocable resources before run task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39848/#review133341 --- Patch looks great! Reviews applied: [39845, 39848] Passed

Re: Review Request 47340: Modified doc file for '/containers'.

> On May 13, 2016, 8:15 p.m., Alexander Rukletsov wrote: > > Could you please squash this with https://reviews.apache.org/r/47061/ to > > minimize the churn? done. Please re-check. - Abhishek --- This is an automatically generated

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

> On May 13, 2016, 2:50 p.m., Alexander Rukletsov wrote: > > src/slave/slave.cpp, line 766 > > > > > > Uups, is it intended? If yes, please do it in a separate patch. Thought again and discarded logging. -

Re: Review Request 45200: Add deprecated flag names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45200/ --- (Updated May 16, 2016, 7:37 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/ --- (Updated May 16, 2016, 7:37 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44209: Closed the input ifstream before return error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44209/#review13 --- Patch looks great! Reviews applied: [44209] Passed command:

Re: Review Request 46093: Enhanced the error message for invalid duration unit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46093/ --- (Updated 五月 16, 2016, 6:18 a.m.) Review request for mesos and Alexander

Re: Review Request 39845: Added REASON_RESOURCE_OVERSUBSCRIBED to mesos proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39845/ --- (Updated 五月 16, 2016, 6:10 a.m.) Review request for mesos, Niklas Nielsen and