Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47633/#review134110 --- Bad patch! Reviews applied: [47633] Failed command: ./support/ap

Re: Review Request 47635: Removed /observe document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47635/#review134109 --- Ship it! Ship It! - haosdent huang On May 20, 2016, 6:17 a.m

Review Request 47635: Removed /observe document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47635/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5408 https://issues.ap

Review Request 47636: Fixed some coding error in mesos-ps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47636/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone. Repository:

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/#review134106 --- Patch looks great! Reviews applied: [47123] Passed command: expo

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47633/#review134094 --- Fix it, then Ship it! Thank you for your patch. For summary and

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47633/#review134101 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp

Re: Review Request 47442: Windows: Enable `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47442/#review134098 --- Patch looks great! Reviews applied: [47473, 47492, 47486, 47474,

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/ --- (Updated May 20, 2016, 4:21 a.m.) Review request for mesos, Freddy Ayuso-Henson

Re: Review Request 47587: Created separate local data file to manage releases information.

> On May 20, 2016, 3:27 a.m., Vinod Kone wrote: > > Looks like you need to rebase, so I made my comments anyway :) > > > > I'm assuming the workflow for generating the website hasn't changed with > > the introduction of erb files? Thank you very much for your view. >I'm assuming the workflow f

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/ --- (Updated May 20, 2016, 3:55 a.m.) Review request for mesos, Freddy Ayuso-Henson

Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47633/ --- Review request for mesos, haosdent huang, Jie Yu, and Cong Wang. Bugs: MESOS-53

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review134090 --- Patch looks great! Reviews applied: [47587] Passed command: expo

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review134089 --- Looks like you need to rebase, so I made my comments anyway :) I'

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review134088 --- Ship it! This is great thank you! I'll make some minor grammar

Re: Review Request 47581: Delete the /observe HTTP endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47581/#review134087 --- Ship it! Ship It! - Vinod Kone On May 19, 2016, 7:19 a.m., Q

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review132116 --- src/authorizer/local/authorizer.cpp (line 216)

Re: Review Request 47490: Moved `Task` to public protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47490/#review134083 --- Ship it! Ship It! - Michael Park On May 17, 2016, 9:26 p.m.,

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 19, 2016, 10:40 p.m.) Review request for mesos, Cody Maloney and T

Re: Review Request 47453: Corrected order of forwards declarations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47453/#review134080 --- Ship it! Ship It! - Michael Park On May 17, 2016, 9:24 p.m.,

Re: Review Request 47442: Windows: Enable `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47442/ --- (Updated May 20, 2016, 1:48 a.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47489: Windows: Symplified `os::exists`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/ --- (Updated May 20, 2016, 1:47 a.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 46904: Fixed a typo in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46904/#review134077 --- Patch looks great! Reviews applied: [46904] Passed command: expo

Re: Review Request 47625: Fixed incorrect use of unique_ptr for array storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47625/#review134075 --- Ship it! Ship It! - Kevin Klues On May 20, 2016, 12:55 a.m.,

Re: Review Request 47610: Reverted adding libelf as a default dynamic library in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47610/ --- (Updated May 20, 2016, 12:56 a.m.) Review request for mesos. Bugs: MESOS-5414

Review Request 47625: Fixed incorrect use of unique_ptr for array storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47625/ --- Review request for mesos, Joris Van Remoortere, Kevin Klues, and Michael Park.

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/ --- (Updated 五月 20, 2016, 12:20 a.m.) Review request for mesos, David vonThenen, Gi

Re: Review Request 47489: Windows: Symplified `os::exists`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/ --- (Updated May 20, 2016, 12:17 a.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review134073 --- Patch looks great! Reviews applied: [47463] Passed command: expo

Re: Review Request 47474: Windows: Disabled signal handlers in logging.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47474/ --- (Updated May 20, 2016, 12:04 a.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134070 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 47486: Windows: Escaped command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47486/ --- (Updated May 19, 2016, 11:07 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47610: Reverted adding libelf as a default dynamic library in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47610/#review134064 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review134063 --- Ship it! Ship It! - Tomasz Janiszewski On Maj 19, 2016, 10:3

Re: Review Request 47587: Created separate local data file to manage releases information.

> On May 19, 2016, 5:30 p.m., Tomasz Janiszewski wrote: > > site/source/index.html.erb, line 57 > > > > > > Could be splitted > > > > ``` > > > href="https://git-wip-us.apache.org/repos/asf?p=mesos.git;

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/ --- (Updated May 19, 2016, 10:32 p.m.) Review request for mesos, Freddy Ayuso-Henso

Re: Review Request 47492: Windows: Updated the containerizer name to `mesos-containerizer.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47492/ --- (Updated May 19, 2016, 10:26 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47473: Windows: Added logging for `WSTRINGIFY` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47473/ --- (Updated May 19, 2016, 10:19 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47473: Windows: Added logging for `WSTRINGIFY` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47473/ --- (Updated May 19, 2016, 10:19 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47585: Fixed a mismatched 'delete'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/#review134057 --- Bad patch! Reviews applied: [47585] Failed command: ./support/ap

Re: Review Request 47471: Introduced intialize() for Flags class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47471/#review134054 --- src/examples/test_framework.cpp (line 207)

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/#review134053 --- src/launcher/windows/executor.hpp (line 107)

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

> On May 10, 2016, 1:27 a.m., Cody Maloney wrote: > > src/module/manager.cpp, line 377 > > > > > > Is there a semantic difference between loading modules one at a time > > vs. just passing them all at once to loadMa

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 19, 2016, 5:51 p.m.) Review request for mesos, Cody Maloney and Ti

Re: Review Request 46904: Fixed a typo in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46904/ --- (Updated May 19, 2016, 9:44 p.m.) Review request for mesos and Adam B. Reposi

Re: Review Request 46901: Regenerated HTTP endpoint docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46901/#review134047 --- Ship it! Ship It! - Kapil Arya On May 2, 2016, 2:34 p.m., Gr

Re: Review Request 46900: Updated libprocess HTTP endpoint help strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46900/#review134046 --- Ship it! Ship It! - Kapil Arya On May 2, 2016, 2:33 p.m., Gr

Re: Review Request 46904: Fixed a typo in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46904/#review134044 --- Ship it! Ship It! - Kapil Arya On May 2, 2016, 3:58 p.m., Gr

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/#review134039 --- Bad patch! Reviews applied: [47603, 47602, 47576, 47536, 47472, 4

Re: Review Request 47594: Skipped the bind mount of CNI net info root dir if possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47594/#review134030 --- Patch looks great! Reviews applied: [47594] Passed command: expo

Re: Review Request 47463: Added documentation for `network/cni` isolator.

> On May 18, 2016, 6:39 p.m., Vinod Kone wrote: > > docs/cni.md, line 247 > > > > > > and vice versa unless the executor uses HTTP API? > > Avinash sridharan wrote: > Even with the HTTP API the requirement of ro

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review134028 --- Ship it! Ship It! - Greg Mann On May 18, 2016, 4:13 a.m., zh

Re: Review Request 47463: Added documentation for `network/cni` isolator.

> On May 18, 2016, 6:39 p.m., Vinod Kone wrote: > > docs/cni.md, line 247 > > > > > > and vice versa unless the executor uses HTTP API? > > Avinash sridharan wrote: > Even with the HTTP API the requirement of ro

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/ --- (Updated May 19, 2016, 8:05 p.m.) Review request for mesos, Benjamin Mahler, Ji

Re: Review Request 47581: Delete the /observe HTTP endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47581/#review134011 --- Patch looks great! Reviews applied: [47581] Passed command: expo

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review134010 --- docs/cni.md (line 4)

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/ --- (Updated May 19, 2016, 6:38 p.m.) Review request for mesos, Benjamin Mahler, Ji

Re: Review Request 47463: Added documentation for `network/cni` isolator.

> On May 19, 2016, 2:47 p.m., Neil Conway wrote: > > docs/cni.md, line 3 > > > > > > Phrasing is awkward: who is "we", and when "have we introduced" the CNI > > isolator? Better would be: "The Mesos `network/cni` isol

Re: Review Request 47463: Added documentation for `network/cni` isolator.

> On May 18, 2016, 6:39 p.m., Vinod Kone wrote: > > docs/cni.md, lines 100-101 > > > > > > What happens if a network that is in use (by containers) is removed > > from the config and agent restarted? What if the net

Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/ --- Review request for mesos. Repository: mesos Description --- WIP: Add Lab

Review Request 47610: Reverted adding libelf as a default dynamic library in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47610/ --- Review request for mesos. Repository: mesos Description --- The libelf l

Review Request 47609: Reverted adding libelf as a default dynamic library in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47609/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-5414

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review133989 --- site/source/index.html.erb (line 57)

Re: Review Request 47585: Fixed a mismatched 'delete'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/#review133982 --- Ship it! To fix the underlying issue, this is now submitted. Le

Re: Review Request 47582: Include v1 Executor Protos in maven jar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47582/#review133981 --- Patch looks great! Reviews applied: [47582] Passed command: expo

Re: Review Request 47585: Fixed a mismatched 'delete'.

> On May 19, 2016, 8:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > > > > > Let's just wrap this in a `std::unique_ptr` instead! > > Benjamin Bannier wrote: > +1, or just

Re: Review Request 47585: Fixed a mismatched 'delete'.

> On May 19, 2016, 8:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > > > > > Let's just wrap this in a `std::unique_ptr` instead! > > Benjamin Bannier wrote: > +1, or just

Re: Review Request 47587: Created separate local data file to manage releases information.

> On May 19, 2016, 2:41 p.m., Tomasz Janiszewski wrote: > > site/source/index.html.erb, line 15 > > > > > > Do we have line length policy for site files? > > haosdent huang wrote: > Thank you very much for your r

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/ --- (Updated May 19, 2016, 4:16 p.m.) Review request for mesos, Freddy Ayuso-Henson

Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere

Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47602/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere

Re: Review Request 47587: Created separate local data file to manage releases information.

> On May 19, 2016, 2:41 p.m., Tomasz Janiszewski wrote: > > site/source/index.html.erb, line 15 > > > > > > Do we have line length policy for site files? Thank you very much for your reviews, let me fix it. - haosd

Re: Review Request 47587: Created separate local data file to manage releases information.

> On May 19, 2016, 3 p.m., Tomasz Janiszewski wrote: > > After switching to `.erb` we lost `` and breadcrumbs Good catch! Let me fix. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/

Review Request 47601: Fixed broken libelf dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47601/ --- Review request for mesos. Repository: mesos Description --- Unfortunatel

Re: Review Request 47601: Fixed broken libelf dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47601/#review133956 --- Ship it! Ship It! - Till Toenshoff On May 19, 2016, 3:54 p.m

Re: Review Request 47601: Fixed broken libelf dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47601/ --- (Updated May 19, 2016, 3:54 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review133952 --- After switching to `.erb` we lost `` and breadcrumbs - Tomasz Jan

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133937 --- docs/cni.md (line 3)

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review133949 --- site/source/index.html.erb (line 15)

Re: Review Request 47585: Fixed a mismatched 'delete'.

> On May 19, 2016, 10:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > > > > > Let's just wrap this in a `std::unique_ptr` instead! > > Benjamin Bannier wrote: > +1, or jus

Review Request 47594: Skipped the bind mount of CNI net info root dir if possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47594/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5413 ht

Re: Review Request 47481: Rewrote os::read() to be friendlier to reading binary data.

> On May 19, 2016, 9:12 a.m., Jan Schlicht wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 136 > > > > > > s/delete/delete[] > > > > Why not use a `std::vector` for `buffer`? > > > > I've

Re: Review Request 47484: Added -lelf to default dynamic libraries on Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47484/#review133926 --- Can someone revert this commit? This commit caused I can't find li

Re: Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/ --- (Updated May 19, 2016, 10:29 a.m.) Review request for mesos, Freddy Ayuso-Henso

Review Request 47587: Created separate local data file to manage releases information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/ --- Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim Anderegg,

Re: Review Request 46501: Updated authorization.md to reflect current changes.

> On May 18, 2016, 10:17 a.m., Alexander Rukletsov wrote: > > docs/authorization.md, lines 566-580 > > > > > > It's hard to remember that this doc should be updated if changes to the > > proto are made. Can we refer

Re: Review Request 46501: Updated authorization.md to reflect current changes.

> On May 18, 2016, 12:17 p.m., Alexander Rukletsov wrote: > > docs/authorization.md, lines 566-580 > > > > > > It's hard to remember that this doc should be updated if changes to the > > proto are made. Can we refer

Re: Review Request 47481: Rewrote os::read() to be friendlier to reading binary data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47481/#review133904 --- 3rdparty/stout/include/stout/os/read.hpp (lines 90 - 103)

Re: Review Request 47585: Fixed a mismatched 'delete'.

> On May 19, 2016, 10:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > > > > > Let's just wrap this in a `std::unique_ptr` instead! > > Benjamin Bannier wrote: > +1, or jus

Re: Review Request 47585: Fixed a mismatched 'delete'.

> On May 19, 2016, 10:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > > > > > Let's just wrap this in a `std::unique_ptr` instead! +1, or just a `std::string` since most proba

Re: Review Request 47585: Fixed a mismatched 'delete'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/#review133903 --- Since this was easy to pin down could you mention the commit which

Re: Review Request 47585: Fixed a mismatched 'delete'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/#review133900 --- 3rdparty/stout/include/stout/os/read.hpp (line 118)

Review Request 47585: Fixed a mismatched 'delete'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/ --- Review request for mesos, Benjamin Bannier and Bernd Mathiske. Repository: meso

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133897 --- Fix it, then Ship it! I'll take care of the outstanding issues

Re: Review Request 47463: Added documentation for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133899 --- docs/cni.md (line 5)

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133898 --- Fix it, then Ship it! src/slave/http.cpp

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47400/#review133891 --- Fix it, then Ship it! Thanks a lot, Zhitao! I'll push it shortl

Re: Review Request 47510: Adjusted style to make website mobile friendly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47510/#review133895 --- Ship it! Ship It! - Freddy Ayuso-Henson On May 18, 2016, 6:0

Re: Review Request 47510: Adjusted style to make website mobile friendly.

> On May 19, 2016, 7:12 a.m., Freddy Ayuso-Henson wrote: > > Here are some screenshots of what the original PR aimed to achieve. It's a > > bit different from what's being reviewed, I think (moving the ASF > > links/breadcrumbs to the footer, vertically centering the menu on the > > desktop, a

Re: Review Request 47510: Adjusted style to make website mobile friendly.

> On May 19, 2016, 7:12 a.m., Freddy Ayuso-Henson wrote: > > Here are some screenshots of what the original PR aimed to achieve. It's a > > bit different from what's being reviewed, I think (moving the ASF > > links/breadcrumbs to the footer, vertically centering the menu on the > > desktop, a

  1   2   >