Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- (Updated May 29, 2016, 6:56 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/#review135421 --- docs/cni.md (line 340)

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/#review135419 --- docs/cni.md (line 26)

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/#review135420 --- Bad patch! Reviews applied: [47469, 47943, 47470, 47942] Failed

Re: Review Request 47921: Enabled authorization for Mesos log access.

> On May 27, 2016, 11:21 p.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, lines 519-523 > > > > > > I don't like this. Let's just remove AccessMesosLog.logs() as a field, > > and forego "consistency" in

Re: Review Request 47942: Windows: Added pipe support functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47942/ --- (Updated May 29, 2016, 5:56 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47943/ --- (Updated May 29, 2016, 5:40 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47470: Stout: Added `os::temp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47470/ --- (Updated May 29, 2016, 5:32 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 29, 2016, 5:31 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47991/#review135417 --- don't think i follow this change. can you explain why wrapping it

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47943/ --- (Updated May 29, 2016, 4:47 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47842: Point slave flags at programmatic temp path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47842/ --- (Updated May 29, 2016, 4:47 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47990: Added move semantics to `Pipe::write()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47990/#review135416 --- what's the reason for not having a rvalue ref overload? - Vinod K

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 29, 2016, 3:35 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47989: Added move semantics to `Future::set`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47989/#review135414 --- Ship it! Ship It! - Vinod Kone On May 27, 2016, 10:14 p.m.,

Re: Review Request 47987: Constrained constructible types constructor for `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47987/#review135412 --- 3rdparty/stout/include/stout/result.hpp (lines 65 - 67)

Re: Review Request 47988: Added move constructor/assignment to `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47988/#review135413 --- Ship it! Ship It! - Vinod Kone On May 27, 2016, 10:14 p.m.,

Re: Review Request 47986: Added move constructor/assignment operator to `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47986/#review135411 --- Ship it! Ship It! - Vinod Kone On May 27, 2016, 10:14 p.m.,

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 29, 2016, 2:30 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47660: Fixed slave switch user logic in 'getExecutorInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47660/#review135410 --- src/slave/slave.cpp (line 3942)

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/ --- (Updated May 29, 2016, 2:16 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/ --- (Updated May 29, 2016, 2:15 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 48000: Windows MVP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48000/ --- (Updated May 29, 2016, 2:14 a.m.) Review request for mesos. Repository: mesos

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 29, 2016, 2:12 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47942: Windows: Added pipe support functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47942/ --- (Updated May 29, 2016, 2:11 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47602/ --- (Updated May 29, 2016, 2:07 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47942: Windows: Added pipe support functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47942/ --- (Updated May 29, 2016, 2:06 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 48015: Implemented v1::agent::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48015/ --- (Updated May 29, 2016, 1:39 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

> On May 29, 2016, 1:36 a.m., Vinod Kone wrote: > > Can you rebased this? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review135408 -

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review135408 --- Ship it! src/files/files.cpp (line 374)

Re: Review Request 48015: Implemented v1::agent::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48015/#review135407 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Review Request 48015: Implemented v1::agent::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48015/ --- Review request for mesos. Bugs: MESOS-4791 https://issues.apache.org/jira/b

Review Request 48014: Added the route handler for v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48014/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues. Bu

Re: Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48012/ --- (Updated May 29, 2016, 1:19 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- (Updated May 29, 2016, 1:17 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 47942: Windows: Added pipe support functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47942/ --- (Updated May 29, 2016, 12:07 a.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/#review135406 --- Ship it! LGTM modulo the comments I made. I'll fix them when co

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

> On May 25, 2016, 9:45 a.m., Jan Schlicht wrote: > > src/slave/http.cpp, line 384 > > > > > > s/slaveFlags/slave->flags/, see comment above. don't need to pass the flags at all since this is now a member function.

Re: Review Request 48008: Added v1 protos for master and agent APIs.

> On May 28, 2016, 10:58 p.m., Kevin Klues wrote: > > include/mesos/v1/agent.hpp, lines 35-36 > > > > > > Why is this wrapped and the one aboove not? They are the same line > > length it's not of the same length! th

Re: Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48012/#review135403 --- There's alot of code here, but it looks good overall. I'll defer t

Re: Review Request 48011: Added overload for `http::OK()` that takes ContentType.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48011/#review135402 --- 3rdparty/libprocess/include/process/http.hpp (lines 524 - 526)

Re: Review Request 48010: Updated Makefile.am to properly build the v1 API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48010/#review135401 --- src/Makefile.am (lines 223 - 226)

Re: Review Request 48009: Added v1 protos for maintenance, allocator and quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48009/#review135400 --- include/mesos/v1/master/allocator.proto (line 28)

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/#review135398 --- include/mesos/v1/agent.hpp (lines 35 - 36)

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47943/#review135399 --- Bad patch! Reviews applied: [47943, 47942, 47411, 47410, 47409, 4

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47602/ --- (Updated May 28, 2016, 10:43 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 28, 2016, 10:28 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

> On May 24, 2016, 11:37 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/launcher.hpp, lines 118-119 > > > > > > Is this the only difference? > > It would be great if we could clearly identify

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47943/ --- (Updated May 28, 2016, 10:06 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48012/#review135397 --- Patch looks great! Reviews applied: [48008, 48009, 48010, 48011,

Re: Review Request 47942: Windows: Added pipe support functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47942/#review135396 --- src/slave/containerizer/mesos/posix_pipe.hpp (line 13)

Re: Review Request 47942: Windows: Added pipe support functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47942/ --- (Updated May 28, 2016, 9:39 p.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 28, 2016, 9:32 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47704: Used TaskObjectAllower to filter /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 28, 2016, 9:31 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47559: Added authorization based filtering to /state-summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/ --- (Updated May 28, 2016, 9:29 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47842: Point slave flags at programmatic temp path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47842/ --- (Updated May 28, 2016, 9:12 p.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 28, 2016, 9:02 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/#review135308 --- include/mesos/authorizer/authorizer.hpp (line 40)

Re: Review Request 47536: Agent: Added Windows isolators.

> On May 24, 2016, 11:27 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/isolators/filesystem/windows.hpp, lines 31-38 > > > > > > Can you explain what we are accomplishing here by making this prox

Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48012/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues. Bu

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- (Updated May 28, 2016, 8:29 p.m.) Review request for mesos, Anand Mazumdar, Ben

Review Request 48011: Added overload for `http::OK()` that takes ContentType.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48011/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues. Bu

Re: Review Request 48002: Windows: Undefined macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48002/ --- (Updated May 28, 2016, 8:24 p.m.) Review request for mesos, Daniel Pravat, Arte

Review Request 48010: Updated Makefile.am to properly build the v1 API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48010/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues. Bu

Re: Review Request 48000: Windows MVP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48000/ --- (Updated May 28, 2016, 8:24 p.m.) Review request for mesos. Repository: mesos

Review Request 48009: Added v1 protos for maintenance, allocator and quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48009/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues. Bu

Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues. Bu

Re: Review Request 47921: Enabled authorization for Mesos log access.

> On May 28, 2016, 8:21 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, lines 519-523 > > > > > > I don't like this. Let's just remove AccessMesosLog.logs() as a field, > > and forego "consistency" in f

Re: Review Request 47921: Enabled authorization for Mesos log access.

> On May 28, 2016, 8:21 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, lines 519-523 > > > > > > I don't like this. Let's just remove AccessMesosLog.logs() as a field, > > and forego "consistency" in f

Re: Review Request 47509: Fixed authorization::Request initializings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47509/#review135386 --- I think we should allow each action to define whether or not it re

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/#review135385 --- Not sure if I'm supposed to be reviewing this or https://reviews.

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/ --- (Updated May 28, 2016, 7:38 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47536: Agent: Added Windows isolators.

> On May 24, 2016, 11:27 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp, line 130 > > > > > > Why? > > What about the code below isn't supported on windows? We

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47602/ --- (Updated May 28, 2016, 7:01 a.m.) Review request for mesos, Daniel Pravat, Arte