Re: Review Request 48020: Refreshed the Mesos project website homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48020/ --- (Updated May 30, 2016, 2:26 a.m.) Review request for mesos, Tomasz Janiszewski

Re: Review Request 48020: Refreshed the Mesos project website homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48020/#review135461 --- site/source/index.html.erb (line 107)

Re: Review Request 48020: Refreshed the Mesos project website homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48020/ --- (Updated May 30, 2016, 2:10 a.m.) Review request for mesos, Tomasz Janiszewski

Review Request 48020: Refreshed the Mesos project website homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48020/ --- Review request for mesos, Tomasz Janiszewski and Vinod Kone. Bugs: MESOS-5519

Re: Review Request 48019: Implemented v1::agent::Call::GET_VERSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48019/ --- (Updated May 30, 2016, 1:24 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48016: Implemented v1::master::Call::GET_VERSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48016/ --- (Updated May 30, 2016, 1:24 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48018: Implemented v1::agent::Call::GET_HEALTH.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48018/ --- (Updated May 30, 2016, 1:23 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48017: Implemented v1::master::Call::GET_HEALTH.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48017/ --- (Updated May 30, 2016, 1:22 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48014: Added the route handler for v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48014/ --- (Updated May 30, 2016, 1:21 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48015: Implemented v1::agent::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48015/ --- (Updated May 30, 2016, 1:22 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48014: Added the route handler for v1 agent API.

> On May 29, 2016, 8:14 p.m., Benjamin Hindman wrote: > > src/slave/http.cpp, line 265 > > > > > > Unused variable, but I'm guessing it's used in a subsequent patch. One > > thought here, to avoid the declared but

Re: Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48012/ --- (Updated May 30, 2016, 1:20 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review135456 --- Bad patch! Reviews applied: [47511] Failed command:

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 29, 2016, 11:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 48002: Windows: Undefined macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48002/ --- (Updated May 29, 2016, 10:25 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/#review135455 --- Ship it! Ship It! - Anand Mazumdar On May 29, 2016, 9:38

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/ --- (Updated May 29, 2016, 10:20 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47486: Windows: Escaped command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47486/ --- (Updated May 29, 2016, 10:10 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 48011: Added overload for `http::OK()` that takes ContentType.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48011/#review135454 --- 3rdparty/libprocess/include/process/http.hpp (lines 524 - 526)

Re: Review Request 48011: Added overload for `http::OK()` that takes ContentType.

> On May 28, 2016, 11:03 p.m., Kevin Klues wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 524-526 > > > > > > I would probably move this up above the one before it, to group > > constructors that

Re: Review Request 48003: Remove SASL dependency from agent tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48003/ --- (Updated May 29, 2016, 9:49 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 48000: Windows MVP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48000/ --- (Updated May 29, 2016, 9:46 p.m.) Review request for mesos. Repository:

Re: Review Request 48008: Added v1 protos for master and agent APIs.

> On May 29, 2016, 7:12 p.m., Anand Mazumdar wrote: > > include/mesos/v1/master.proto, line 59 > > > > > > s/streaming// > > > > hmm.. I find it a bit odd to include the business logic of the > >

Re: Review Request 48010: Updated Makefile.am to properly build the v1 API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48010/ --- (Updated May 29, 2016, 9:42 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48009: Added v1 protos for maintenance, allocator and quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48009/ --- (Updated May 29, 2016, 9:40 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- (Updated May 29, 2016, 9:38 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 47470: Stout: Added `os::temp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47470/ --- (Updated May 29, 2016, 9:22 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

> On May 29, 2016, 8 p.m., Benjamin Hindman wrote: > > src/master/http.cpp, line 1101 > > > > > > It doesn't look like `__flags` needs to be asynchronous, any reason to > > not do it that way? > > > > ```

Re: Review Request 48019: Implemented v1::agent::Call::GET_VERSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48019/#review135451 --- Ship it! Ship It! - Benjamin Hindman On May 29, 2016, 7:06

Re: Review Request 48016: Implemented v1::master::Call::GET_VERSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48016/#review135450 --- Ship it! Ship It! src/version/version.hpp (line 29)

Re: Review Request 48018: Implemented v1::agent::Call::CHECK_HEALTH.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48018/#review135448 --- Ship it! LGTM barring comments in previous reviews! -

Re: Review Request 48015: Implemented v1::agent::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48015/#review135446 --- Ship it! LGTM barring comments in previous reviews on this

Re: Review Request 48017: Implemented v1::master::Call::CHECK_HEALTH.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48017/#review135447 --- Ship it! Barring comments in previous reviews. - Benjamin

Re: Review Request 48014: Added the route handler for v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48014/#review135443 --- Fix it, then Ship it! src/slave/http.cpp (line 265)

Re: Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

> On May 29, 2016, 8 p.m., Benjamin Hindman wrote: > > src/master/http.cpp, line 1101 > > > > > > It doesn't look like `__flags` needs to be asynchronous, any reason to > > not do it that way? > > > > ```

Re: Review Request 48011: Added overload for `http::OK()` that takes ContentType.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48011/#review135444 --- Ship it! Ship It! - Anand Mazumdar On May 28, 2016, 8:26

Re: Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48012/#review135438 --- Fix it, then Ship it! src/internal/evolve.hpp (line 106)

Re: Review Request 48010: Updated Makefile.am to properly build the v1 API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48010/#review135440 --- Ship it! Modulo Kevin's comment. - Anand Mazumdar On May

Re: Review Request 48009: Added v1 protos for maintenance, allocator and quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48009/#review135439 --- Ship it! Ship It! - Anand Mazumdar On May 28, 2016, 8:24

Re: Review Request 48015: Implemented v1::agent::Call::GET_FLAGS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48015/ --- (Updated May 29, 2016, 7:38 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48010: Updated Makefile.am to properly build the v1 API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48010/#review135436 --- Ship it! Ship It! - Benjamin Hindman On May 28, 2016, 8:25

Re: Review Request 48009: Added v1 protos for maintenance, allocator and quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48009/#review135435 --- Ship it! Ship It! - Benjamin Hindman On May 28, 2016, 8:24

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/#review135430 --- Looks very good. The only small concern being around ordering

Re: Review Request 47942: Windows: Added pipe support functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47942/ --- (Updated May 29, 2016, 7:09 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47921: Enabled authorization for Mesos log access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47921/#review135433 --- Ship it! Ship it! I updated the acls.proto comment as you

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/#review135431 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 47470: Stout: Added `os::temp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47470/ --- (Updated May 29, 2016, 4:15 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47921: Enabled authorization for Mesos log access.

> On May 28, 2016, 8:21 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, lines 519-523 > > > > > > I don't like this. Let's just remove AccessMesosLog.logs() as a field, > > and forego "consistency" in

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 29, 2016, 3:46 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47559: Added authorization based filtering to /state-summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/ --- (Updated May 29, 2016, 3:45 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47704: Used TaskObjectAllower to filter /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 29, 2016, 3:45 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 29, 2016, 3:44 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/ --- (Updated May 29, 2016, 3:43 p.m.) Review request for mesos. Repository:

Re: Review Request 48019: Implemented v1::agent::Call::GET_VERSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48019/#review135426 --- Patch looks great! Reviews applied: [48008, 48009, 48010, 48011,

Re: Review Request 47987: Constrained constructible types constructor for `Result`.

> On May 29, 2016, 2:46 a.m., Vinod Kone wrote: > > 3rdparty/stout/include/stout/result.hpp, lines 65-67 > > > > > > what does this do? can you add some more info to the description for > > posterity? My bad,

Re: Review Request 47987: Constrained constructible types constructor for `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47987/ --- (Updated May 29, 2016, 9:05 a.m.) Review request for mesos, Michael Park and

Re: Review Request 47990: Added move semantics to `Pipe::write()`.

> On May 29, 2016, 4:46 a.m., Vinod Kone wrote: > > what's the reason for not having a rvalue ref overload? I discussed this with mpark and we agreed that for sink arguments, just passing by value is good enough for movable types like `std::string`. This incurs the extra overhead of one move

Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.

> On May 29, 2016, 4:53 a.m., Vinod Kone wrote: > > don't think i follow this change. can you explain why wrapping it in owned > > performs better? Copying the `Request` object upon every `::stream` call was very expensive. The motive behind this change is to create the `Request` object once

Review Request 48018: Implemented v1::agent::Call::CHECK_HEALTH.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48018/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.

Review Request 48017: Implemented v1::master::Call::CHECK_HEALTH.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48017/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.

Re: Review Request 48008: Added v1 protos for master and agent APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48008/ --- (Updated May 29, 2016, 6:56 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/#review135421 --- docs/cni.md (line 340)

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/#review135419 --- docs/cni.md (line 26)

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/#review135420 --- Bad patch! Reviews applied: [47469, 47943, 47470, 47942] Failed

Re: Review Request 47921: Enabled authorization for Mesos log access.

> On May 27, 2016, 11:21 p.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, lines 519-523 > > > > > > I don't like this. Let's just remove AccessMesosLog.logs() as a field, > > and forego "consistency" in