Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 13, 2016, 10:07 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 596-632 > > > > > > s/mesos::// > > Anand Mazumdar wrote: > I guess @haosdent had to add them due to there being an already

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/ --- (Updated June 15, 2016, 3:39 a.m.) Review request for mesos, Guangya Liu and

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/ --- (Updated June 15, 2016, 3:36 a.m.) Review request for mesos, Guangya Liu and

Re: Review Request 48587: Added unversioned protos for agent API.

> On June 13, 2016, 8:18 p.m., Anand Mazumdar wrote: > > Can we name the unversioned proto file as just `agent.proto`? It would be > > good to not introduce the `Slave` terminology going forward :-) > > Vinod Kone wrote: > also the package name, class name, namespace etc. Awesome! Let me

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 13, 2016, 10:07 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 596-632 > > > > > > s/mesos::// > > Anand Mazumdar wrote: > I guess @haosdent had to add them due to there being an already

Re: Review Request 48206: Fix example in configuration docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48206/#review137645 --- Ship it! Ship It! - Till Toenshoff On June 3, 2016, 2:31

Re: Review Request 48530: Moved working groups from wiki to page.

> On June 10, 2016, 4:25 p.m., Jie Yu wrote: > > In fact, for working groups, I would prefer adding that to the docs so that > > people can find/read it on github. It is also constantly changing, updating > > it in docs sounds easier than updating the website. What do you think? > > Tomasz

Re: Review Request 48369: Fixed comment in Nvidia GPU device isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48369/#review137642 --- Ship it! Ship It! - Benjamin Mahler On June 11, 2016, 3:06

Re: Review Request 48368: Changed major/minor device types for Nvidia GPUs to `unsigned int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48368/#review137641 --- Ship it! Ship It! - Benjamin Mahler On June 11, 2016, 3:06

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review137640 --- I did a bunch of grammar fixes for you. Please take a look at the

Re: Review Request 47893: Changed initialization order of `Anonymous` modules in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47893/#review137635 --- Bad patch! Reviews applied: [47893, 47892] Failed command:

Re: Review Request 48669: Modified os user test for user switching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48669/ --- (Updated June 14, 2016, 4:29 p.m.) Review request for mesos, Artem

Re: Review Request 47668: Obtained uid/gids before changing filesystem root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47668/ --- (Updated June 14, 2016, 4:29 p.m.) Review request for mesos, Artem

Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47667/ --- (Updated June 14, 2016, 4:28 p.m.) Review request for mesos, Artem

Re: Review Request 47666: Added stout functions to set uid and gid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47666/ --- (Updated June 14, 2016, 4:28 p.m.) Review request for mesos, Artem

Re: Review Request 47663: Added image user to 'ContainerLaunchInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47663/ --- (Updated June 14, 2016, 4:28 p.m.) Review request for mesos, Artem

Re: Review Request 47664: Implemented image user support in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47664/ --- (Updated June 14, 2016, 4:28 p.m.) Review request for mesos, Artem

Review Request 48711: Fixed isolator proto message bracket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48711/ --- Review request for mesos, Guangya Liu and Jie Yu. Repository: mesos

Re: Review Request 47661: Improved the mesos containerizer windows related logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47661/ --- (Updated June 14, 2016, 4:27 p.m.) Review request for mesos, Artem

Re: Review Request 47660: Fixed agent switch user redundant logic in 'getExecutorInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47660/ --- (Updated June 14, 2016, 4:27 p.m.) Review request for mesos, Artem

Re: Review Request 48669: Modified os user test for user switching.

> On June 13, 2016, 6:07 p.m., James Peach wrote: > > 3rdparty/stout/tests/os_tests.cpp, line 685 > > > > > > Since you need root, consider making this a separate test using the > > "ROOT_" filter. stout test does

Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.

> On June 13, 2016, 6:15 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/su.hpp, line 177 > > > > > > Bear in mind that ``SC_NGROUPS_MAX`` is not meaningful on Darwin other > > than it is the

Re: Review Request 47663: Added image user to 'ContainerLaunchInfo'.

> On June 14, 2016, 8:47 a.m., Guangya Liu wrote: > > include/mesos/slave/isolator.proto, lines 131-139 > > > > > > I saw that from > >

Re: Review Request 47660: Fixed agent switch user redundant logic in 'getExecutorInfo'.

> On June 14, 2016, 8:19 a.m., Guangya Liu wrote: > > Gilbert, I think it is better to file a JIRA to trace this patch chain, > > comments? There is one, MESOS-4757. I am attaching it. Thanks, Guangya! - Gilbert --- This is an

Re: Review Request 48602: Implemented v1::master::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48602/#review137609 --- src/internal/evolve.cpp (line 551)

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/#review137608 --- same comments as previous review. - Vinod Kone On June 12,

Re: Review Request 48602: Implemented v1::master::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48602/#review137607 --- src/tests/api_tests.cpp (line 217)

Re: Review Request 48601: Exposed metrics information via `process::metrics::snapshot`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48601/#review137604 --- 3rdparty/libprocess/src/metrics/metrics.cpp (lines 251 - 279)

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review136970 --- A high level comment is that when we are making significant

Re: Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48705/#review137601 --- Patch looks great! Reviews applied: [48704, 48705] Passed

Re: Review Request 47893: Changed initialization order of `Anonymous` modules in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47893/ --- (Updated June 14, 2016, 9:45 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 47892: Re-ordered initialization for Agent `Anonymous` modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47892/ --- (Updated June 14, 2016, 9:45 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 48600: Used `DurationInfo` as `timeout` type in `GetMetrics` operation APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48600/#review137588 --- include/mesos/master/master.proto (line 88)

Re: Review Request 48597: Implemented v1::agent::Call::SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48597/#review137587 --- Same comments as previous review. - Vinod Kone On June 12,

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48596/#review137585 --- src/tests/api_tests.cpp (line 101)

Re: Review Request 48363: Moved 'isolators/cgroups/devices/gpus' to 'isolators/gpu'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48363/#review137578 --- Ship it! src/slave/containerizer/mesos/containerizer.cpp

Re: Review Request 48370: Fixed method of populating device entries for `/dev/nvidia-uvm`, etc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48370/#review137576 --- Fix it, then Ship it!

Re: Review Request 48694: Optimized `UUID::fromString` and `UUID::toString` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48694/#review137577 --- Patch looks great! Reviews applied: [48692, 48693, 48694]

Re: Review Request 48578: Fixed bug with double destruction of cgroups devices subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48578/#review137573 --- Ship it! Ship It! - Benjamin Mahler On June 11, 2016, 3:03

Re: Review Request 48704: Updated FilesProcess to support List_Files Call in Operator API v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48704/ --- (Updated June 14, 2016, 7:19 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48705/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Review Request 48704: Updated FilesProcess to support List_Files Call in Operator API v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48704/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Re: Review Request 48497: Added documentation on starting to use acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48497/#review137563 --- Patch looks great! Reviews applied: [48495, 48496, 48497]

Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.

> On June 13, 2016, 6:15 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/su.hpp, line 177 > > > > > > Bear in mind that ``SC_NGROUPS_MAX`` is not meaningful on Darwin other > > than it is the

Re: Review Request 48595: Exposed the logging process `PID` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48595/#review137556 --- Fix it, then Ship it!

Re: Review Request 48687: Enhanced log message if the absolute path does not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48687/#review137549 --- Patch looks great! Reviews applied: [48687] Passed command:

Re: Review Request 47972: Updated rmdir to optionally continue deletion on error.

> On June 8, 2016, 5:22 a.m., Jiang Yan Xu wrote: > > 3rdparty/stout/include/stout/os/windows/rmdir.hpp, line 120 > > > > > > This looks to be over 80 chars too, let's fix all of them by running > > mesos-style.py.

Re: Review Request 46762: Enabled volume support for mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46762/#review137530 --- Patch looks great! Reviews applied: [48680, 46762] Passed

Re: Review Request 48387: Delay before initiating a connection with master.

> On June 14, 2016, 2:40 p.m., Anand Mazumdar wrote: > > src/scheduler/scheduler.cpp, lines 484-490 > > > > > > hmm .. Why do you need to load the flags again here? You already did so > > on line L154, no? > >

Re: Review Request 47663: Added image user to 'ContainerLaunchInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47663/#review137523 --- include/mesos/slave/isolator.proto (lines 30 - 31)

Re: Review Request 48387: Delay before initiating a connection with master.

> On June 14, 2016, 11:40 a.m., Anand Mazumdar wrote: > > src/scheduler/scheduler.cpp, line 320 > > > > > > As per my review comment in an earlier version of the patch, let's have > > the signature of this method

Re: Review Request 47660: Fixed agent switch user redundant logic in 'getExecutorInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47660/#review137518 --- Gilbert, I think it is better to file a JIRA to trace this patch

Review Request 48693: Added tests for `UUID::fromString`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48693/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Review Request 48692: Cleaned up header includes in stout/uuid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48692/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Review Request 48694: Optimized `UUID::fromString` and `UUID::toString` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48694/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 48387: Delay before initiating a connection with master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48387/#review137507 --- This is looking much better. Can you include both

Re: Review Request 48320: Update C++ style checker to prevent NULL usage.

> On June 14, 2016, 2:36 p.m., Benjamin Bannier wrote: > > support/cpplint.py, line 1 > > > > > > Not in this file, but do we need to update `cpplint.patch` as well? We > > seem to have stopped doing that at some

Re: Review Request 48684: Revised documentation for task reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48684/#review137510 --- Patch looks great! Reviews applied: [48684] Passed command:

Re: Review Request 48320: Update C++ style checker to prevent NULL usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48320/#review137508 --- Fix it, then Ship it! support/cpplint.py (line 1)

Re: Review Request 48496: Fixed misleading acls example in authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48496/ --- (Updated June 14, 2016, 1:21 p.m.) Review request for mesos and Adam B.

Re: Review Request 48495: Added missing 'get_weights' actions to authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48495/ --- (Updated June 14, 2016, 1:21 p.m.) Review request for mesos and Adam B.

Re: Review Request 48497: Added documentation on starting to use acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48497/ --- (Updated June 14, 2016, 1:20 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.

> On June 14, 2016, 1:13 p.m., Joerg Schad wrote: > > docs/authorization.md, line 140 > > > > > > Could we > > a) check that the HTTP HELP text is correct for all these endpoints > > (i.e, mentions

Re: Review Request 48497: Added documentation on starting to use acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48497/#review137498 --- Bad patch! Reviews applied: [48497, 48496, 48495] Failed

Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46887/#review137495 --- docs/authorization.md (line 140)

Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46887/#review137492 --- Patch looks great! Reviews applied: [46887] Passed command:

Review Request 48687: Enhanced log message if the absolute path does not exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48687/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5611

Review Request 48680: Stout: Added parse() for JSON::Array.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48680/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5265

Re: Review Request 46762: Enabled volume support for mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46762/ --- (Updated 六月 14, 2016, 12:19 p.m.) Review request for mesos, Gilbert Song and

Review Request 48684: Revised documentation for task reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48684/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 48497: Added documentation on starting to use acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48497/#review137488 --- docs/authorization.md (line 100)

Re: Review Request 48497: Added documentation on starting to use acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48497/ --- (Updated June 14, 2016, 11:54 a.m.) Review request for mesos, Adam B and Neil

Re: Review Request 48497: Added documentation on starting to use acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48497/#review137487 --- Typo in summary ("permissive"). docs/authorization.md (line

Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46887/ --- (Updated June 14, 2016, 1:46 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review137481 --- Patch looks great! Reviews applied: [45377, 36440] Passed

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 六月 14, 2016, 9:49 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

> On 六月 14, 2016, 8:42 a.m., Gilbert Song wrote: > > src/docker/docker.cpp, line 548 > > > > > > This will segfault if no driver specified, right? > > > > I roughly remember docker supports volume by using

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review137473 --- Bad patch! Reviews applied: [47511] Failed command:

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated 六月 14, 2016, 9:19 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 44500: Implemented passing image and user env var to command task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44500/#review137471 --- Patch looks great! Reviews applied: [44498, 44499, 44500]

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 8, 2016, 1:28 p.m., Neil Conway wrote: > > Overall seems like a reasonable approach. > > > > One thing that isn't clear to me: what is the advantage of updating the > > checkpoint to reflect any partial work that was done before exiting? It > > seems that adds a bunch of complexity

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review137467 --- src/slave/slave.cpp (line 2540)

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review137466 --- src/docker/docker.cpp (line 548)

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review137464 --- Fix it, then Ship it! This is great! Thanks, Guangya!

Re: Review Request 44500: Implemented passing image and user env var to command task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44500/ --- (Updated June 14, 2016, 1:04 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 44499: Added task_environment flag/used execvpe for command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44499/ --- (Updated June 14, 2016, 1:04 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 44498: Forbid the executor to inherit from slave environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44498/ --- (Updated June 14, 2016, 1:03 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 48675: Added TODO to support Docker 'whiteout' deletions on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48675/#review137459 --- Bad patch! Reviews applied: [48675, 48002, 48004, 48003, 47842,

Review Request 48675: Added TODO to support Docker 'whiteout' deletions on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48675/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 48593: Refactor Ranges Subtraction.

> On June 13, 2016, 12:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, lines 409-420 > > > > > > Thanks for digging into this issue further. > > Please do read my response on your e-mail thread