Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
> On June 27, 2016, 12:36 a.m., Anand Mazumdar wrote: > > src/master/http.cpp, lines 1505-1506 > > > > > > Do we need this explicit check here? I can understand why we > > introduced/need it in `GET_LEADER` but why

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

2016-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49246/#review139528 --- Patch looks great! Reviews applied: [49140, 49246] Passed comman

Re: Review Request 49136: Add Framework protobuf message.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/ --- (Updated 六月 27, 2016, 7:47 a.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/ --- (Updated 六月 27, 2016, 7:48 a.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread zhou xing
> On 六月 24, 2016, 9:57 p.m., Vinod Kone wrote: > > src/master/weights_handler.cpp, line 216 > > > > > > why this change? looks like we want a sanitized role (#193) to be > > inside validatedWeightInfos. Vinod, at l

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
> On June 27, 2016, 12:36 a.m., Anand Mazumdar wrote: > > src/tests/api_tests.cpp, lines 567-568 > > > > > > Do we need the explicit `static_cast` here? Why doesn't `CopyFrom()` > > work directly? Did not quite get

Re: Review Request 48841: Add Agent protobuf message.

2016-06-27 Thread zhou xing
> On 六月 24, 2016, 10:26 p.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 295 > > > > > > new line to make it clear that the comment applies only to > > `total_resources`. The total_resource is de

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/ --- (Updated June 27, 2016, 8:19 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 49062: Fixed lambda capture list for consistency.

2016-06-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49062/#review139534 --- Ship it! Ship It! - Alexander Rojas On June 25, 2016, 2:32 p

Re: Review Request 48841: Add Agent protobuf message.

2016-06-27 Thread zhou xing
> On June 24, 2016, 10:26 p.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 295 > > > > > > new line to make it clear that the comment applies only to > > `total_resources`. > > zhou xing wrote: >

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

2016-06-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49246/#review139536 --- Can you provide some benchmarks to validate whether these changes

Re: Review Request 48841: Add Agent protobuf message.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/ --- (Updated 六月 27, 2016, 9:01 a.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 27, 2016, 9:03 a.m.) Review request for mesos, Anand Mazumdar, haos

Review Request 49251: Added missing AUTHORIZATION endpoint documentation.

2016-06-27 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49251/ --- Review request for mesos, Alexander Rukletsov and Neil Conway. Bugs: MESOS-5711

Review Request 49250: Regenerated endpoint documention.

2016-06-27 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49250/ --- Review request for mesos, Alexander Rukletsov and Neil Conway. Bugs: MESOS-5711

Re: Review Request 49247: Implemented REMOVE_QUOTA Call in v1 master API.

2016-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49247/#review139538 --- Patch looks great! Reviews applied: [49206, 49247] Passed comman

Review Request 49242: Add GetFileContents protobuf message.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. Bugs:

Review Request 49243: Create readFile method in FilesProcess.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49243/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. Bugs:

Review Request 49244: Implement READ_FILE for master operator API.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49244/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. Bugs:

Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49245/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. Bugs:

Re: Review Request 49250: Regenerated endpoint documention.

2016-06-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49250/#review139537 --- docs/endpoints/master/state-summary.md (line 23)

Re: Review Request 48058: Added authorization based endpoint filtering documentation.

2016-06-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48058/#review139539 --- docs/authorization.md (lines 638 - 655)

Re: Review Request 49226: Implemented UNRESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49226/ --- (Updated June 27, 2016, 9:14 a.m.) Review request for mesos, Anand Mazumdar and

Review Request 49254: Made authorization.md consistent in respect to columns width.

2016-06-27 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49254/ --- Review request for mesos, Alexander Rukletsov and Alexander Rojas. Repository:

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

2016-06-27 Thread Klaus Ma
> On June 27, 2016, 4:25 p.m., Neil Conway wrote: > > Can you provide some benchmarks to validate whether these changes improve > > performance, and for what kinds of inputs? (e.g., short vs. long strings, > > found match vs. no-match-found). @neil, thanks for your comments; benchmarks maybe n

Review Request 49252: Cgroups unified isolator draft.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49252/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Bugs: MESOS-469

Re: Review Request 49252: Cgroups unified isolator draft.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49252/ --- (Updated June 27, 2016, 9:53 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49196: Disabled authorization from the `/flags` endpoints.

2016-06-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49196/ --- (Updated June 27, 2016, noon) Review request for mesos, Adam B, Jan Schlicht, a

Re: Review Request 49201: Added validation for the `get_endpoints` ACL.

2016-06-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49201/ --- (Updated June 27, 2016, 12:02 p.m.) Review request for mesos, Adam B, Jan Schli

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
> On June 25, 2016, 3:26 p.m., Tomasz Janiszewski wrote: > > src/webui/master/static/js/controllers.js, line 162 > > > > > > Probably `task.state` could be used here. > > Vinod Kone wrote: > yup. just use `task.

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 10:03 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 49257: Added documentation on coarse grain authorization for endpoints.

2016-06-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49257/ --- Review request for mesos, Adam B, Joerg Schad, Jan Schlicht, and Till Toenshoff.

Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.

2016-06-27 Thread Alexander Rojas
> On June 14, 2016, 3:13 p.m., Joerg Schad wrote: > > Given that Jörg is busy to finish this patch, It get's superseeded by [r/49257/](https://reviews.apache.org/r/49257/) > On June 14, 2016, 3:13 p.m., Joerg Schad wrote: > > docs/authorization.md, line 140 > >

Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.

2016-06-27 Thread Alexander Rojas
> On June 14, 2016, 3:13 p.m., Joerg Schad wrote: > > > > Alexander Rojas wrote: > Given that Jörg is busy to finish this patch, It get's superseeded by > [r/49257/](https://reviews.apache.org/r/49257/) I mean Jan - Alexander ---

Re: Review Request 49254: Made authorization.md consistent in respect to columns width.

2016-06-27 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49254/ --- (Updated June 27, 2016, 10:33 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 49250: Regenerated endpoint documention.

2016-06-27 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49250/ --- (Updated June 27, 2016, 10:37 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 49251: Added missing AUTHORIZATION endpoint documentation.

2016-06-27 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49251/ --- (Updated June 27, 2016, 10:37 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
> On June 27, 2016, 3:49 a.m., Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 29 > > > > > > should be filtered by `disconnected` boolean. > > > > a framework in master has two tags assoc

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/#review139550 --- Patch looks great! Reviews applied: [49136, 49137] Passed comman

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
> On June 27, 2016, 3:49 a.m., Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 29 > > > > > > should be filtered by `disconnected` boolean. > > > > a framework in master has two tags assoc

Re: Review Request 49063: Updating formatting of some lambda calls for readability.

2016-06-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49063/ --- (Updated June 27, 2016, 11:23 a.m.) Review request for mesos, Joerg Schad and M

Re: Review Request 49254: Made authorization.md consistent in respect to columns width.

2016-06-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49254/#review139552 --- Ship it! Ship It! - Alexander Rojas On June 27, 2016, 12:33

Re: Review Request 49140: Added startsWith/endsWith to support char.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49140/#review139554 --- Ship it! Ship It! - haosdent huang On June 26, 2016, 9:46 a.

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49246/#review139553 --- Ship it! Ship It! - haosdent huang On June 27, 2016, 6:16 a.

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

2016-06-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49246/#review139555 --- Ship it! Ship It! - Neil Conway On June 27, 2016, 6:16 a.m.,

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2016-06-27 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41658/#review111696 --- src/master/allocator/mesos/hierarchical.cpp (line 534)

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review139561 --- Patch looks great! Reviews applied: [48835, 48841, 48438] Passed

Review Request 49262: Added '--enable-netlink' into configure.ac.

2016-06-27 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49262/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5646 ht

Re: Review Request 48264: Added test for optional request.object field.

2016-06-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48264/#review139569 --- src/tests/authorization_tests.cpp (line 2108)

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/#review139571 --- src/master/http.cpp (line 1283)

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49245/#review139572 --- Fix it, then Ship it! Ship It! src/slave/http.cpp (lines 1337

Re: Review Request 49244: Implement READ_FILE for master operator API.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49244/#review139573 --- Fix it, then Ship it! Ship It! src/master/http.cpp (lines 213

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49245/#review139574 --- Patch looks great! Reviews applied: [49242, 49243, 49244, 49245]

Re: Review Request 49243: Create readFile method in FilesProcess.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49243/#review139575 --- src/files/files.hpp (lines 64 - 67)

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2016-06-27 Thread James Peach
> On June 27, 2016, 12:34 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 534 > > > > > > I think we do not need to insert slave here but only insert slave in > > addSlave and remove s

Re: Review Request 49252: Cgroups unified isolator draft.

2016-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49252/#review139582 --- Patch looks great! Reviews applied: [49252] Passed command: expo

Re: Review Request 49242: Add GetFileContents protobuf message.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/#review139585 --- Ship it! Ship It! - haosdent huang On June 27, 2016, 9:10 a.

Review Request 49269: Added helper function for /containers endpoint.

2016-06-27 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49269/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5518 h

Re: Review Request 49015: Implemented GET_CONTAINERS Call in v1 Agent API.

2016-06-27 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49015/ --- (Updated June 27, 2016, 4:07 p.m.) Review request for mesos, Anand Mazumdar, ha

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review139586 --- Ship it! Ship It! - haosdent huang On June 27, 2016, 9:03 a.

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread haosdent huang
> On June 24, 2016, 9:57 p.m., Vinod Kone wrote: > > src/master/weights_handler.cpp, line 216 > > > > > > why this change? looks like we want a sanitized role (#193) to be > > inside validatedWeightInfos. > > zhou

Re: Review Request 49136: Add Framework protobuf message.

2016-06-27 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/#review139592 --- Fix it, then Ship it! Looks good. I think this is sufficient to

Re: Review Request 49247: Implemented REMOVE_QUOTA Call in v1 master API.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49247/#review139595 --- Ship it! Ship It! - haosdent huang On June 27, 2016, 6:47 a.

Re: Review Request 48841: Add Agent protobuf message.

2016-06-27 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/#review139593 --- include/mesos/v1/master/master.proto (line 287)

Re: Review Request 49015: Implemented GET_CONTAINERS Call in v1 Agent API.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49015/#review139599 --- Fix it, then Ship it! Ship It! src/slave/http.cpp (line 1158)

Re: Review Request 49269: Added helper function for /containers endpoint.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49269/#review139600 --- Ship it! Ship It! src/slave/http.cpp (line 1151)

Review Request 49273: Helper binary for executors to chroot tasks.

2016-06-27 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49273/ --- Review request for mesos, Joshua Cohen and Jie Yu. Repository: mesos Descript

Re: Review Request 49269: Added helper function for /containers endpoint.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49269/#review139603 --- src/slave/http.cpp (line 1143)

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139605 --- Fix it, then Ship it! Ship It! src/webui/master/static/js/con

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Anand Mazumdar
> On June 27, 2016, 12:36 a.m., Anand Mazumdar wrote: > > src/master/http.cpp, lines 1505-1506 > > > > > > Do we need this explicit check here? I can understand why we > > introduced/need it in `GET_LEADER` but why

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/#review139602 --- Fix it, then Ship it! LGTM minus a few suggested minor cleanups

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 5:26 p.m.) Review request for mesos, Benjamin Mahler, h

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
> On June 27, 2016, 5:17 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 158 > > > > > > `function (task)` should be `function(task)` Thanks. We should add jslint to this project as a

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139606 --- src/webui/master/static/js/controllers.js (line 157)

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-27 Thread haosdent huang
> On June 24, 2016, 9:25 p.m., Anand Mazumdar wrote: > > include/mesos/master/master.proto, line 307 > > > > > > hmmm.. we should consider doing a sweep to kill: > > > > `The response for 'Call::GET_X`. > >

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139612 --- Patch looks great! Reviews applied: [49228] Passed command: expo

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 5:40 p.m.) Review request for mesos, Benjamin Mahler, h

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
> On June 27, 2016, 5:28 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 158 > > > > > > Not sure if `isTaskTerminated` is a better name. Definetely it is. Fixed. - Tomasz ---

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread haosdent huang
> On June 27, 2016, 5:28 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 158 > > > > > > Not sure if `isTaskTerminated` is a better name. > > Tomasz Janiszewski wrote: > Definetel

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139614 --- include/mesos/appc/spec.proto (lines 43 - 46)

Re: Review Request 49208: Modified tests to check is appc spec with app object is properly parsed.

2016-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review139618 --- src/tests/containerizer/provisioner_appc_tests.cpp (line 112)

Re: Review Request 49234: Removed DockerRuntimeIsolatorProcess::recover from docker/runtime.

2016-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49234/#review139620 --- Ship it! Ship It! - Gilbert Song On June 25, 2016, 6:49 p.m.

Re: Review Request 49219: Added runtime isolator interface to run appc containers.

2016-06-27 Thread Gilbert Song
> On June 25, 2016, 4:06 p.m., Guangya Liu wrote: > > src/Makefile.am, line 1028 > > > > > > I think the runtime.cpp also need to put into CMakeLists.txt > > https://github.com/apache/mesos/blob/master/src/CMakeLis

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

2016-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review139621 --- Srini, I guess you may want to add another patch before this one t

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- (Updated June 27, 2016, 6:17 p.m.) Review request for mesos, Abhishek Dasgupta,

Review Request 49277: Replaces `GET_FILE_CONTENTS` with `READ_FILE`.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49277/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo,

Re: Review Request 49277: Replaced `GET_FILE_CONTENTS` with `READ_FILE`.

2016-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49277/ --- (Updated June 27, 2016, 6:18 p.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139622 --- src/webui/master/static/js/controllers.js (line 149)

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread Vinod Kone
> On June 24, 2016, 9:57 p.m., Vinod Kone wrote: > > src/master/weights_handler.cpp, line 216 > > > > > > why this change? looks like we want a sanitized role (#193) to be > > inside validatedWeightInfos. > > zhou

Re: Review Request 49277: Replaced `GET_FILE_CONTENTS` with `READ_FILE`.

2016-06-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49277/#review139624 --- Ship it! Ship It! - Vinod Kone On June 27, 2016, 6:18 p.m.,

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139625 --- Fix it, then Ship it! include/mesos/master/master.proto (line

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Vinod Kone
> On June 27, 2016, 3:49 a.m., Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 29 > > > > > > should be filtered by `disconnected` boolean. > > > > a framework in master has two tags assoc

Review Request 49279: Added documentation around available client libraries.

2016-06-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49279/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5419 https://issues.ap

Re: Review Request 49136: Add Framework protobuf message.

2016-06-27 Thread Vinod Kone
> On June 27, 2016, 4:35 p.m., Zhitao Li wrote: > > include/mesos/v1/master/master.proto, line 296 > > > > > > Should this be required? I guess that's the case for any custom > > executor type, but I'm not sure abou

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 7:05 p.m.) Review request for mesos, Benjamin Mahler, h

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
> On June 27, 2016, 6:27 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 149 > > > > > > task.statuses[0] could be a terminal state if a task went directly from > > TASK_STAGING to TASK_L

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/ --- (Updated June 27, 2016, 7:19 p.m.) Review request for mesos, Benjamin Mahler, D

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
> On June 27, 2016, 3:49 a.m., Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 29 > > > > > > should be filtered by `disconnected` boolean. > > > > a framework in master has two tags assoc

Review Request 49280: Fixed FD inheritance leak when SSL is enabled.

2016-06-27 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49280/ --- Review request for mesos, Avinash sridharan, Benjamin Mahler, Artem Harutyunyan,

Review Request 49281: Added TODOs to make Socket::accept options optional.

2016-06-27 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49281/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs: MES

  1   2   >