Re: Review Request 49864: Fixed ExecutorPIDTest.

2016-07-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49864/#review141604 --- Patch looks great! Reviews applied: [49864] Passed command: expo

Re: Review Request 49865: Renamed `info` to `executorInfo` in `Master::Http::_getExecutors`.

2016-07-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49865/#review141607 --- Patch looks great! Reviews applied: [49865] Passed command: expo

Re: Review Request 49865: Renamed `info` to `executorInfo` in `Master::Http::_getExecutors`.

2016-07-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49865/#review141606 --- Ship it! Ship It! - Joerg Schad On July 10, 2016, 6:47 a.m.,

Re: Review Request 49813: Added stubs for the unified cgroups isolator.

2016-07-10 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/#review141605 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (line

Re: Review Request 49815: Implemented `CgroupsIsolatorProcess::prepareHierarchy`.

2016-07-10 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49815/#review141612 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

2016-07-10 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review141613 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

2016-07-10 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/#review141611 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

2016-07-10 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/#review141615 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49864: Fixed ExecutorPIDTest.

2016-07-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49864/#review141616 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 1291)

Review Request 49843: Added benchmark test for sorter.

2016-07-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49843/ --- Review request for mesos, Benjamin Mahler and Klaus Ma. Bugs: MESOS-5701 ht

Re: Review Request 49843: Added benchmark test for sorter.

2016-07-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49843/#review141629 --- Patch looks great! Reviews applied: [49846, 49843] Passed comman

Re: Review Request 49816: Implemented `CgroupsIsolatorProcess::initialize`.

2016-07-10 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49816/#review141630 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 48593: Refactor Ranges Subtraction.

2016-07-10 Thread Yanyan Hu
> On July 8, 2016, 10:05 p.m., Joseph Wu wrote: > > src/tests/values_tests.cpp, lines 362-364 > > > > > > Here, you have (closed, open) bounds. > > > > In the implementation, you (correctly) use (closed, clo