Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review145839 --- Patch looks great! Reviews applied: [51009, 51052] Passed comman

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

2016-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Aug. 16, 2016, 6:04 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51097: Added a `PortMapper` class.

2016-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review145837 --- Patch looks great! Reviews applied: [51095, 51096, 51097] Passed

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

2016-08-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review145834 --- src/linux/cgroups.hpp (line 218)

Review Request 51130: Exposed unversioned scheduler/executor protos in Mesos JAR.

2016-08-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51130/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6016 https://issues.ap

Review Request 51129: Renamed `JNIMesos` to `V1Mesos` for scheduler shim.

2016-08-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51129/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5788 https://issues.ap

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/#review145833 --- Patch looks great! Reviews applied: [45991, 45995, 45996, 45999,

Review Request 51127: Added the cluster plugin the the Mesos CLI.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51127/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https

Re: Review Request 51122: Fixed memory leak in agent signal handlers.

2016-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51122/#review145832 --- src/slave/posix_signalhandler.hpp (lines 39 - 47)

Re: Review Request 51111: Added the container plugin to the Mesos CLI.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- (Updated Aug. 16, 2016, 1:48 a.m.) Review request for mesos, Joseph Wu and Kevi

Review Request 51113: Added the agent plugin the the Mesos CLI.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51113/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https

Re: Review Request 51109: Added a Table abstraction and some functions to the CLI.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51109/ --- (Updated Aug. 16, 2016, 1:46 a.m.) Review request for mesos, Joseph Wu and Kevi

Re: Review Request 51110: Introduced the PluginTestBase class into the CLI.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51110/ --- (Updated Aug. 16, 2016, 1:45 a.m.) Review request for mesos, Joseph Wu and Kevi

Re: Review Request 51108: Added additional parameters to the CLI config.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51108/ --- (Updated Aug. 16, 2016, 1:44 a.m.) Review request for mesos, Joseph Wu and Kevi

Review Request 51122: Fixed memory leak in agent signal handlers.

2016-08-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51122/ --- Review request for mesos, Benjamin Mahler, Greg Mann, Artem Harutyunyan, and Vin

Re: Review Request 51099: Fixed scalar resources output to print full significant digits.

2016-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51099/#review145827 --- Patch looks great! Reviews applied: [51099] Passed command: expo

Re: Review Request 51091: Disallowed unknown cgroups isolator.

2016-08-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51091/#review145826 --- Ship it! Ship It! - Qian Zhang On Aug. 15, 2016, 9:07 p.m.,

Re: Review Request 51091: Disallowed unknown cgroups isolator.

2016-08-15 Thread Qian Zhang
> On Aug. 15, 2016, 10:41 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 87-91 > > > > > > Do we really need this? I think we have already guaranteed this in > > `Mesos

Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/ --- Review request for mesos, Xiaojian Huang, Gilbert Song, and Jie Yu. Bugs: MESOS

Re: Review Request 51120: Removed 'directory' from Container struct in MesosContainerizer.

2016-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51120/#review145819 --- Ship it! Ship It! - Gilbert Song On Aug. 15, 2016, 5:14 p.m.

Re: Review Request 51116: Added nested Container struct in MesosContainerizer.

2016-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51116/#review145818 --- Ship it! Ship It! - Gilbert Song On Aug. 15, 2016, 3:57 p.m.

Re: Review Request 51115: Replaced a static isolator cleanup function with lambda.

2016-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51115/#review145817 --- Ship it! Ship It! - Gilbert Song On Aug. 15, 2016, 3:56 p.m.

Re: Review Request 51114: Replaced a static function for isolator prepare with lambda.

2016-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51114/#review145816 --- Ship it! Ship It! - Gilbert Song On Aug. 15, 2016, 3:56 p.m.

Review Request 51120: Removed 'directory' from Container struct in MesosContainerizer.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51120/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, Kevin Klues, and Vinod

Re: Review Request 50992: Introduce MESOS_{MAJOR|MINOR|PATCH}_VERSION_INT macros.

2016-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50992/#review145812 --- Patch looks great! Reviews applied: [50992] Passed command: expo

Review Request 51116: Added nested Container struct in MesosContainerizer.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51116/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and K

Review Request 51115: Replaced a static isolator cleanup function with lambda.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51115/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and K

Review Request 51114: Replaced a static function for isolator prepare with lambda.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51114/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and K

Re: Review Request 51059: Made `ExecutorInfo.command` optional.

2016-08-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51059/ --- (Updated Aug. 15, 2016, 10:23 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51109: Added a Table abstraction and some functions to the CLI util file. These will be used by future plugins.

2016-08-15 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51109/#review145810 --- First line of the commit message should be <= 60 chars. - Neil Co

Re: Review Request 51059: Made `ExecutorInfo.command` optional.

2016-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51059/#review145809 --- Ship it! src/master/validation.cpp (line 590)

Re: Review Request 51062: Added LAUNCH_GROUP event to executor API.

2016-08-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51062/ --- (Updated Aug. 15, 2016, 10:04 p.m.) Review request for mesos, Anand Mazumdar, B

Re: Review Request 51061: Added LAUNCH_GROUP offer operation.

2016-08-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51061/ --- (Updated Aug. 15, 2016, 10:03 p.m.) Review request for mesos, Anand Mazumdar, B

Review Request 51111: Added the container plugin to the Mesos CLI.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https

Re: Review Request 51110: Introduced the PluginTestBase class into the CLI.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51110/ --- (Updated Aug. 15, 2016, 9:57 p.m.) Review request for mesos, Joseph Wu and Kevi

Review Request 51110: Introduced the PluginTestBase class into the CLI.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51110/ --- Review request for mesos. Repository: mesos Description --- This class w

Review Request 51109: Added a Table abstraction and some functions to the CLI util file. These will be used by future plugins.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51109/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https

Re: Review Request 51060: Made `Offer::Operation::Type` optional with default `UNKNOWN`.

2016-08-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51060/ --- (Updated Aug. 15, 2016, 9:56 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 51059: Made `ExecutorInfo.command` optional.

2016-08-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51059/ --- (Updated Aug. 15, 2016, 9:55 p.m.) Review request for mesos, Benjamin Mahler, J

Review Request 51108: Added additional parameters to the CLI config.

2016-08-15 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51108/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: mesos-5676 https

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

2016-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51008/#review145808 --- Patch looks great! Reviews applied: [50907, 50910, 50912, 51008]

Re: Review Request 51106: Added non-nesting CHECKs to containerizers.

2016-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51106/#review145807 --- Ship it! Ship It! - Gilbert Song On Aug. 15, 2016, 1:38 p.m.

Re: Review Request 51105: Updated hash and equality functions for ContainerID.

2016-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51105/#review145806 --- Ship it! Ship It! - Gilbert Song On Aug. 15, 2016, 1:37 p.m.

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-15 Thread Zhitao Li
> On Aug. 13, 2016, 1:02 a.m., Zhitao Li wrote: > > src/docker/docker.hpp, line 152 > > > > > > Note that this does not apply cleanly anymore, because gmock only > > generate mocks for functions with up to 10 argume

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Aug. 15, 2016, 9:21 p.m.) Review request for mesos, Gilbert Song, haos

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-08-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review145747 --- src/slave/containerizer/docker.hpp (line 255)

Re: Review Request 51062: Added LAUNCH_GROUP event to executor API.

2016-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51062/#review145790 --- Ship it! src/examples/long_lived_executor.cpp (line 115)

Review Request 51097: Added a `PortMapper` class.

2016-08-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-6023 https://i

Review Request 51106: Added non-nesting CHECKs to containerizers.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51106/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, Kevin Klues, and Vinod

Review Request 51105: Updated hash and equality functions for ContainerID.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51105/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, Kevin Klues, and Vinod

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Aug. 15, 2016, 8:18 p.m.) Review request for mesos, Joseph Wu and Vino

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

2016-08-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/ --- (Updated Aug. 15, 2016, 8:18 p.m.) Review request for mesos, Anand Mazumdar, Jo

Re: Review Request 50271: Created an isolator for Linux capabilities.

2016-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review145794 --- Patch looks great! Reviews applied: [50266, 50889, 51042, 51043,

Re: Review Request 51061: Added LAUNCH_GROUP offer operation.

2016-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51061/#review145781 --- Ship it! include/mesos/mesos.proto (lines 1237 - 1245)

Re: Review Request 51102: Supported nested ContainerID.

2016-08-15 Thread Jie Yu
> On Aug. 15, 2016, 6:54 p.m., Gilbert Song wrote: > > include/mesos/mesos.proto, line 92 > > > > > > Please add it to v1/mesos.proto as well. Yup, doing that right now. - Jie

Re: Review Request 51103: Added default stub for launch in Mesos containerizer.

2016-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51103/#review145787 --- Ship it! Ship It! - Gilbert Song On Aug. 15, 2016, 11:54 a.m

Re: Review Request 51100: Added a containerizer launch interface to launch sub-containers.

2016-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51100/#review145786 --- Ship it! Ship It! - Gilbert Song On Aug. 15, 2016, 11:53 a.m

Re: Review Request 51102: Supported nested ContainerID.

2016-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51102/#review145785 --- Fix it, then Ship it! include/mesos/mesos.proto (line 92)

Re: Review Request 51102: Supported nested ContainerID.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51102/ --- (Updated Aug. 15, 2016, 6:54 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51100: Added a containerizer launch interface to launch sub-containers.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51100/ --- (Updated Aug. 15, 2016, 6:53 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51103: Added default stub for launch in Mesos containerizer.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51103/ --- (Updated Aug. 15, 2016, 6:54 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51103: Added default stub for launch in Mesos containerizer.

2016-08-15 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51103/#review145784 --- Ship it! Ship It! - Benjamin Hindman On Aug. 15, 2016, 6:43

Re: Review Request 51100: Added a containerizer launch interface to launch sub-containers.

2016-08-15 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51100/#review145783 --- Fix it, then Ship it! src/slave/containerizer/containerizer.hp

Re: Review Request 51096: Added the `mesos-port-mapper` binary.

2016-08-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/ --- (Updated Aug. 15, 2016, 6:48 p.m.) Review request for mesos, Jie Yu and Qian Zh

Re: Review Request 51102: Supported nested ContainerID.

2016-08-15 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51102/#review145782 --- Ship it! Ship It! - Benjamin Hindman On Aug. 15, 2016, 6:42

Review Request 51096: Added the `mesos-port-mapper` binary.

2016-08-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/ --- Review request for mesos, Jie Yu and Qian Zhang. Repository: mesos Descriptio

Re: Review Request 51099: Fixed scalar resources output to print full significant digits.

2016-08-15 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51099/#review145780 --- src/common/values.cpp (line 72)

Review Request 51103: Added default stub for launch in Mesos containerizer.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51103/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, Kevin Klues, and Vinod

Review Request 51102: Supported nested ContainerID.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51102/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues. Repo

Re: Review Request 51100: Added a containerizer launch interface to launch sub-containers.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51100/ --- (Updated Aug. 15, 2016, 6:43 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51061: Added LAUNCH_GROUP offer operation.

2016-08-15 Thread Vinod Kone
> On Aug. 13, 2016, 10:29 p.m., James DeFelice wrote: > > include/mesos/mesos.proto, line 1379 > > > > > > There was some talk about allowing tasks to specify volumes if they > > wanted to use **unshared** volumes.

Re: Review Request 51061: Added LAUNCH_GROUP offer operation.

2016-08-15 Thread Vinod Kone
> On Aug. 13, 2016, 10:18 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 1379 > > > > > > As we want to allow containers share a network namespace and volumes, > > so I think that we shoud also highli

Re: Review Request 51060: Made `Offer::Operation::Type` optional with default `UNKNOWN`.

2016-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51060/#review145779 --- Ship it! src/master/master.cpp (line 3432)

Re: Review Request 51059: Made `ExecutorInfo.command` optional.

2016-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51059/#review145776 --- Ship it! include/mesos/mesos.proto (lines 502 - 510)

Re: Review Request 51087: Updated elfio to version 3.2.

2016-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51087/#review145777 --- Ship it! Ship It! - Benjamin Mahler On Aug. 15, 2016, 5:02 a

Review Request 51099: Fixed scalar resources output to print full significant digits.

2016-08-15 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51099/ --- Review request for mesos, Joris Van Remoortere and Neil Conway. Bugs: MESOS-587

Review Request 51100: Added a containerizer launch interface to launch sub-containers.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51100/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, Kevin Klues, and Vinod

Re: Review Request 51076: Removed slavePid from the containerizer launch API.

2016-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51076/ --- (Updated Aug. 15, 2016, 10:48 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50992: Introduce MESOS_{MAJOR|MINOR|PATCH}_VERSION_INT macros.

2016-08-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50992/ --- (Updated Aug. 15, 2016, 5:31 p.m.) Review request for mesos, Xiaojian Huang, ha

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

2016-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/#review145774 --- Patch looks great! Reviews applied: [49555, 50657, 49556, 51069,

Review Request 51095: Adding protobuf to represent errors returned by CNI plugins.

2016-08-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51095/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-6023 https://i

Re: Review Request 50992: Make MESOS_{MAJOR|MINOR|PATCH}_VERSION macros integer in header.

2016-08-15 Thread Jiang Yan Xu
> On Aug. 11, 2016, 10:12 a.m., James Peach wrote: > > As mentioned on chat, I think this will break some external module builds. > > I'm fine with that, just pointing it out for posterity. > > > > I noticed that the Java bindings use these in the > > MesosNativeLibrary.Version class. The Java

Re: Review Request 51059: Made `ExecutorInfo.command` optional.

2016-08-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51059/#review145771 --- src/master/validation.cpp (line 586)

Re: Review Request 51061: Added LAUNCH_GROUP offer operation.

2016-08-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51061/#review145770 --- include/mesos/mesos.proto (line 1240)

Re: Review Request 51059: Made `ExecutorInfo.command` optional.

2016-08-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51059/#review145767 --- include/mesos/mesos.proto (line 505)

Re: Review Request 51060: Made `Offer::Operation::Type` optional with default `UNKNOWN`.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51060/#review145768 --- Ship it! Ship It! - Jie Yu On Aug. 12, 2016, 11:10 p.m., Vin

Re: Review Request 51061: Added LAUNCH_GROUP offer operation.

2016-08-15 Thread Jie Yu
> On Aug. 14, 2016, 2:38 p.m., Qian Zhang wrote: > > include/mesos/mesos.proto, lines 1381-1383 > > > > > > Do we allow a custom executor to launch multiple task groups and each > > task group is in its own network

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

2016-08-15 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51008/ --- (Updated Aug. 15, 2016, 4:30 p.m.) Review request for mesos, Haris Choudhary an

Re: Review Request 51076: Removed slavePid from the containerizer launch API.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51076/#review145763 --- Fix it, then Ship it! src/slave/containerizer/composing.cpp (l

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-15 Thread haosdent huang
> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.hpp, line 330 > > > > > > Why do you need to discard original future here? > > haosdent huang wrote: > I saw we disc

Re: Review Request 51075: Consolidated two executorEnvironment() calls in docker containerizer.

2016-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51075/#review145761 --- Ship it! Ship It! - Jie Yu On Aug. 13, 2016, 5:44 p.m., Gilb

Re: Review Request 50912: Added the infrastructure for a new python-based CLI.

2016-08-15 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50912/ --- (Updated Aug. 15, 2016, 4:06 p.m.) Review request for mesos, Haris Choudhary an

Re: Review Request 50270: Introduced linux capabilities support for mesos containerizer.

2016-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50270/ --- (Updated Aug. 15, 2016, 5:57 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 50271: Created an isolator for Linux capabilities.

2016-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Aug. 15, 2016, 5:57 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

2016-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 15, 2016, 3:44 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

2016-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/ --- (Updated Aug. 15, 2016, 3:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

2016-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51085/ --- (Updated Aug. 15, 2016, 3:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 49360: Supported TCP in health check.

2016-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 15, 2016, 3:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 15, 2016, 3:42 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

2016-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 15, 2016, 3:41 p.m.) Review request for mesos, Alexander Rukletso

  1   2   >