Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

> On Oct. 14, 2016, 11:23 p.m., Joris Van Remoortere wrote: > > I have a feeling that if you kept around a stringstream with the local set > > your benchmarks would look rather different. > > I also suggest using callgrind to get the instruction count / # of library > > calls made. > > Alexand

Re: Review Request 53275: Added a test for duplicate frameworks in "unregistered_frameworks".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53275/ --- (Updated Oct. 28, 2016, 11:19 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 53275: Added a test for duplicate frameworks in "unregistered_frameworks".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53275/#review154190 --- Fix it, then Ship it! src/tests/master_tests.cpp (line 2941) <

Re: Review Request 53249: Added MESOS-5788 to 1.1.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53249/#review154192 --- Ship it! Ship It! - Vinod Kone On Oct. 28, 2016, 2 a.m., Ana

Re: Review Request 53005: Updated release guide.

> On Oct. 20, 2016, 1:34 p.m., Till Toenshoff wrote: > > docs/release-guide.md, lines 213-214 > > > > > > "Also, make sure to add the names of the release managers in > > "Description" section?" > > > >

Review Request 53275: Added a test for duplicate frameworks in "unregistered_frameworks".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53275/ --- Review request for mesos, Anand Mazumdar and Jiang Yan Xu. Bugs: MESOS-6501

Review Request 53264: Added test for CNI port-mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-6022 https://i

Re: Review Request 53266: Made DefaultExecutorTests pass when running on hosts without Docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/#review154183 --- The diff is hard to review because in addition to making tests int

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

> On Oct. 28, 2016, 2:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 213 > > > > > > Hum, IIUC, looks like this is not entirely correct. According to this: > > > > h

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

> On Oct. 28, 2016, 2:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 133 > > > > > > I am not sure if we need to pass in 'image' to backend. If we added OCI > > support,

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

> On Oct. 27, 2016, 5:03 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, lines 71-72 > > > > > > I think James made a valid point there that errno might not be > > preserved across delete. So

Re: Review Request 53159: Fixed duplicate framework ids in "unregistered_frameworks".

> On Oct. 28, 2016, 8:47 p.m., Jiang Yan Xu wrote: > > Hey > > > > We now have `mesos::internal::master::Master::Frameworks::recovered` to > > track precisely this right? yea, we unfortunately cannot rely on it because 0.28.0 agents don't send framework infos to master. i'll send another revi

Re: Review Request 53124: Add documentation on Windows support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53124/#review154174 --- Also consider watching this: https://www.youtube.com/watch?v=bbyK1

Re: Review Request 53159: Fixed duplicate framework ids in "unregistered_frameworks".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53159/#review154177 --- Hey We now have `mesos::internal::master::Master::Frameworks::rec

Re: Review Request 53159: Fixed duplicate framework ids in "unregistered_frameworks".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53159/#review154175 --- Patch looks great! Reviews applied: [53159] Passed command: expo

Re: Review Request 53271: Combined stdout/stdout in ASF CI builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53271/#review154173 --- Ship it! Ship It! - Vinod Kone On Oct. 28, 2016, 8:27 p.m.,

Review Request 53271: Combined stdout/stdout in ASF CI builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53271/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 53270: Fixed MesosNativeLibrary to use '_NUM' MESOS_VERSION macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53270/#review154171 --- Ship it! - Anand Mazumdar On Oct. 28, 2016, 7:53 p.m., Joris

Review Request 53270: Fixed MesosNativeLibrary to use '_NUM' MESOS_VERSION macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53270/ --- Review request for mesos, Anand Mazumdar and Jiang Yan Xu. Bugs: MESOS-6502

Re: Review Request 53159: Fixed duplicate framework ids in "unregistered_frameworks".

> On Oct. 28, 2016, 6:33 p.m., Anand Mazumdar wrote: > > LGTM! > > > > Do you want to file another issue to track adding the test or keep the > > existing issue open? will create another ticket for the test. - Vinod --- This is an aut

Re: Review Request 53159: Fixed duplicate framework ids in "unregistered_frameworks".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53159/ --- (Updated Oct. 28, 2016, 7:22 p.m.) Review request for mesos, Anand Mazumdar, Gi

Re: Review Request 53267: Added log and counter for tracking subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53267/#review154164 --- Patch looks great! Reviews applied: [53267] Passed command: expo

Re: Review Request 53159: Fixed duplicate framework ids in "unregistered_frameworks".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53159/#review154152 --- Ship it! LGTM! Do you want to file another issue to track addi

Re: Review Request 53266: Made DefaultExecutorTests pass when running on hosts without Docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/#review154150 --- I don't follow what is happening in this review. Can you please ex

Re: Review Request 53266: Made DefaultExecutorTests pass when running on hosts without Docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/ --- (Updated Oct. 28, 2016, 6:27 p.m.) Review request for mesos, Till Toenshoff and

Re: Review Request 53266: Made DefaultExecutorTests pass when running on hosts without Docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/ --- (Updated Oct. 28, 2016, 6:27 p.m.) Review request for mesos, Till Toenshoff and

Re: Review Request 53159: Fixed duplicate framework ids in "unregistered_frameworks".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53159/ --- (Updated Oct. 28, 2016, 6:22 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 53266: Made DefaultExecutorTests pass when running on hosts without Docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/#review154139 --- Patch looks great! Reviews applied: [53266] Passed command: expo

Review Request 53267: Added log and counter for tracking subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53267/ --- Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar. Bug

Review Request 53266: Made DefaultExecutorTests succeed when running on hosts without Docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/ --- Review request for mesos, Till Toenshoff and Jiang Yan Xu. Bugs: MESOS-6455

Re: Review Request 53266: Made DefaultExecutorTests pass when running on hosts without Docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/ --- (Updated Oct. 28, 2016, 3:28 p.m.) Review request for mesos, Till Toenshoff and

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

> On Oct. 27, 2016, 5:03 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, lines 71-72 > > > > > > I think James made a valid point there that errno might not be > > preserved across delete. So

Re: Review Request 53247: Populated `MasterInfo` in the v0 Java adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53247/#review154124 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 27, 2016, 1

Re: Review Request 53246: Populated `MasterInfo` evolving from v0 framework registered message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53246/#review154123 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 27, 2016, 1

Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53084/#review154119 --- Ship it! Ship It! - Till Toenshoff On Oct. 28, 2016, 11:41 a

Re: Review Request 52840: Silenced a GMock warning in ROOT_DOCKER_DockerInspectDiscard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52840/#review154115 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 20, 2016, 9:

Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/ --- (Updated Oct. 28, 2016, 11:43 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53084/ --- (Updated Oct. 28, 2016, 11:41 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

> On Oct. 28, 2016, 10:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 213 > > > > > > Hum, IIUC, looks like this is not entirely correct. According to this: > > > >

Re: Review Request 53083: Made `cgroups::create` create cgroup recursively as default behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53083/#review154110 --- Patch looks great! Reviews applied: [53252, 53253, 51031, 51185,

Re: Review Request 53230: Added test cases for HTTPS health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53230/#review154106 --- Fix it, then Ship it! src/tests/health_check_tests.cpp (lines

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

> On Oct. 28, 2016, 1:03 a.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, lines 71-72 > > > > > > I think James made a valid point there that errno might not be > > preserved across delete. So

Re: Review Request 53058: Added tests for whole protobuf message based authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53058/#review154101 --- Patch looks great! Reviews applied: [52600, 53057, 53058] Passed