Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54365/#review158311 --- Patch looks great! Reviews applied: [54359, 54360, 54361, 54365]

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 7, 2016, 5:50 a.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 54472: Waited for the domain socket file in IOSwitchboard::connect.

> On Dec. 7, 2016, 5:29 a.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 636-637 > > > > > > @bmahler alwasy wanted me to put the " " on the next line instead of > > ending a line

Re: Review Request 54472: Waited for the domain socket file in IOSwitchboard::connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54472/#review158304 --- Fix it, then Ship it! src/slave/containerizer/mesos/io/switchb

Re: Review Request 54465: Added synchronization between agent and IOSwitchboard server for listen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54465/#review158303 --- I posted a simple work around in https://reviews.apache.org/r/5447

Review Request 54472: Waited for the domain socket file in IOSwitchboard::connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54472/ --- Review request for mesos, Kevin Klues and Vinod Kone. Bugs: MESOS-6737 http

Re: Review Request 54381: Adds authorization support when attaching containers input/output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54381/#review158302 --- Patch looks great! Reviews applied: [54381] Passed command: expo

Re: Review Request 54465: Added synchronization between agent and IOSwitchboard server for listen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54465/#review158301 --- LGTM overall src/slave/containerizer/mesos/io/switchboard.hpp (l

Review Request 54470: Windows: Fixed default isolators in Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54470/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. B

Re: Review Request 54360: Changed master to add/remove roles for a multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54360/#review158298 --- Fix it, then Ship it! src/master/master.cpp (line 7033)

Re: Review Request 54380: Don't send PIDs of disconnected frameworks to re-registering agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54380/ --- (Updated Dec. 7, 2016, 4:25 a.m.) Review request for mesos and Vinod Kone. Re

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54408/ --- (Updated Dec. 7, 2016, 4:20 a.m.) Review request for mesos and Vinod Kone. Ch

Review Request 54467: Fixed incorrect warning messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54467/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Review Request 54468: Added some additional CHECKs to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54468/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

> On Dec. 3, 2016, 2:12 a.m., Vinod Kone wrote: > > src/master/master.cpp, lines 7132-7137 > > > > > > hmm. it's a bit weird that activating a framework also updates it. this > > should be done by the callers befor

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 7, 2016, 4:14 a.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 54177: Simplified some test code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54177/ --- (Updated Dec. 7, 2016, 4:07 a.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54365/ --- (Updated Dec. 7, 2016, 4:02 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 54363: Added a test to ensure multi-role framework being removed properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54363/ --- (Updated Dec. 7, 2016, 4:01 a.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 54361: Added tests for add/remove multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review158297 --- src/tests/master_tests.cpp (lines 4916 - 4917)

Re: Review Request 54362: Changed master to remove roles for a multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/ --- (Updated Dec. 7, 2016, 4 a.m.) Review request for mesos, Benjamin Mahler, Guang

Re: Review Request 54361: Added tests for add/remove multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/ --- (Updated Dec. 7, 2016, 3:59 a.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 54360: Changed master to add/remove roles for a multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54360/ --- (Updated Dec. 7, 2016, 3:58 a.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 54465: Added synchronization between agent and IOSwitchboard server for listen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54465/ --- (Updated Dec. 7, 2016, 3:21 a.m.) Review request for mesos, Jie Yu and Vinod Ko

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/#review158292 --- Patch looks great! Reviews applied: [54449] Passed command: expo

Re: Review Request 54465: Added synchronization between agent and IOSwitchboard server for listen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54465/ --- (Updated Dec. 7, 2016, 2:47 a.m.) Review request for mesos, Jie Yu and Vinod Ko

Review Request 54465: Added synchronization between agent and IOSwitchboard server for listen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54465/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Descriptio

Review Request 54462: Windows: Added APR include path to libprocess configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54462/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. B

Re: Review Request 53550: Rename symbols in log.proto to avoid naming collision in win32 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53550/ --- (Updated Dec. 7, 2016, 2:16 a.m.) Review request for mesos, Daniel Pravat and J

Re: Review Request 54013: Added user doc for nested container and task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/#review158288 --- This should be linked from elsewhere in the docs. e.g., `home.md`.

Re: Review Request 54013: Added user doc for nested container and task group.

> On Dec. 6, 2016, 9:23 a.m., Jie Yu wrote: > > docs/nested-container-and-task-group.md, line 125 > > > > > > Can you follow up to update mesos-containerizer.md to include this > > isolator and provide a link here?

Re: Review Request 54434: Used UNSET_CLOEXEC instead of DUP2 hook for I/O switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54434/#review158281 --- Patch looks great! Reviews applied: [54432, 54433, 54434] Passed

Re: Review Request 54434: Used UNSET_CLOEXEC instead of DUP2 hook for I/O switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54434/#review158277 --- Ship it! Ship It! - Kevin Klues On Dec. 6, 2016, 6:44 p.m.,

Re: Review Request 54433: Added a UNSET_CLOEXEC child hook to subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54433/#review158274 --- Ship it! Ship It! - Kevin Klues On Dec. 6, 2016, 6:44 p.m.,

Re: Review Request 54432: Added os::unsetCloexec to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54432/#review158273 --- Ship it! Ship It! - Kevin Klues On Dec. 6, 2016, 6:43 p.m.,

Re: Review Request 54381: Adds authorization support when attaching containers input/output.

> On Dec. 5, 2016, 4:55 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, lines 3728-3793 > > > > > > why did you change these tests? the idea with the tests was to verify > > that `Containerizer::attach()` was

Re: Review Request 54381: Adds authorization support when attaching containers input/output.

> On Dec. 6, 2016, 12:50 a.m., Adam B wrote: > > src/slave/http.cpp, lines 2465-2468 > > > > > > Can you please comment on the need for std::move here? > > Why is decoder a `&&` in the first place? @vinodkone ma

Re: Review Request 54446: Windows: Added `authentication_tests.cpp` build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54446/#review158260 --- Ship it! Ship It! - Joseph Wu On Dec. 6, 2016, 12:51 p.m., A

Re: Review Request 54395: Enabled build of Agent test harness on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54395/#review158239 --- Ship it! Looks good on the OSX and Ubuntu. - Joseph Wu On De

Re: Review Request 54381: Adds authorization support when attaching containers input/output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54381/#review158255 --- A few nits, but we really just need Vinod's approval of the test u

Re: Review Request 54367: Added support to destroy running DEBUG containers on agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54367/ --- (Updated Dec. 7, 2016, 12:19 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 54360: Changed master to add roles for a multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54360/#review158254 --- src/master/master.cpp (lines 7033 - 7056)

Re: Review Request 54455: Added test for IOSwitchboard `recovery()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54455/#review158251 --- Ship it! Ship It! - Jie Yu On Dec. 6, 2016, 11:03 p.m., Kevi

Re: Review Request 54360: Changed master to add roles for a multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54360/#review158250 --- Can you combine this change with https://reviews.apache.org/r/5436

Re: Review Request 54391: Added ability for client to signal EOF on ATTACH_CONTAINER_INPUT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54391/#review158248 --- Ship it! LGTM. - Jie Yu On Dec. 5, 2016, 10:18 p.m., Kevin K

Re: Review Request 54410: Made the style of `.navbar-text` consistent with others.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54410/#review158247 --- Is this just changing the color? What did the added margins do? -

Re: Review Request 54411: Fixed the colspan number of task tables in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54411/#review158245 --- Ship it! Ship It! - Benjamin Mahler On Dec. 6, 2016, 9:42 a.

Re: Review Request 54367: Added support to destroy running DEBUG containers on agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54367/#review158243 --- Fix it, then Ship it! src/slave/containerizer/mesos/containeri

Re: Review Request 54368: Added helpers to checkpoint a 'destroy-on-recovery' file for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54368/#review158246 --- Ship it! Ship It! - Jie Yu On Dec. 6, 2016, 11:04 p.m., Kevi

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/#review158228 --- Fix it, then Ship it! src/slave/flags.cpp (lines 214 - 222)

Re: Review Request 54368: Added helpers to checkpoint a 'destroy-on-recovery' file for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54368/ --- (Updated Dec. 6, 2016, 11:04 p.m.) Review request for mesos and Jie Yu. Chang

Review Request 54455: Added test for IOSwitchboard `recovery()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54455/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6688 https://issues.apache

Re: Review Request 54415: Stout: Fixed two bugs in `mkdtemp` that block agent tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54415/#review158219 --- Ship it! 3rdparty/stout/include/Makefile.am (line 159)

Re: Review Request 54441: Added function to unblock IOSwitchboard when waiting for connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54441/ --- (Updated Dec. 6, 2016, 11:01 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 54442: Added SIGTERM handler to gracefully shutdown IOSwitchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54442/ --- (Updated Dec. 6, 2016, 11:01 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 54426: Avoided building glog tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54426/#review158241 --- Patch looks great! Reviews applied: [54426] Passed command: expo

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54081/#review158240 --- Thanks Ilya! Have you looked at other pidfile related libraries?

Review Request 54453: Transitioned to `in_memory` log as default in tests involving Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54453/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Joris Van Remoort

Re: Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54356/#review158227 --- Ship it! Ship It! - Jie Yu On Dec. 6, 2016, 8:44 p.m., Kevin

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 5, 2016, 6:33 p.m., Joseph Wu wrote: > > src/slave/constants.hpp, lines 141-144 > > > > > > There isn't any need to get rid of this constant, but we could update > > the comment. > > > > i.e. This

Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-6732 https:/

Re: Review Request 54442: Added SIGTERM handler to gracefully shutdown IOSwitchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54442/#review158213 --- Fix it, then Ship it! src/slave/containerizer/mesos/io/switchb

Re: Review Request 54395: Enabled build of Agent test harness on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54395/ --- (Updated Dec. 6, 2016, 9:11 p.m.) Review request for mesos, Andrew Schwartzmeye

Re: Review Request 54328: Fixed HttpServeTests to connect to a non-ANY address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54328/ --- (Updated Dec. 6, 2016, 1:08 p.m.) Review request for mesos, Benjamin Mahler, Al

Re: Review Request 54441: Added function to unblock IOSwitchboard when waiting for connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54441/#review158215 --- Fix it, then Ship it! src/slave/containerizer/mesos/io/switchb

Review Request 54446: Windows: Added `authentication_tests.cpp` build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54446/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. B

Re: Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54356/ --- (Updated Dec. 6, 2016, 8:44 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 54422: Removed test assumptions about arrival order of status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54422/#review158211 --- Patch looks great! Reviews applied: [54422] Passed command: expo

Re: Review Request 54442: Added SIGTERM handler to gracefully shutdown IOSwitchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54442/ --- (Updated Dec. 6, 2016, 8:03 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54442: Added SIGTERM handler to gracefully shutdown IOSwitchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54442/ --- (Updated Dec. 6, 2016, 8:01 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54442: Added SIGTERM handler to gracefully shutdown IOSwitchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54442/ --- (Updated Dec. 6, 2016, 7:58 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54441: Added function to unblock IOSwitchboard when waiting for connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54441/ --- (Updated Dec. 6, 2016, 7:58 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54442: Added SIGTERM handler to gracefully shutdown IOSwitchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54442/ --- (Updated Dec. 6, 2016, 7:55 p.m.) Review request for mesos and Jie Yu. Reposi

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 6, 2016, 7:46 p.m.) Review request for mesos and Jie Yu. Change

Review Request 54442: Added SIGTERM handler to gracefully shutdown IOSwitchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54442/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- W

Review Request 54441: Added function to unblock IOSwitchboard when waiting for connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54441/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

> On Dec. 6, 2016, 5:31 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 161 > > > > > > or agent crashes right before we create the directory and fork the > > server. Would we actuall

Re: Review Request 53803: Added a new libprocess HTTP test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53803/ --- (Updated Dec. 6, 2016, 7:28 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 52349: Add protobuf messages for OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52349/#review158194 --- include/mesos/oci/spec.proto (line 24)

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 6, 2016, 2:33 a.m., Joseph Wu wrote: > > src/slave/flags.cpp, lines 214-216 > > > > > > Seems like the problem on Windows is `os::user()` rather than the value > > of the `--runtime_dir` flag. As long as

Re: Review Request 54335: Add os::var() to stout.

> On Dec. 5, 2016, 6:31 p.m., Jie Yu wrote: > > Flying by. I am checking > > https://www.gnu.org/prep/standards/html_node/Directory-Variables.html > > > > Looks like, in retrospect, we should call the current `runtime_dir` > > `runstate_dir` instead. So we probably should use `os::runstatedir`

Re: Review Request 54328: Fixed HttpServeTests to connect to a non-ANY address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54328/#review158198 --- Fix it, then Ship it! 3rdparty/libprocess/src/tests/http_tests

Review Request 54434: Used UNSET_CLOEXEC instead of DUP2 hook for I/O switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54434/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Repository: mesos

Review Request 54433: Added a UNSET_CLOEXEC child hook to subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54433/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 54432: Added os::unsetCloexec to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54432/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 54414: Cleaned up rlimits documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54414/#review158187 --- Ship it! Ship It! - Jie Yu On Dec. 6, 2016, 12:06 p.m., Benj

Re: Review Request 54013: Added user doc for nested container and task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/#review158186 --- Fix it, then Ship it! docs/nested-container-and-task-group.md

Re: Review Request 54335: Add os::var() to stout.

> On Dec. 5, 2016, 6:31 p.m., Jie Yu wrote: > > Flying by. I am checking > > https://www.gnu.org/prep/standards/html_node/Directory-Variables.html > > > > Looks like, in retrospect, we should call the current `runtime_dir` > > `runstate_dir` instead. So we probably should use `os::runstatedir`

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54365/#review158174 --- Ship it! Ship It! - Guangya Liu On 十二月 5, 2016, 8:48 a.m., J

Re: Review Request 54362: Changed master to remove roles for a multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/#review158173 --- One minor comment is we *must* to commit this one together with h

Re: Review Request 52382: Added stubs for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52382/#review158168 --- src/slave/containerizer/mesos/provisioner/oci/store.cpp (line 55)

Re: Review Request 54013: Added user doc for nested container and task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/ --- (Updated Dec. 6, 2016, 8:28 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 54013: Added user doc for nested container and task group.

> On Dec. 4, 2016, 11:44 a.m., Vinod Kone wrote: > > docs/nested-container-and-task-group.md, line 209 > > > > > > mention that only 2 levels of nesting is supported as of 1.1? We already support arbitrary nested le

Re: Review Request 52379: Added agent flag '--oci_store_dir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52379/#review158169 --- docs/configuration.md (line 1606)

Re: Review Request 54013: Added user doc for nested container and task group.

> On Dec. 4, 2016, 10:11 a.m., Anand Mazumdar wrote: > > Gilbert, can you add [~neilc] as a reviewer too? Thanks, Anand! - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/#revie

Re: Review Request 54415: Stout: Fixed two bugs in `mkdtemp` that block agent tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54415/#review158163 --- Patch looks great! Reviews applied: [54324, 53550, 53551, 53552,

Review Request 54426: Avoided building glog tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54426/ --- Review request for mesos, Alexander Rukletsov, Kapil Arya, and Till Toenshoff.

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review158161 --- src/tests/master_tests.cpp (line 4995)

Re: Review Request 54362: Changed master to remove roles for a multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/#review158160 --- Ship it! Ship It! - Guangya Liu On 十二月 6, 2016, 1:48 p.m., J

Re: Review Request 54360: Changed master to add roles for a multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54360/#review158157 --- Ship it! Ship It! - Guangya Liu On 十二月 5, 2016, 4:57 a.m., J

  1   2   >