Re: Review Request 55611: Paused the status update manager in `Slave::initialize()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55611/#review162038 --- Fix it, then Ship it! src/slave/slave.cpp (lines 557 - 560)

Re: Review Request 55612: Fixed SlaveRecoveryTest.RecoverTerminatedExecutor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55612/#review162031 --- Fix it, then Ship it! It seems like a bit of a shame that the s

Re: Review Request 55637: CMake: Added `test` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55637/#review162032 --- Patch looks great! Reviews applied: [55022, 55023, 55024, 55030,

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review162021 --- src/master/master.hpp (lines 2522 - 2528)

Re: Review Request 55654: Renamed `CONFIGURE_FLAGS` to `CMAKE_ARGS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55654/ --- (Updated Jan. 17, 2017, 6:35 p.m.) Review request for mesos and Benjamin Bannie

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 17, 2017, 6:34 p.m.) Review request for mesos and Benjamin Bannie

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 17, 2017, 6:34 p.m.) Review request for mesos and Benjamin Bannie

Re: Review Request 55327: Windows: Fixed hanging symlink bug in `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55327/#review162019 --- Ship it! 3rdparty/stout/include/stout/os/windows/rmdir.hpp (li

Re: Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.

> On Jan. 17, 2017, 5:07 p.m., Jay Guo wrote: > > src/master/master.cpp, lines 7201-7203 > > > > > > There may be some corner cases that causes this `CHECK` to coredump. > > For example: > > 1. Start a Mesos cl

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55313/#review162016 --- src/slave/containerizer/mesos/launcher.cpp (lines 117 - 133)

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 17, 2017, 5:10 p.m., Jay Guo wrote: > > Also, should we allow user to downgrade from a multi-role framework to > > single-role? I feel it would be very complicated and we should explicitly > > disallow that... > > Benjamin Bannier wrote: > I am not sure this is required. We alrea

Re: Review Request 55312: Windows: Added parent hooks to subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55312/#review162015 --- Ship it! Ship It! - Joseph Wu On Jan. 7, 2017, 10:29 p.m., A

Re: Review Request 55311: Added `process::initialize` to default executor's `main`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55311/#review162013 --- src/launcher/default_executor.cpp (line 1055)

Re: Review Request 55446: Added common validation for IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55446/ --- (Updated Jan. 17, 2017, 5:37 p.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/#review162010 --- This helper method belongs in stout, as it is precisely something

Re: Review Request 55658: Updated Addition, modification and deletion of CNI configurations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55658/ --- (Updated Jan. 18, 2017, 1:29 a.m.) Review request for mesos, Jie Yu and Qian Zh

Review Request 55658: Updated Addition, modification and deletion of CNI configurations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55658/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-6806 https://i

Review Request 55657: Added cpack to create source package. Currently the cpack source package is create in TGZ format. The sources packages are comparable to the make dist output. There may be a need

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55657/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-4245 http

Re: Review Request 55024: Windows: Start the socket stack in `process::initialize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55024/#review162008 --- Fix it, then Ship it! I can make these slight tweaks before com

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/#review162009 --- Patch looks great! Reviews applied: [55238, 55239, 55240, 55241,

Re: Review Request 55191: Add hostname support to the network/cni isolator.

> On Jan. 6, 2017, 6:58 p.m., Jie Yu wrote: > > i feel that we can write a unit test using `__MESOS_TEST__`, can't we? > > Avinash sridharan wrote: > Actually you are right. Didn't realize we are actually setting up a new > UTS name space for __MESOS_TEST__ > > https://github.com/apach

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/ --- (Updated Jan. 18, 2017, 12:54 a.m.) Review request for mesos, Avinash sridharan

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/#review162001 --- src/slave/containerizer/mesos/containerizer.cpp (lines 1608 - 161

Re: Review Request 55022: Windows: Cause errors to be correctly reported in `io::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55022/#review161996 --- Ship it! I plan to update the commit summary to: ``` Windows: F

Re: Review Request 55637: CMake: Added `test` target.

> On Jan. 17, 2017, 8:46 p.m., Ilya Pronin wrote: > > I think the name "test" can confuse people because it's usually expected to > > be used for CTest. Maybe it would better be leave old {{tests}} and > > {{check}} targets? https://cmake.org/Wiki/CMakeEmulateMakeCheck That's a great question.

Re: Review Request 55491: Added `jenkins/tidybot.sh`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/ --- (Updated Jan. 17, 2017, 3:57 p.m.) Review request for mesos, Benjamin Bannier a

Review Request 55654: Renamed `CONFIGURE_FLAGS` to `CMAKE_ARGS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55654/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 17, 2017, 3:56 p.m.) Review request for mesos and Benjamin Bannie

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

> On Jan. 15, 2017, 1:55 a.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh, line 43 > > > > > > Removing the image sure made sense for an always regenerated image, but > > does it also for a relatively static i

Re: Review Request 55625: Prevented certain kinds of gaming the quota system.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55625/#review161981 --- Patch looks great! Reviews applied: [55625] Passed command: expo

Re: Review Request 55638: Clarified the assumptions on some returned Futures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55638/#review161980 --- Ship it! Ship It! - James Peach On Jan. 17, 2017, 10:39 p.m.

Review Request 55638: Clarified the assumptions on some returned Futures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55638/ --- Review request for mesos and James Peach. Repository: mesos Description -

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

> On Jan. 15, 2017, 1:55 a.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh, line 43 > > > > > > Removing the image sure made sense for an always regenerated image, but > > does it also for a relatively static i

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 17, 2017, 10:10 a.m., Jay Guo wrote: > > Also, should we allow user to downgrade from a multi-role framework to > > single-role? I feel it would be very complicated and we should explicitly > > disallow that... I am not sure this is required. We already make sure elsewhere that (1) o

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/ --- (Updated Jan. 17, 2017, 11:20 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55521: Handle perf versions with more than 3 components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55521/ --- (Updated Jan. 17, 2017, 10:19 p.m.) Review request for mesos, Ian Downes, Kapil

Re: Review Request 55240: Stop using os::system to copy local files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55240/ --- (Updated Jan. 17, 2017, 10:05 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 55239: Stop using os::system to extract fetcher archives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55239/ --- (Updated Jan. 17, 2017, 10:05 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 55241: Stop using os::system to validate perf event names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55241/ --- (Updated Jan. 17, 2017, 10:05 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/ --- (Updated Jan. 17, 2017, 10:06 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 55238: Use os::spawn in the CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55238/ --- (Updated Jan. 17, 2017, 10:05 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/#review161959 --- With respect to the comment, do you know when this check would fai

Re: Review Request 54649: Fixed minor argument style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54649/#review161956 --- Ship it! Ship It! - Benjamin Mahler On Jan. 12, 2017, 9:04 a

Re: Review Request 55563: Added capabilities to master's Slave struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55563/#review161950 --- Ship it! Ship It! - Benjamin Mahler On Jan. 16, 2017, 9:36 a

Re: Review Request 55562: Added Capability field to SlaveInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55562/#review161949 --- Ship it! Looks good. We should add a TODO to consider exposing

Re: Review Request 54574: Updated test case for call based metrics for scheduler api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54574/#review161947 --- Patch looks great! Reviews applied: [54572, 54573, 54574] Passed

Re: Review Request 55637: CMake: Added `test` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55637/#review161940 --- I think the name "test" can confuse people because it's usually ex

Review Request 55625: Prevented certain kinds of gaming the quota system.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55625/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Bugs: MESOS-

Re: Review Request 53291: Fixed incorrect `/monitor/statistics` URL in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53291/#review161931 --- Ship it! Is this the only agent url that needs this fix? - Ben

Review Request 55636: Libprocess: Removed usage of CTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55636/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. B

Review Request 55637: CMake: Added `test` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55637/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. B

Review Request 55635: Stout: Removed usage of CTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55635/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. B

Re: Review Request 55239: Stop using os::system to extract fetcher archives.

> On Jan. 12, 2017, 12:36 p.m., Jiang Yan Xu wrote: > > src/launcher/fetcher.cpp, line 105 > > > > > > Quote the command as well? What about this? > On Jan. 12, 2017, 12:36 p.m., Jiang Yan Xu wrote: > > src/launch

Re: Review Request 55521: Handle perf versions with more than 3 components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55521/#review161914 --- Fix it, then Ship it! src/linux/perf.hpp (line 55)

Re: Review Request 54572: Added metrics counter for scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54572/ --- (Updated Jan. 17, 2017, 7:18 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 54574: Updated test case for call based metrics for scheduler api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54574/ --- (Updated Jan. 17, 2017, 7:18 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 55521: Handle perf versions with more than 3 components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55521/#review161641 --- Ship it! src/linux/perf.cpp (line 206)

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/#review161659 --- Fix it, then Ship it! Just some style nits. 3rdparty/stout/in

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161909 --- Patch looks great! Reviews applied: [55381, 55571, 55271] Passed

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Jan. 17, 2017, 6:37 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 54183: Improved management of unreachable and completed tasks in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54183/ --- (Updated Jan. 17, 2017, 6:36 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 54573: Updated metrics counter during scheduler api calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54573/ --- (Updated Jan. 17, 2017, 6:33 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 54572: Added metrics counter for scheduler calls.

> On Dec. 12, 2016, 9:30 p.m., Zhitao Li wrote: > > src/master/metrics.cpp, lines 212-213 > > > > > > Do we want to keep the variable and metric names match (with `/` > > replaced by `_`)? do we really want this ch

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55621/#review161893 --- src/uri/fetchers/docker.cpp (line 168)

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54408/ --- (Updated Jan. 17, 2017, 5:24 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 54183: Improved management of unreachable and completed tasks in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54183/ --- (Updated Jan. 17, 2017, 5:24 p.m.) Review request for mesos and Vinod Kone. C

Review Request 55632: CMake: Disabled rpath to silence CMake warning on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55632/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. R

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/ --- (Updated Jan. 17, 2017, 6:14 p.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55571/ --- (Updated Jan. 17, 2017, 6:13 p.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.

> On Jan. 17, 2017, 10:07 a.m., Jay Guo wrote: > > src/master/master.cpp, lines 7201-7203 > > > > > > There may be some corner cases that causes this `CHECK` to coredump. > > For example: > > 1. Start a Mesos c

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55621/#review161886 --- Patch looks great! Reviews applied: [55496, 55621] Passed comman

Re: Review Request 53850: Implemented fetching Docker images that have V2 schema 2 manifests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53850/ --- (Updated Jan. 17, 2017, 4:59 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53849/ --- (Updated Jan. 17, 2017, 4:59 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53849/ --- (Updated Jan. 17, 2017, 3:44 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 55496: Added support for HTTP responses with unspecified length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55496/#review161870 --- Fix it, then Ship it! Let's add a unit test in `3rdparty/libpro

Re: Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55621/ --- (Updated Jan. 17, 2017, 3:53 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55612: Fixed SlaveRecoveryTest.RecoverTerminatedExecutor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55612/#review161869 --- Patch looks great! Reviews applied: [55611, 55612] Passed comman

Review Request 55621: Fixed issues with the Docker fetcher when using a proxy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55621/ --- Review request for mesos, Benjamin Bannier, Gilbert Song, and Jie Yu. Bugs: MES

Re: Review Request 55496: Added support for HTTP responses with unspecified length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55496/ --- (Updated Jan. 17, 2017, 3:35 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 52349: Add protobuf messages for OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52349/#review161867 --- Ship it! Ship It! - Jie Yu On Jan. 9, 2017, 7:21 a.m., Qian

Re: Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53849/#review161861 --- include/mesos/docker/v2_s2.proto (line 17)

Re: Review Request 55480: Fix segfault when the executor sets a UUID that is not a valid v4 UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/#review161863 --- Ship it! Ship It! - Vinod Kone On Jan. 16, 2017, 8:47 p.m.,

Re: Review Request 53848: Added support for pulling Docker images by digest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53848/#review161860 --- Fix it, then Ship it! src/slave/containerizer/mesos/provisione

Re: Review Request 55438: Fixed flakiness in SlaveRecoveryTest.RegisterDisconnectedSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55438/#review161859 --- Ship it! Ship It! - Vinod Kone On Jan. 12, 2017, 12:38 a.m.,

Re: Review Request 55437: Cleaned up SlaveRecoveryTest.RegisterDisconnectedSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55437/#review161858 --- Ship it! Ship It! - Vinod Kone On Jan. 12, 2017, 12:37 a.m.,

Re: Review Request 55612: Fixed SlaveRecoveryTest.RecoverTerminatedExecutor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55612/ --- (Updated Jan. 17, 2017, 1:06 p.m.) Review request for mesos and Greg Mann. Ch

Re: Review Request 55612: Fixed SlaveRecoveryTest.RecoverTerminatedExecutor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55612/#review161854 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Review Request 55612: Fixed SlaveRecoveryTest.RecoverTerminatedExecutor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55612/ --- Review request for mesos. Bugs: MESOS-6922 https://issues.apache.org/jira/b

Review Request 55611: Paused the status update manager in `Slave::initialize()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55611/ --- Review request for mesos and Greg Mann. Repository: mesos Description ---

Re: Review Request 55149: Added the `mesos-cni-port-mapper` to the CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55149/#review161853 --- Ship it! Ship It! - Jie Yu On Jan. 3, 2017, 7:28 p.m., Avina

Re: Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55607/#review161838 --- Patch looks great! Reviews applied: [55022, 55023, 55024, 55030,

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161828 --- Also, should we allow user to downgrade from a multi-role framewor

Re: Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55571/#review161827 --- src/master/master.cpp (lines 7201 - 7203)

Re: Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55607/ --- (Updated Jan. 17, 2017, 8:34 a.m.) Review request for mesos, Andrew Schwartzmey

Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55607/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. B