Re: Review Request 55901: [WIP] Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review162922 --- Patch looks great! Reviews applied: [55899, 55900, 55901] Passed

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/ --- (Updated Jan. 25, 2017, 8:33 a.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55571/ --- (Updated Jan. 25, 2017, 8:33 a.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 55858: Fixed bug when applying review chains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55858/#review162919 --- Fix it, then Ship it! support/apply-reviews.py (line 121)

Re: Review Request 55761: Fixed name matching for automatic resources.

> On Jan. 24, 2017, 1:47 a.m., Vinod Kone wrote: > > src/tests/containerizer/containerizer_tests.cpp, lines 76-77 > > > > > > also, can you just use "stringify" here? > > Bruce Merry wrote: > I don't follow. What

Re: Review Request 55761: Fixed name matching for automatic resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55761/ --- (Updated Jan. 25, 2017, 7:10 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 24, 2017, 3:32 p.m., Michael Park wrote: > > src/master/master.hpp, lines 2490-2504 > > > > > > What do you think about pulling the roles retrieval out? > > > > ```cpp > > auto getRoles = [](

Re: Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55571/#review162915 --- Fix it, then Ship it! src/master/master.cpp (lines 2607 - 2613

Re: Review Request 55858: Fixed bug when applying review chains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55858/#review162914 --- Ship it! - Benjamin Bannier On Jan. 23, 2017, 11:15 p.m., Nei

Re: Review Request 55790: Support the full CNI DNS specification.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55790/#review162760 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 55884: Updated the naming of unacknowledged tasks in executors for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55884/#review162911 --- Patch looks great! Reviews applied: [55884] Passed command: expo

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review162909 --- Patch looks great! Reviews applied: [54216, 54212, 54213, 54214,

Review Request 55910: Prevent unintended mutation in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55910/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55911: Fixed flakiness in TaskValidationTest.TaskReusesUnreachableTaskID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55911/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6983 https://issues.ap

Review Request 55909: Added a function for available agent resources in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55909/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55908: Made a function static in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55908/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 55632: CMake: Disabled rpath to silence CMake warning on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55632/#review162898 --- cmake/MesosConfigure.cmake (line 40)

Review Request 55903: Update XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55903/ --- Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu. Bugs: MESOS-5

Re: Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55607/#review162888 --- cmake/MesosConfigure.cmake (line 212)

Re: Review Request 55889: Fixes to comments in review 54216.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55889/#review162889 --- LGTM but leave to @haosdent for #shipit. - Jiang Yan Xu On Jan.

Re: Review Request 55795: Fixed `umountAll` to optionally also clean up mtab.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55795/#review162887 --- Ship it! Ship It! - James Peach On Jan. 25, 2017, 12:45 a.m.

Re: Review Request 55795: Fixed `umountAll` to optionally also clean up mtab.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55795/ --- (Updated Jan. 24, 2017, 4:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 14, 2017, 10:04 p.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, line 2616 > > > > > > How about s/RejectRolesChange/RejectRolesChangeWithMutiRole > > Benjamin Bannier wrote: > When

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 25, 2017, 12:32 a.m., Michael Park wrote: > > src/master/master.hpp, lines 2490-2504 > > > > > > What do you think about pulling the roles retrieval out? > > > > ```cpp > > auto getRoles = []

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/ --- (Updated Jan. 25, 2017, 1:41 a.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55571/ --- (Updated Jan. 25, 2017, 1:34 a.m.) Review request for mesos, Benjamin Mahler, J

Review Request 55901: [WIP] Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, a

Re: Review Request 55030: CMake: Added source groups for libprocess build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/#review162883 --- This review is partially un-done by https://reviews.apache.org/r/5

Re: Review Request 55599: CMake: Added `GroupSource` function to automate IDE source grouping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55599/#review162868 --- 3rdparty/stout/cmake/GroupSource.cmake (lines 24 - 26)

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55600/#review162882 --- 3rdparty/stout/cmake/StoutConfigure.cmake (line 47)

Review Request 55900: Improved style in `HealthChecker`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, a

Review Request 55899: Renamed `taskID` to `taskId` in `HealthChecker`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55899/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, a

Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-5116 https:/

Review Request 55896: Stop storing agent flags in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55896/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-5116 https:/

Review Request 55895: Add zero byte disk resource support to XFS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-5393 https:/

Re: Review Request 55767: Ensured task's check status is delivered with reconciliation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55767/#review162872 --- Fix it, then Ship it! src/common/protobuf_utils.cpp (line 256)

Re: Review Request 55795: Fixed `umountAll` to optionally also clean up mtab.

> On Jan. 23, 2017, 9:39 p.m., James Peach wrote: > > src/linux/fs.cpp, line 414 > > > > > > Why do you need `cleanUpMtab`. All the callers pass `true` and it is > > pretty hard to imagine a scenario where you *want

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review162878 --- Fix it, then Ship it! src/master/master.hpp (lines 2490 - 2504

Re: Review Request 55884: Updated the naming of unacknowledged tasks in executors for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55884/#review162874 --- src/launcher/default_executor.cpp (line 1016)

Re: Review Request 55689: Updated version in comment about TASK_LOST behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55689/#review162875 --- Ship it! Ship It! - Vinod Kone On Jan. 18, 2017, 11:21 p.m.,

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/ --- (Updated Jan. 24, 2017, 3:22 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 55768: Updated mesos-execute to show check's status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55768/#review162873 --- Ship it! Ship It! - Vinod Kone On Jan. 20, 2017, 2:52 p.m.,

Re: Review Request 55810: Fixed bug allowing IOSwitchboard::connect() after container destruction.

> On Jan. 24, 2017, 11:04 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 761-762 > > > > > > Hum, then, it's possible that we install two timers and sending sigterm > > twice? yes,

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

> On Jan. 22, 2017, 7:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.hpp, lines 149-154 > > > > > > I'd suggest we call this `defaultBackend`. I would try to avoid passing > > `back

Re: Review Request 55810: Fixed bug allowing IOSwitchboard::connect() after container destruction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55810/#review162684 --- src/slave/containerizer/mesos/io/switchboard.cpp

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

> On Jan. 22, 2017, 7:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.hpp, lines 149-154 > > > > > > I'd suggest we call this `defaultBackend`. I would try to avoid passing > > `back

Re: Review Request 55778: Moved check for 'has_parent()' in docker containerizer destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55778/#review162865 --- Ship it! Ship It! - Vinod Kone On Jan. 24, 2017, 10:24 p.m.,

Re: Review Request 55810: Fixed bug allowing IOSwitchboard::connect() after container destruction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55810/#review162864 --- Ship it! Ship It! - Vinod Kone On Jan. 24, 2017, 10:45 p.m.,

Re: Review Request 55810: Fixed bug allowing IOSwitchboard::connect() after container destruction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55810/ --- (Updated Jan. 24, 2017, 10:45 p.m.) Review request for mesos, Anand Mazumdar, B

Re: Review Request 55795: Fixed `umountAll` to optionally also clean up mtab.

> On Jan. 23, 2017, 1:39 p.m., James Peach wrote: > > src/linux/fs.cpp, line 414 > > > > > > Why do you need `cleanUpMtab`. All the callers pass `true` and it is > > pretty hard to imagine a scenario where you *want

Re: Review Request 55761: Fixed name matching for automatic resources.

> On Jan. 24, 2017, 1:47 a.m., Vinod Kone wrote: > > src/slave/containerizer/containerizer.cpp, line 82 > > > > > > s/parts/resources_/ > > Bruce Merry wrote: > Are you sure you want this? According to the style

Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55893/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco. Reposi

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55893/ --- (Updated Jan. 24, 2017, 1:52 p.m.) Review request for mesos, Benjamin Mahler, G

Review Request 55874: Added a simple AllocatorBacklog benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55874/ --- Review request for mesos, Benjamin Mahler, Jacob Janco, and Zhitao Li. Bugs: ME

Re: Review Request 55549: Windows: Added health checker to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55549/#review162853 --- src/health-check/CMakeLists.txt

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/ --- (Updated Jan. 24, 2017, 12:37 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 55714: Added fs::typeName() mapping function for fs id to fs type mapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55714/ --- (Updated Jan. 24, 2017, 12:36 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54215/ --- (Updated Jan. 24, 2017, 12:35 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 55713: Added linux helper function fs::type() for filesystem id detection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55713/ --- (Updated Jan. 24, 2017, 12:35 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/ --- (Updated Jan. 24, 2017, 12:34 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 54213: Supported more layers through symlink for aufs backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54213/ --- (Updated Jan. 24, 2017, 12:34 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 54816: Replaced os::getcwd() to sandbox.get() in provisioner test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54816/ --- (Updated Jan. 24, 2017, 12:35 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 54214: Added unit test for aufs backend supporting many layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54214/ --- (Updated Jan. 24, 2017, 12:35 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 55714: Added fs::typeName() mapping function for fs id to fs type mapping.

> On Jan. 22, 2017, 2:09 p.m., Jie Yu wrote: > > src/linux/fs.cpp, line 103 > > > > > > `s/_typeName/names/` > > > > or > > > > `s/_typeName/typeNames/` I would prefer `typeNames`. Thanks! - Gilb

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

> On Jan. 22, 2017, 11:19 a.m., Jie Yu wrote: > > Let's take a look how docker handles this case. > > > > My feeling is that it's ok to have duplicated layers because what if I want > > to apply the same content more than once? If there exists duplicate layers in an image. Those layers will st

Re: Review Request 54834: Fixed a typo in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54834/#review162849 --- Ship it! Ship It! - Vinod Kone On Dec. 17, 2016, 9:41 a.m.,

Re: Review Request 55761: Fixed name matching for automatic resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55761/#review162843 --- Patch looks great! Reviews applied: [55761] Passed command: expo

Re: Review Request 55876: Avoided shadowing in `Slave::run()`.

> On Jan. 24, 2017, 6:14 p.m., Neil Conway wrote: > > src/slave/slave.cpp, line 1579 > > > > > > I feel like we use an underscore suffix (`task_`) more often than a > > prefix. Is there a rule here? >From the nami

Review Request 55889: Fixes to comments in review 54216.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55889/ --- Review request for mesos. Repository: mesos Description --- Fixes to com

Review Request 55887: Check task user before allowing a task to be launched on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- Review request for mesos, Adam B and Jiang Yan Xu. Bugs: MESOS-6953 https:/

Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- Review request for mesos, Adam B and Jiang Yan Xu. Bugs: MESOS-6953 https:/

Re: Review Request 55876: Avoided shadowing in `Slave::run()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55876/#review162836 --- src/slave/slave.cpp (line 1579)

Review Request 55884: Updated the naming of unacknowledged tasks in executors for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55884/ --- Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Vinod Kone. Repos

Re: Review Request 55876: Avoided shadowing in `Slave::run()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55876/#review162824 --- Ship it! Ship It! - Gastón Kleiman On Jan. 24, 2017, 2:54 p.

Re: Review Request 55761: Fixed name matching for automatic resources.

> On Jan. 24, 2017, 1:47 a.m., Vinod Kone wrote: > > src/slave/containerizer/containerizer.cpp, line 82 > > > > > > s/parts/resources_/ Are you sure you want this? According to the style guide, "Some trailing unders

Re: Review Request 55761: Fixed name matching for automatic resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55761/ --- (Updated Jan. 24, 2017, 2:59 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 55761: Fixed name matching for automatic resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55761/ --- (Updated Jan. 24, 2017, 2:56 p.m.) Review request for mesos and Vinod Kone. B

Review Request 55876: Avoided shadowing in `Slave::run()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55876/ --- Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Neil Conway. Repo

Re: Review Request 55768: Updated mesos-execute to show check's status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55768/#review162803 --- Ship it! Ship It! - Gastón Kleiman On Jan. 20, 2017, 2:52 p.

Re: Review Request 55771: Rejected optimizing if we are working with a libcxx with UB.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55771/#review162802 --- Ship it! Ship It! - Till Toenshoff On Jan. 23, 2017, 11:33 a

Re: Review Request 55772: Rejected optimizing if we are working with a libcxx with UB.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55772/#review162801 --- Ship it! Ship It! - Till Toenshoff On Jan. 23, 2017, 11:32 a

Re: Review Request 55773: Rejected optimizing if we are working with a libcxx with UB.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55773/#review162800 --- Ship it! Ship It! - Till Toenshoff On Jan. 21, 2017, 12:23 a