Re: Review Request 55139: Implemented parse methods for OCI image spec.

> On Feb. 5, 2017, 12:02 p.m., Jie Yu wrote: > > src/oci/spec.cpp, lines 163-166 > > > > > > what if `digest.isNone()`? > > Qian Zhang wrote: > `digest` is a required field, so it can not be `None()` here. > >

Re: Review Request 56360: Fixed consistency in error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56360/ --- (Updated Feb. 7, 2017, 3:34 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 56375: Added a test to ensure offers with different roles cannot be combined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56375/ --- (Updated Feb. 7, 2017, 3:34 p.m.) Review request for mesos, Benjamin Bannier, B

Re: Review Request 54650: Added validation for roles in ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/ --- (Updated Feb. 7, 2017, 3:34 p.m.) Review request for mesos, Benjamin Bannier, B

Re: Review Request 56370: Added a test to ensure multi-role framework receiving offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56370/ --- (Updated Feb. 7, 2017, 3:29 p.m.) Review request for mesos, Benjamin Bannier, B

Review Request 56375: Added a test to ensure offers with different roles cannot be combined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56375/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu. B

Re: Review Request 54135: Added test for offer rescind in quota update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54135/ --- (Updated Feb. 7, 2017, 7:15 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 53993: Updated quota doc to support quota update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53993/ --- (Updated Feb. 7, 2017, 7:15 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 53991: Added master API call for `UPDATE_QUOTA`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53991/ --- (Updated Feb. 7, 2017, 7:14 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 52103: Implemented quota update through `PUT` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52103/ --- (Updated Feb. 7, 2017, 7:14 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 53691: Implemented some quota functionality tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53691/ --- (Updated Feb. 7, 2017, 7:13 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 54650: Added validation for roles in ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/#review164466 --- Ship it! src/master/validation.cpp (line 1462)

Re: Review Request 53679: Implemented capacity heuristic check related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53679/ --- (Updated Feb. 7, 2017, 7:11 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 52284: Implemented more quota validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52284/ --- (Updated Feb. 7, 2017, 7:10 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Feb. 7, 2017, 5:02 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55359/ --- (Updated Feb. 7, 2017, 5:02 a.m.) Review request for mesos, Benjamin Mahler and

Review Request 56370: Added a test to ensure multi-role framework receiving offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56370/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu. B

Review Request 56367: Stout: Windows: patch `os::killtree` to terminate job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56367/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-6892 http

Review Request 56363: Stout: Add predicate `find` semantics to `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56363/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-6892 http

Review Request 56366: Windows: Refactor executor to use `SharedHandle` semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56366/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-6892 http

Review Request 56365: Windows: Refactor `WindowsLauncher` to use Job Objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56365/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-6892 http

Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB` parent hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56368/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-6892 http

Review Request 56364: Windows: Stout: Rewrite Job Object wrappers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56364/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-6892 http

Review Request 56362: Windows: Create the `WindowsLauncher`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56362/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-6892 http

Review Request 56359: Add framework principal to the slave state endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56359/ --- Review request for mesos and Adam B. Bugs: MESOS-7071 https://issues.apache

Review Request 56360: Fixed consistency in error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56360/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 54650: Added validation for roles in ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/ --- (Updated Feb. 7, 2017, 10:10 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55160/#review164450 --- Ship it! Ship It! - haosdent huang On Feb. 6, 2017, 9:29 p.m

Re: Review Request 56327: Updated Suppress and Revive proto to support per role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56327/ --- (Updated 二月 7, 2017, 2:08 a.m.) Review request for mesos, Benjamin Mahler and J

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.MissingLayer test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56284/#review164449 --- Patch looks great! Reviews applied: [56174, 56284] Passed comman

Re: Review Request 56209: Hashed unacknowledged updates by UUID string in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56209/#review164447 --- Why this change? I can't tell from the linked ticket or the descri

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review164424 --- src/checks/checker.hpp (line 60)

Re: Review Request 56341: Changed docker/runtime isolator's handling of Environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56341/ --- (Updated Feb. 6, 2017, 5:19 p.m.) Review request for mesos, Jie Yu and Kevin Kl

Re: Review Request 56340: Disabled ability to launch default executor with ContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56340/ --- (Updated Feb. 6, 2017, 5:18 p.m.) Review request for mesos, Jie Yu and Kevin Kl

Re: Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55359/#review164101 --- LGTM. Just need to take another look after rebasing to ship it.

Re: Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56354/#review164430 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 6, 2017, 11

Re: Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56354/#review164427 --- Ship it! Ship It! - Joseph Wu On Feb. 6, 2017, 3:23 p.m., Mi

Re: Review Request 56270: Made the default executor launch multiple task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56270/#review164422 --- Ship it! Ship It! - Vinod Kone On Feb. 4, 2017, 5:53 p.m., A

Re: Review Request 56269: Introduced a `Container` struct on the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56269/#review164420 --- Ship it! Ship It! - Vinod Kone On Feb. 4, 2017, 5:51 p.m., A

Re: Review Request 56268: Made `kill()` not invoke `shutdown()` in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56268/#review164421 --- Ship it! Ship It! - Vinod Kone On Feb. 4, 2017, 5:52 p.m., A

Re: Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56354/#review164425 --- Ship it! Ship It! - Alex Clemmer On Feb. 6, 2017, 11:23 p.m.

Re: Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56354/ --- (Updated Feb. 6, 2017, 3:23 p.m.) Review request for mesos and Alex Clemmer.

Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56354/ --- Review request for mesos and Alex Clemmer. Repository: mesos Description

Re: Review Request 56352: Optimized and simplified `DRFSorter::allocated()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56352/ --- (Updated Feb. 6, 2017, 11:21 p.m.) Review request for mesos and Michael Park.

Re: Review Request 56341: Changed docker/runtime isolator's handling of Environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56341/ --- (Updated Feb. 6, 2017, 3:19 p.m.) Review request for mesos, Jie Yu and Kevin Kl

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated Feb. 6, 2017, 11:17 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated Feb. 6, 2017, 11:17 p.m.) Review request for mesos, Adam B, Alexander

Review Request 56352: Optimized and simplified `DRFSorter::allocated()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56352/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 56351: Renamed a private member function in DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56351/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 56350: Const-ified several methods in the sorter interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56350/ --- Review request for mesos. Repository: mesos Description --- Const-ified

Review Request 56349: Clarified comments in sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56349/ --- Review request for mesos. Repository: mesos Description --- Clarified co

Re: Review Request 56308: Modified active containers key to be `TaskID` in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56308/#review164418 --- Ship it! Ship It! - Vinod Kone On Feb. 4, 2017, 5:49 p.m., A

Review Request 56347: Stout: Explicitly delete `SharedHandle` default constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56347/ --- Review request for mesos. Repository: mesos Description --- Stout: Expli

Review Request 56339: Changed test DockerArchive to include environment variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56339/ --- Review request for mesos, Jie Yu and Kevin Klues. Bugs: MESOS-7027 https://

Review Request 56341: Added special case for command executor's environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56341/ --- Review request for mesos, Jie Yu and Kevin Klues. Bugs: MESOS-7027 https://

Review Request 56340: Disabled ability to launch default executor with ContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56340/ --- Review request for mesos, Jie Yu and Kevin Klues. Bugs: MESOS-7027 https://

Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55160/ --- (Updated Feb. 6, 2017, 9:29 p.m.) Review request for mesos, Gilbert Song, haosd

Re: Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/#review164410 --- src/master/master.cpp (lines 3942 - 3947)

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54821/ --- (Updated Feb. 6, 2017, 9:28 p.m.) Review request for mesos, Xiaojian Huang, hao

Re: Review Request 56330: Enabled suppress offer per role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56330/#review164407 --- include/mesos/allocator/allocator.hpp (lines 352 - 353)

Re: Review Request 56328: Augmented master `Suppress` API to accept `Call::Suppress`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56328/#review164406 --- Ship it! Ship It! - Benjamin Mahler On Feb. 6, 2017, 3:13 p.

Re: Review Request 56327: Updated Suppress and Revive proto to support per role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56327/#review164405 --- Ship it! include/mesos/scheduler/scheduler.proto (line 286)

Re: Review Request 56178: Enabled the authorizer to work with MULTI_ROLE frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56178/#review164403 --- Patch looks great! Reviews applied: [56178] Passed command: expo

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.MissingLayer test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56284/ --- (Updated Feb. 6, 2017, 8:40 p.m.) Review request for mesos, Jie Yu and Timothy

Re: Review Request 56338: Removed an unnecessary copy of operations in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56338/#review164396 --- Ship it! Ship It! - Jiang Yan Xu On Feb. 6, 2017, 11:47 a.m.

Review Request 56338: Removed an unnecessary copy of operations in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56338/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 56178: Enabled the authorizer to work with MULTI_ROLE frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56178/ --- (Updated Feb. 6, 2017, 8:32 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 56178: Enabled the authorizer to work with MULTI_ROLE frameworks.

> On Feb. 3, 2017, 11:26 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, line 244 > > > > > > Seems like framework_info is always set, so how/why would we ever fall > > through to the other cases? > >

Re: Review Request 54650: Added validation for roles in ACCEPT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/#review164393 --- Fix it, then Ship it! There seems to be a bug, otherwise looks

Re: Review Request 56178: Enabled the authorizer to work with MULTI_ROLE frameworks.

> On Feb. 3, 2017, 2:26 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, line 244 > > > > > > Seems like framework_info is always set, so how/why would we ever fall > > through to the other cases? > > B

Re: Review Request 55162: Stout: Added style fixes and some useful error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55162/#review164379 --- These changes won't be necessary with the `WindowsLauncher` patche

Re: Review Request 55749: Added CMake to standard documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55749/#review164378 --- Ship it! - Andrew Schwartzmeyer On Jan. 29, 2017, 7:22 a.m.,

Re: Review Request 55901: Added support for command health checks to the default executor.

> On Jan. 28, 2017, 1:17 a.m., Vinod Kone wrote: > > src/checks/health_checker.hpp, line 137 > > > > > > we don't typically do `const` for POD types. > > > > s/_agentSpawnsCommandContainer/ > > Gastón Kleim

Re: Review Request 56178: Enabled the authorizer to work with MULTI_ROLE frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56178/#review164374 --- Patch looks great! Reviews applied: [56178] Passed command: expo

Re: Review Request 55543: Fail the build if %PreferredToolArchitecture% is not set to `x64`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55543/#review164375 --- Ship it! So many MSVC problems. - Andrew Schwartzmeyer On Ja

Re: Review Request 55139: Implemented parse methods for OCI image spec.

> On Feb. 5, 2017, 4:02 a.m., Jie Yu wrote: > > src/oci/spec.cpp, lines 163-166 > > > > > > what if `digest.isNone()`? > > Qian Zhang wrote: > `digest` is a required field, so it can not be `None()` here. I'd p

Re: Review Request 55901: Added support for command health checks to the default executor.

> On Jan. 28, 2017, 1:17 a.m., Vinod Kone wrote: > > src/checks/health_checker.hpp, line 137 > > > > > > we don't typically do `const` for POD types. > > > > s/_agentSpawnsCommandContainer/ > > Gastón Kleim

Re: Review Request 56236: Add `syntax = "proto2"` to some files automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56236/#review164361 --- When we going to commit this, note that we need to send to d...@m

Re: Review Request 56330: Enabled suppress offer per role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56330/#review164356 --- Patch looks great! Reviews applied: [56327, 56328, 56330] Passed

Re: Review Request 56178: Enabled the authorizer to work with MULTI_ROLE frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56178/ --- (Updated Feb. 6, 2017, 4:44 p.m.) Review request for mesos, Adam B, Alexander R

Review Request 56330: Enabled suppress offer per role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56330/ --- Review request for mesos, Benjamin Mahler and Jay Guo. Bugs: MESOS-6638 htt

Review Request 56328: Augmented master `Suppress` API to accept `Call::Suppress`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56328/ --- Review request for mesos, Benjamin Mahler and Jay Guo. Bugs: MESOS-6638 htt

Review Request 56327: Updated Suppress and Revive proto to support per role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56327/ --- Review request for mesos, Benjamin Mahler and Jay Guo. Bugs: MESOS-6638 htt

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review164351 --- src/slave/slave.cpp (line 1659)

Re: Review Request 55139: Implemented parse methods for OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55139/ --- (Updated Feb. 6, 2017, 10:43 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 55139: Implemented parse methods for OCI image spec.

> On Feb. 5, 2017, 12:02 p.m., Jie Yu wrote: > > src/oci/spec.cpp, lines 163-166 > > > > > > what if `digest.isNone()`? `digest` is a required field, so it can not be `None()` here. > On Feb. 5, 2017, 12:02 p.m.,

Re: Review Request 56326: Size of the favicon optimized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56326/#review164346 --- Bad patch! Reviews applied: [56326] Failed command: python suppo

Re: Review Request 53741: Show maintainance schedule info in the WebUI.

> On Feb. 6, 2017, 9:30 a.m., haosdent huang wrote: > > I would fix these issues for you. Please take a look. Thanks a lot for your > > contribution! @haosdent Thanks for taking care of it. - Tomasz --- This is an automatically generat

Review Request 56326: Size of the favicon optimized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56326/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 55901: Added support for command health checks to the default executor.

> On Feb. 3, 2017, 1:34 p.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp, lines 2154-2155 > > > > > > Formatting. > > > > Also it is probably a good idea to explicitly say you don't car

Re: Review Request 55901: Added support for command health checks to the default executor.

> On Feb. 3, 2017, 1:34 p.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp, lines 2118-2119 > > > > > > Why do we need to expilictly create `containerizer`? > > Gastón Kleiman wrote: > Becaus

Re: Review Request 56178: Enabled the authorizer to work with MULTI_ROLE frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56178/#review164338 --- src/master/master.cpp (line 2177)

Re: Review Request 56178: Enabled the authorizer to work with MULTI_ROLE frameworks.

> On Feb. 3, 2017, 11:26 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, line 244 > > > > > > Seems like framework_info is always set, so how/why would we ever fall > > through to the other cases? > >

Re: Review Request 53741: Show maintainance schedule info in the WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review164323 --- Fix it, then Ship it! I would fix these issues for you. Please

Re: Review Request 53741: Show maintainance schedule info in the WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- (Updated Feb. 6, 2017, 9:29 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 56214: Hashed unacknowledged updates by UUID string in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56214/#review164322 --- Ship it! Ship It! - haosdent huang On Feb. 2, 2017, 9:57 a.m

Re: Review Request 56209: Hashed unacknowledged updates by UUID string in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56209/#review164321 --- Ship it! Ship It! - haosdent huang On Feb. 2, 2017, 9:56 a.m