Re: Review Request 56809: Added test for nested container machine reboot case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56809/#review166021 --- Patch looks great! Reviews applied: [56808, 56809] Passed comman

Re: Review Request 56806: Fixed some clang-tidy warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56806/#review166020 --- Patch looks great! Reviews applied: [56806] Passed command: expo

Re: Review Request 56624: Updated libprocess tests to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56624/ --- (Updated Feb. 18, 2017, 3:04 a.m.) Review request for mesos, Adam B, Alexander

Review Request 56813: Updated master handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56813/ --- Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff,

Review Request 56812: Updated agent handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56812/ --- Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff,

Re: Review Request 56619: Updated 'Files' handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/ --- (Updated Feb. 18, 2017, 3 a.m.) Review request for mesos, Adam B, Alexander Roj

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 18, 2017, 2:54 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

> On Feb. 16, 2017, 10:45 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/http.cpp, lines 87-109 > > > > > > Why not going the fancy way and use `jsonify()`? > > Alexander Rojas wrote: > Just add this fu

Re: Review Request 56238: Allowed using protobuf 3 in python bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56238/#review166018 --- Ship it! Ship It! - haosdent huang On Feb. 18, 2017, 2:23 a.

Re: Review Request 56238: Allowed using protobuf 3 in python bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56238/ --- (Updated Feb. 18, 2017, 2:23 a.m.) Review request for mesos, Deshi Xiao, Yong T

Re: Review Request 56238: Allowed using protobuf 3 in python bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56238/ --- (Updated Feb. 18, 2017, 2:23 a.m.) Review request for mesos, Deshi Xiao, Yong T

Review Request 56809: Added test for nested container machine reboot case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56809/ --- Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues. Repositor

Review Request 56808: Fixed nested container agent flapping issue after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56808/ --- Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues. Repositor

Re: Review Request 56805: Simplified interface for setting weights in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56805/#review166016 --- Patch looks great! Reviews applied: [56804, 56805] Passed comman

Review Request 56806: Fixed some clang-tidy warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56806/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 56805: Simplified interface for setting weights in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56805/ --- Review request for mesos, Adam B and Yongqiao Wang. Repository: mesos Descrip

Review Request 56804: Cleaned up weights handling code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56804/ --- Review request for mesos, Adam B and Yongqiao Wang. Repository: mesos Descrip

Re: Review Request 56493: Port_mapping isolator: do not depend on interface speed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56493/#review165973 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 56778: Fixed a bug around executor not able to use reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56778/#review165990 --- @anand, can you follow up on fixing the tests? src/tests/default

Re: Review Request 56619: Updated Mesos handlers to use 'AuthenticationContext'.

> On Feb. 16, 2017, 3:56 p.m., Alexander Rojas wrote: > > src/master/http.cpp, lines 796-798 > > > > > > This appears here, there and everywhere, that I'm considering it may be > > a good idea to abstract it to some

Re: Review Request 56619: Updated Mesos handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/ --- (Updated Feb. 17, 2017, 10:36 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

> On Feb. 14, 2017, 3:12 p.m., Jan Schlicht wrote: > > src/common/http.hpp, line 133 > > > > > > How about using an `Option` here and returning > > `Subject()` in the case of `context.isNone()`? > > All calls to

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/ --- (Updated Feb. 17, 2017, 10:34 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 17, 2017, 10:33 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56611: Relax perf version check for Arch Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56611/#review165983 --- Ship it! Ship It! - Neil Conway On Feb. 14, 2017, 3:59 p.m.,

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

> On Feb. 16, 2017, 10:56 a.m., Alexander Rojas wrote: > > src/common/http.cpp, line 708 > > > > > > I have the feeling that `extractAuthorizationSubject` may be a better > > way of describing what is happening here

Re: Review Request 50974: Documented all the API calls for Operator HTTP API.

> On Jan. 31, 2017, 7:44 p.m., Vinod Kone wrote: > > I've commited this and fixed the issues myself. Thanks for the patch! - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50974/#revie

Re: Review Request 56778: Fixed a bug around executor not able to use reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56778/ --- (Updated Feb. 17, 2017, 8:15 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 56778: Fixed a bug around executor not able to use reserved resources.

> On Feb. 17, 2017, 7:41 p.m., Vinod Kone wrote: > > src/tests/default_executor_tests.cpp, lines 1416-1417 > > > > > > hmm. why didn't you just start with a v1::ExecutorInfo like you did > > with v1::TaskGroup? Mo

Re: Review Request 56692: Silenced a GMock warning in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56692/#review165967 --- Ship it! Ship It! - Michael Park On Feb. 17, 2017, 11:35 a.m

Re: Review Request 56781: Fixed compilation on VS 2017.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56781/ --- (Updated Feb. 17, 2017, 12:07 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 56053: Added a 'SECRET' type to the 'Environment' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56053/#review165962 --- Ship it! Ship It! - Vinod Kone On Feb. 16, 2017, 5:57 p.m.,

Re: Review Request 56778: Fixed a bug around executor not able to use reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56778/#review165959 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp (li

Re: Review Request 56692: Silenced a GMock warning in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56692/ --- (Updated Feb. 17, 2017, 7:35 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 56493: Port_mapping isolator: do not depend on interface speed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56493/#review165957 --- Patch looks great! Reviews applied: [56493] Passed command: expo

Re: Review Request 56493: Port_mapping isolator: do not depend on interface speed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56493/ --- (Updated Feb. 17, 2017, 3:51 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 56413: WIP Support pausing/resuming health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56413/#review165932 --- Patch looks great! Reviews applied: [55900, 56288, 55901, 56413]

Re: Review Request 56413: WIP Support pausing/resuming health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56413/ --- (Updated Feb. 17, 2017, 12:01 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 55901: Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/ --- (Updated Feb. 17, 2017, 11:59 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 56537: Added a test to ensure framework can upgrade to support MULTI_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56537/#review165920 --- Fix it, then Ship it! src/tests/master_tests.cpp (line 6406) <

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

> On Feb. 16, 2017, 11:45 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/http.cpp, lines 87-109 > > > > > > Why not going the fancy way and use `jsonify()`? Just add this function in the same namespace as t

Re: Review Request 55576: Fixes FutureTest.After3 flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/ --- (Updated Feb. 17, 2017, 10:51 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 56781: Fixed compilation on VS 2017.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56781/#review165916 --- Patch looks great! Reviews applied: [56781] Passed command: expo

Re: Review Request 56781: Fixed compilation on VS 2017.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56781/#review165913 --- Fix it, then Ship it! 3rdparty/libprocess/include/process/futu

Review Request 56781: Fixed compilation on VS 2017.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56781/ --- Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Joseph Wu. Re