Re: Review Request 57976: Refactor default executor for `launchTaskSubprocess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57976/#review170255 --- Patch looks great! Reviews applied: [56364, 56367, 57973, 57974,

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review170253 --- Patch looks great! Reviews applied: [57963, 57964] Passed comman

Re: Review Request 57767: Added quota to /roles endpoint of master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57767/#review170252 --- Ship it! Ship It! - Benjamin Mahler On March 23, 2017, 8:03

Re: Review Request 57767: Added quota to /roles endpoint of master.

> On March 28, 2017, 12:57 a.m., Benjamin Mahler wrote: > > Approach looks good, just curious if we can avoid more summarized resources > > in favor of a direct translation to json. On second thought, I suppose this is ok given this is how the role resources are being represented. We just want

Re: Review Request 57828: Modified WebUI to display quota under `roles` tab.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57828/#review170249 --- Ship it! Ship It! - Benjamin Mahler On March 22, 2017, 6:28

Re: Review Request 57768: Added a test to check /roles endpoint of master includes quota info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57768/#review170250 --- Ship it! Ship It! - Benjamin Mahler On March 22, 2017, 4:46

Re: Review Request 57767: Added quota to /roles endpoint of master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57767/#review170246 --- Approach looks good, just curious if we can avoid more summarized

Re: Review Request 57828: Modified WebUI to display quota under `roles` tab.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57828/#review170244 --- Looks good, modulo filling in with zeros when there is no quota (n

Re: Review Request 57828: Modified WebUI to display quota under `roles` tab.

> On March 22, 2017, 6:31 a.m., Jay Guo wrote: > > src/webui/master/static/roles.html > > Lines 28-31 (original), 28-31 (patched) > > > > > > In case quota is not set for a role, should we fill them with zeros in > >

Re: Review Request 57190: Updated agent for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57190/#review170243 --- Sorry for dropping the ball on this one. Some minor feedback below

Re: Review Request 57976: Refactor default executor for `launchTaskSubprocess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57976/ --- (Updated March 27, 2017, 11:21 p.m.) Review request for mesos, John Kordich, Jo

Re: Review Request 57952: Added 'config' plugin to the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review170237 --- I think we should strip everything out of this commit except the p

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/#review170235 --- src/cli_new/README.md Lines 46-68 (patched)

Re: Review Request 57973: Windows: Add `JobObjectManager` actor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57973/ --- (Updated March 27, 2017, 10:47 p.m.) Review request for mesos, John Kordich, Jo

Re: Review Request 56365: Windows: Refactor `WindowsLauncher` to use Job Objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56365/ --- (Updated March 27, 2017, 3:45 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 56362: Windows: Create the Windows container launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56362/ --- (Updated March 27, 2017, 3:44 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 56366: Windows: Refactor executor to use `SharedHandle` semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56366/ --- (Updated March 27, 2017, 3:43 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 56364: Windows: Stout: Rewrite job object wrappers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56364/ --- (Updated March 27, 2017, 10:43 p.m.) Review request for mesos, John Kordich, Jo

Re: Review Request 56367: Windows: Stout: Shim `os::killtree` to terminate job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56367/ --- (Updated March 27, 2017, 10:42 p.m.) Review request for mesos, John Kordich, Jo

Review Request 57976: Refactor default executor for `launchTaskSubprocess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57976/ --- Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park. Rep

Review Request 57975: Windows: Use Subprocess in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57975/ --- Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park. Rep

Review Request 57974: Windows: Replace WindowsLauncher with SubprocessLauncher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57974/ --- Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park. Rep

Review Request 57973: Windows: Add `JobObjectManager` actor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57973/ --- Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park. Rep

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

> On March 27, 2017, 7:43 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 8894-8900 (original), 8894-8911 (patched) > > > > > > Something like this more elegant? > > > > ``` > > double Mas

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57963/ --- (Updated March 27, 2017, 10:27 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/ --- (Updated March 27, 2017, 10:27 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 57972: Added base stout Environment class to mesos-tests Environment class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57972/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Bugs: MESOS-6731

Review Request 57971: Added test filtering framework to libprocess-tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57971/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Bugs: MESOS-6731

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/ --- (Updated March 27, 2017, 10:13 p.m.) Review request for mesos, Andrew Schwartzm

Re: Review Request 56367: Windows: Stout: Shim `os::killtree` to terminate job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56367/ --- (Updated March 27, 2017, 10:12 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 56364: Windows: Stout: Rewrite job object wrappers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56364/ --- (Updated March 27, 2017, 10:10 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 55065: Added support for s390x architecture

> On March 27, 2017, 7:01 p.m., Kevin Klues wrote: > > src/slave/flags.cpp > > Lines 152-158 (original), 152-169 (patched) > > > > > > We typically don't create duplicate entries like this when simply > > customizin

Re: Review Request 54688: Added a `docker_store_dir` flag to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54688/#review170226 --- src/tests/environment.cpp Lines 846-855 (patched)

Re: Review Request 56193: Use Docker cpus instead of cpu_share if possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56193/#review170223 --- src/docker/docker.cpp Lines 524 (patched)

Re: Review Request 56853: Update OCI tests with the latest OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56853/#review170222 --- Fix it, then Ship it! src/tests/containerizer/oci_spec_tests.c

Re: Review Request 56852: Updated OCI spec parsing & validation code with latest OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56852/#review170221 --- Ship it! Ditto on s/ImageIndex/Index/ - Jie Yu On March 2, 2

Re: Review Request 56851: Updated OCI protobuf messages with latest OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56851/#review170220 --- include/mesos/oci/spec.proto Line 74 (original), 84 (patched)

Re: Review Request 56851: Updated OCI protobuf messages with latest OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56851/#review170218 --- Ship it! Ship It! - Jie Yu On Feb. 23, 2017, 1:26 p.m., Qian

Re: Review Request 55065: Added support for s390x architecture

> On March 27, 2017, 7:01 p.m., Kevin Klues wrote: > > src/slave/flags.cpp > > Lines 152-158 (original), 152-169 (patched) > > > > > > We typically don't create duplicate entries like this when simply > > customizin

Re: Review Request 55065: Added support for s390x architecture

> On March 22, 2017, 2:45 p.m., Till Toenshoff wrote: > > src/linux/ldcache.cpp > > Line 120 (original), 120 (patched) > > > > > > Can you elaborate why this change is safe for all systems? > > Ayanampudi Varsha wro

Re: Review Request 55065: Added support for s390x architecture

> On March 22, 2017, 2:45 p.m., Till Toenshoff wrote: > > src/linux/ldcache.cpp > > Line 120 (original), 120 (patched) > > > > > > Can you elaborate why this change is safe for all systems? > > Ayanampudi Varsha wro

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57963/#review170213 --- src/master/master.cpp Lines 8894-8900 (original), 8894-8911 (patc

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review170212 --- Patch looks great! Reviews applied: [57963, 57964] Passed comman

Re: Review Request 55065: Added support for s390x architecture

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55065/#review170209 --- src/slave/flags.cpp Lines 152-158 (original), 152-169 (patched) <

Review Request 57964: Added a test to verify metrics when shared resources are present.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-7186 https://issues.

Review Request 57963: Metrics for used resources should incorporate shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57963/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-7186 https://issues.

Re: Review Request 57884: Ensure that host /etc/* files are mounted RDONLY by the CNI Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57884/#review170196 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp Line

Re: Review Request 57952: Added 'config' plugin to the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review170166 --- Patch looks great! Reviews applied: [57896, 57951, 57952] Passed

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- (Updated March 27, 2017, noon) Review request for mesos and Kevin Klues. Bugs

Re: Review Request 57952: Added 'config' plugin to the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated March 27, 2017, noon) Review request for mesos and Kevin Klues. Bugs

Review Request 57952: Added 'config' plugin to the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- Review request for mesos. Repository: mesos Description --- Used to show

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- (Updated March 27, 2017, 11:58 a.m.) Review request for mesos. Repository: me

Review Request 57951: Moved new CLI settings into a user-defined TOML file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- Review request for mesos. Repository: mesos Description --- These settin

Re: Review Request 57896: Renamed 'config.py' to 'settings.py' in the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57896/ --- (Updated March 27, 2017, 11:56 a.m.) Review request for mesos and Kevin Klues.

Re: Review Request 57950: Reordered messages in 'acls.proto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57950/#review170153 --- Patch looks great! Reviews applied: [57950] Passed command: expo

Re: Review Request 57950: Reordered messages in 'acls.proto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57950/#review170152 --- Fix it, then Ship it! I'll fix the issue while committing. in

Re: Review Request 57950: Reordered messages in 'acls.proto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57950/#review170150 --- Ship it! Ship It! - Alexander Rojas On March 27, 2017, 11:50

Review Request 57950: Reordered messages in 'acls.proto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57950/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Vinod Kone.

Re: Review Request 57386: Introduced changes to the authz protos needed for RemoveNestedContainer.

> On March 9, 2017, 2:09 a.m., Vinod Kone wrote: > > include/mesos/authorizer/acls.proto > > Lines 448 (patched) > > > > > > move this to #440. Sorry to have seen this too late, but in the authorization protobufs we

Re: Review Request 55065: Added support for s390x architecture

> On March 22, 2017, 2:45 p.m., Till Toenshoff wrote: > > src/linux/ldcache.cpp > > Line 120 (original), 120 (patched) > > > > > > Can you elaborate why this change is safe for all systems? We have tried this on Big

Re: Review Request 57385: Introduced proto changes needed for the RemoveNestedContainer API call.

> On March 8, 2017, 2:04 a.m., Kevin Klues wrote: > > include/mesos/agent/agent.proto > > Lines 186 (patched) > > > > > > Can you move this up to sit underneath the `KillNestedContainer` field. > > It's OK that the

Re: Review Request 55065: Added support for s390x architecture

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55065/ --- (Updated March 27, 2017, 9:25 a.m.) Review request for mesos, Till Toenshoff an