Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review174760 --- Patch looks great! Reviews applied: [58394] Passed command:

Re: Review Request 59001: Added volume secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/ --- (Updated May 11, 2017, 10:20 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 55903: Update XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55903/#review174755 --- Patch looks great! Reviews applied: [55896, 55895, 55897, 55903]

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review174754 --- Currently we require getting the peer each time we receive some

Re: Review Request 58928: Update process tests to use a non-zero UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58928/#review174753 --- Fix it, then Ship it! Test changes look good, just noticed

Re: Review Request 59150: Document LIBPROCESS_REQUIRE_PEER_ADDRESS_IP_MATCH.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59150/#review174752 --- Ship it! docs/configuration.md Lines 2121 (patched)

Re: Review Request 58977: Add local and peer address accessors to http::Connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58977/#review174751 --- 3rdparty/libprocess/include/process/http.hpp Lines 960-968

Review Request 59218: Removed code for old agents when handling status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59218/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 59219: Removed code for old agents in agent re-registration logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59219/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6977

Review Request 59217: Removed outdated comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59217/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6977

Review Request 59216: Fixed some inaccurate comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59216/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6977

Review Request 59215: Removed orphaned tasks from webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59215/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6978

Review Request 59214: Removed code for handling missing FrameworkInfo of a running task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59214/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6977

Review Request 59213: Cleaned up agent re-registration code in the master slightly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59213/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6977

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58347/#review174734 --- Also please double-check that this RR builds by itself (applying

Re: Review Request 58347: Introduced a filter for test cases that need thread-safety.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58347/#review174731 --- Can you rebase this, please? - Neil Conway On April 24, 2017,

Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59198/#review174730 --- Ship it! Ship It! - Adam B On May 11, 2017, 2:10 p.m., Neil

Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59198/ --- (Updated May 11, 2017, 9:10 p.m.) Review request for mesos and Adam B.

Re: Review Request 59202: Ported the net::mac to the Windows Platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59202/ --- (Updated May 11, 2017, 9:10 p.m.) Review request for mesos, Andrew

Re: Review Request 57935: Recalculate shares only when total scalar quantities have changed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57935/ --- (Updated May 11, 2017, 9:02 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 59200: Ported the net::links routine to Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59200/ --- (Updated May 11, 2017, 8:56 p.m.) Review request for mesos, Andrew

Re: Review Request 59200: Ported the net::links routine to Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59200/#review174724 --- 3rdparty/stout/include/stout/windows/net.hpp Lines 62 (patched)

Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59198/#review174722 --- Couple more nits, then we can ship-it CHANGELOG Line 52

Re: Review Request 58486: Update the allocator on a per offer operation.

> On April 20, 2017, 6:17 p.m., Jiang Yan Xu wrote: > > I feel the following may be more clear and general at high level. > > > > - In `_accept()` all operations are validated, for resource operations we > > call `updateAllocation` for each individual operation [like we used to > >

Re: Review Request 58486: Update the allocator on a per offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58486/ --- (Updated May 11, 2017, 8:21 p.m.) Review request for mesos, James Peach and

Review Request 59194: Validate DESTROY operation in `Resources::apply()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59194/ --- Review request for mesos, James Peach and Jiang Yan Xu. Bugs: MESOS-7403

Review Request 59195: Ensure that allocator can be updated before committing changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59195/ --- Review request for mesos, James Peach and Jiang Yan Xu. Bugs: MESOS-7308

Review Request 59202: Ported the net::mac to the Windows Platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59202/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Review Request 59201: Ported the IPNetwork::fromLinkDevice to the Windows Platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59201/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Review Request 59200: Ported the net::links routine to Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59200/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, and Joseph Wu.

Re: Review Request 59203: Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59203/ --- (Updated May 11, 2017, 8:09 p.m.) Review request for mesos, Andrew

Review Request 59203: Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59203/ --- Review request for mesos. Repository: mesos Description --- Enable

Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59198/ --- (Updated May 11, 2017, 7:47 p.m.) Review request for mesos and Adam B.

Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59198/#review174713 --- A few thoughts CHANGELOG Lines 51-52 (patched)

Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59198/ --- (Updated May 11, 2017, 6:58 p.m.) Review request for mesos and Adam B.

Re: Review Request 59191: Added another test case for Docker version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59191/#review174711 --- Ship it! Ship It! - Benjamin Mahler On May 11, 2017, 5:30

Re: Review Request 59190: Adjusted test expectation for change to stout's Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59190/#review174710 --- Ship it! Ship It! - Benjamin Mahler On May 11, 2017, 5:30

Review Request 59198: Added CHANGELOG note that 1.3.0 and 1.2.1 masters ignore old agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59198/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated May 11, 2017, 6:34 p.m.) Review request for mesos, Jason Lai, Joseph

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

> On May 2, 2017, 11:11 p.m., Kevin Klues wrote: > > src/python/.gitignore > > Lines 1 (patched) > > > > > > Why do you need .virtualenv in this folder? I wouldn't expect us to > > create a .virtualenv directory

Re: Review Request 55903: Update XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55903/ --- (Updated May 11, 2017, 6:20 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 55903: Update XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55903/#review174703 --- Fix it, then Ship it! docs/mesos-containerizer.md Lines 103

Re: Review Request 58487: Fix allocation quantities when shared resources are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58487/ --- (Updated May 11, 2017, 6:13 p.m.) Review request for mesos, James Peach and

Re: Review Request 59177: CLI: Added Config class to manage the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59177/#review174702 --- Patch looks great! Reviews applied: [59177] Passed command:

Re: Review Request 55903: Update XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55903/ --- (Updated May 11, 2017, 5:55 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- (Updated May 11, 2017, 5:55 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On Maj 11, 2017, 8:35 rano, Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Lines 17-20 (original), 17-20 (patched) > > > > > > How about usign `` here instead of list? Then `/` will be just

Re: Review Request 56681: Use glog to log EXIT() messages.

> On March 20, 2017, 8:32 p.m., Benjamin Mahler wrote: > > Have you seen the feedback > > [here](https://issues.apache.org/jira/browse/MESOS-3465?focusedCommentId=14944383=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14944383)? > > It would be nice to make it clear

Re: Review Request 56680: Use the EXIT() macro more consistently in agent startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56680/ --- (Updated May 11, 2017, 5:36 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 56681: Use glog to log EXIT() messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56681/ --- (Updated May 11, 2017, 5:36 p.m.) Review request for mesos, haosdent huang and

Review Request 59191: Added another test case for Docker version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59191/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 59190: Adjusted test expectation for change to stout's Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59190/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 59185: Add ambient capability support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59185/ --- (Updated May 11, 2017, 4:45 p.m.) Review request for mesos, Benjamin Bannier

Review Request 59186: Additional linux/capabilities isolator documention.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59186/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-7477

Review Request 59184: Add support for explicitly setting bounding capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59184/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-7476

Review Request 59185: Add ambient capability support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59185/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-7476

Review Request 59183: Refactor setting capabilities into a helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59183/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7476

Re: Review Request 59074: Updated all tests that use Containerizer::launch(...).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59074/#review174666 --- Fix it, then Ship it! src/tests/hook_tests.cpp Lines 303

Re: Review Request 59164: Updated fetcher tests to reflect changed interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59164/#review174665 --- Ship it! Ship It! - Jie Yu On May 11, 2017, 12:27 a.m.,

Re: Review Request 59073: Updated Docker containerizer tests to use the old naming scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59073/#review174664 --- Ship it! Ship It! - Jie Yu On May 11, 2017, 12:26 a.m.,

Re: Review Request 58910: Addressed a TODO about checkpointing in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58910/#review174663 --- Ship it! Ship It! - Jie Yu On May 11, 2017, 12:26 a.m.,

Re: Review Request 58909: Added test helpers to tranlate to ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58909/#review174661 --- Ship it! Ship It! - Jie Yu On May 2, 2017, 2:17 a.m.,

Re: Review Request 58908: Updated test mocks per interface changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58908/#review174660 --- Ship it! Ship It! - Jie Yu On May 8, 2017, 10:45 p.m.,

Re: Review Request 58907: Refactored Docker containerizer launch path per interface changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58907/#review174653 --- Fix it, then Ship it! src/slave/containerizer/docker.hpp

Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State enumeration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59146/#review174646 --- Ship it! Ship It! - Benjamin Bannier On May 10, 2017, 5:09

Re: Review Request 58906: Removed extranous sandbox initialization in Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58906/#review174643 --- src/slave/containerizer/docker.cpp Line 285 (original)

Review Request 59177: CLI: Added Config class to manage the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59177/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 58905: Changed naming of Docker containers to the pre-0.23 scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58905/#review174641 --- src/slave/containerizer/docker.hpp Line 318 (original), 319

Re: Review Request 58904: Combined launch paths in ComposingContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58904/#review174639 --- Fix it, then Ship it! src/slave/containerizer/composing.cpp

Re: Review Request 58903: Combined Mesos containerizer's launch methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58903/#review174637 --- Fix it, then Ship it!

Re: Review Request 58902: Changed containerizer->launch callsites to new interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58902/#review174634 --- Ship it! Ship It! - Jie Yu On May 2, 2017, 2:02 a.m.,

Re: Review Request 58899: Combined containerizer interface's launch methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58899/#review174626 --- Fix it, then Ship it!

Re: Review Request 58967: Set the working directory to parent task's for DEBUG containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58967/ --- (Updated May 11, 2017, 10:07 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 58900: Changed the default fetcher cache directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/#review174619 --- Ship it! Ship It! - Jie Yu On May 10, 2017, 8:32 p.m.,

Re: Review Request 58900: Changed the default fetcher cache directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/#review174618 --- Great clean up! src/local/local.cpp Lines 372-374 (patched)

Re: Review Request 58967: Set the working directory to parent task's for DEBUG containers.

> On May 10, 2017, 9:58 p.m., Vinod Kone wrote: > > include/mesos/slave/containerizer.proto > > Line 194 (original), 194 (patched) > > > > > > Looks like some random unicode char at the end? Apologies, this is a

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/#review174615 --- src/webui/master/static/browse.html Lines 17-20 (original),

Re: Review Request 56680: Use the EXIT() macro more consistently in agent startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56680/#review174611 --- Ship it! Ship It! - Jiang Yan Xu On May 8, 2017, 4:29 p.m.,

Re: Review Request 59001: Added volume secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/#review174610 --- src/slave/containerizer/mesos/isolators/volume/secret.cpp Lines