Re: Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59541/#review176038 --- Looks good minus a small query.

Re: Review Request 59556: Windows: Updated build documentation.

> On May 25, 2017, 12:04 a.m., Jeff Coffler wrote: > > docs/windows.md > > Lines 34 (patched) > > > > > > Do you want to mention this? > > > > I thought this was going away with your current set of patches,

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

> On May 25, 2017, 3:16 a.m., Kevin Klues wrote: > > src/cli_new/lib/cli/tests/base.py > > Lines 216 (patched) > > > > > > We need to be consistent here. If all functions in this file that we > > pass to

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176035 --- src/cli_new/lib/cli/tests/base.py Lines 216 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176034 --- src/cli_new/lib/cli/tests/base.py Lines 281-288 (patched)

Re: Review Request 59537: Fixed a bug in 'ComposingContainerizerProcess::wait()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59537/#review176030 --- Patch looks great! Reviews applied: [59537] Passed command:

Review Request 59560: Replaced "!(x == y)" with "x != y" when comparing SlaveIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59560/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 59559: Replaced `.get().` with `->` in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59559/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 59558: Replaced `.get().` with `->` for access to `Master::leader`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59558/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53666/#review176028 --- Patch looks great! Reviews applied: [53666] Passed command:

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/#review176027 --- Fix it, then Ship it! 3rdparty/stout/include/stout/bytes.hpp

Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59454/#review176026 --- Ship it! Ship It! - James Peach On May 24, 2017, 5:53 p.m.,

Re: Review Request 59556: Windows: Updated build documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59556/#review176024 --- docs/windows.md Lines 34 (patched)

Re: Review Request 59557: Windows: Bumped required CMake version to 3.8.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59557/#review176022 --- Ship it! Ship It! - Jeff Coffler On May 24, 2017, 11:37

Re: Review Request 59186: Additional linux/capabilities isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59186/ --- (Updated May 24, 2017, 11:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 59185: Add ambient capability support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59185/ --- (Updated May 24, 2017, 11:46 p.m.) Review request for mesos, Jie Yu and Jiang

Review Request 59554: Rename the `--allowed_capabilities` flag to `--effective_capabilities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59554/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-7477

Review Request 59552: Add support for explicitly setting bounding capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59552/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-7476

Review Request 59553: Add ambient capabilities to launched tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59553/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-7477

Review Request 59550: Check bounding capabilities at isolator creation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59550/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-7476

Review Request 59551: Change launcher working directory before dropping privilege.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59551/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-7476

Review Request 59549: Add the agent --bounding_capabilities flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59549/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-7476

Review Request 59548: Add a `bounding_capabilities` field to ContainerLaunchInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59548/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-7476

Review Request 59547: Rename ContainerLaunchInfo `capabilities` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59547/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-7476

Review Request 59556: Windows: Updated build documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59556/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Review Request 59557: Windows: Bumped required CMake version to 3.8.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59557/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review176019 --- This needs a rebase. `support/apply-reviews.py` choked on it and

Review Request 59555: A prototype to move sample collection into async sampling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59555/ --- Review request for mesos. Repository: mesos Description --- A prototype

Re: Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/ --- (Updated May 24, 2017, 11:10 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.

Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59541/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7552

Re: Review Request 59538: Cleaned up allocator benchmark tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59538/#review175995 --- Ship it! Ship It! - Michael Park On May 24, 2017, 1:23

Re: Review Request 59484: Introduced `DRFSorter::Node::isLeaf()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59484/#review175994 --- Ship it! Ship It! - Michael Park On May 22, 2017, 11:28

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

> On May 17, 2017, 2:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > > Lines 586-588 (patched) > > > > > > Instead of shelling out, i'd say we just introduce support in

Review Request 59537: Fixed a bug in 'ComposingContainerizerProcess::wait()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59537/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod

Re: Review Request 59484: Introduced `DRFSorter::Node::isLeaf()`.

> On May 24, 2017, 7:08 a.m., Michael Park wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Lines 102-108 (original), 102 (patched) > > > > > > Did we lose the `!= lastCreatedNode` check here? or am I

Re: Review Request 59383: Added benchmark for allocator perf with many suppressed frameworks.

> On May 24, 2017, 6:36 a.m., Michael Park wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 5500-5501 (patched) > > > > > > Is this intentional? > > > > It seems like it is. As in, `used` is

Review Request 59538: Cleaned up allocator benchmark tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59538/ --- Review request for mesos, Benjamin Mahler, James Peach, Michael Park, and Jiang

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review175985 --- Ship it! Ship It! - Aaron Wood On May 24, 2017, 7:13 p.m.,

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

> On May 24, 2017, 7:47 p.m., Aaron Wood wrote: > > Are these hashes checked anywhere? I didn't seen anything that's verifying > > the hashes. Yes, the `URL_HASH` argument to the `ExternalProject_Add` [macro](https://cmake.org/cmake/help/v3.8/module/ExternalProject.html) performs automatic

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/ --- (Updated May 24, 2017, 7:56 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/ --- (Updated May 24, 2017, 7:56 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated May 24, 2017, 7:56 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated May 24, 2017, 7:56 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review175979 --- Are these hashes checked anywhere? I didn't seen anything that's

Re: Review Request 59074: Updated all tests that use Containerizer::launch(...).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59074/#review175976 --- Bad patch! Reviews applied: [59074, 59164, 59073, 58910, 58909,

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/ --- (Updated May 24, 2017, 7:13 p.m.) Review request for mesos, Aaron Wood and

Review Request 59536: CMake: Add SHA256 hash verification for 3rdparty downloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/ --- Review request for mesos, Aaron Wood and Joseph Wu. Repository: mesos

Re: Review Request 59500: Added Windows ReviewBot launch script.

> On May 23, 2017, 9:39 p.m., Mesos Reviewbot Windows wrote: > > Bad patch! > > > > Reviews applied: [59500] > > > > Failed command: python support/apply-reviews.py -n -r 59500 > > > > Error: > > error: support/mesos-reviewbot.ps1: already exists in index > > error: patch failed:

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175969 --- src/cli_new/lib/cli/tests/base.py Lines 51 (patched)

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review175967 --- bump - Eric Chung On May 11, 2017, 6:34 p.m., Eric Chung

Re: Review Request 53842: Add specific metrics for sorting runs across frameworks of a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53842/#review175966 --- Patch looks great! Reviews applied: [53840, 53841, 53842]

Re: Review Request 59463: Added test for agent ping timeout during agent recovery.

> On May 24, 2017, 1:27 a.m., Benjamin Mahler wrote: > > src/tests/slave_recovery_tests.cpp > > Lines 955 (patched) > > > > > > Rather than pausing, resuming and pausing again, have you tried leaving > > the clock

Re: Review Request 59463: Added test for agent ping timeout during agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59463/ --- (Updated May 24, 2017, 5:54 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp.

> On May 23, 2017, 10:50 p.m., James Peach wrote: > > src/tests/role_tests.cpp > > Line 909 (original), 909 (patched) > > > > > > I think this should be: > > ``` > > constexpr Bytes DISK_SIZE = Megabytes(1);

Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59454/ --- (Updated May 24, 2017, 5:53 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto.

> On May 24, 2017, 10:26 a.m., Jiang Yan Xu wrote: > > Hmm, is this also violating the convention then? > > > > https://github.com/apache/mesos/blob/d225d4d4122e773e2416ba0d0eee653da8ced352/include/mesos/authorizer/acls.proto#L344 > > > > What if later we use uncountable nouns? > > > > FWIW

Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59453/#review175959 --- Hmm, is this also violating the convention then?

Re: Review Request 59509: Fixed flakiness in MasterAllocatorTest.ResourcesUnused.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59509/#review175957 --- Ship it! LGTM! Can you update the description with details

Re: Review Request 58513: Remove unnecessary patch after protobuf upgrade to 3.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58513/ --- (Updated May 24, 2017, 4:16 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/ --- (Updated May 24, 2017, 8:47 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59141: Added new parameter 'data' to the URI fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59141/ --- (Updated May 24, 2017, 8:43 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175927 --- src/cli_new/lib/cli/tests/base.py Lines 356 (patched)

Re: Review Request 59509: Fixed flakiness in MasterAllocatorTest.ResourcesUnused.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59509/#review175926 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175925 --- src/cli_new/lib/cli/tests/base.py Lines 269 (patched)

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/ --- (Updated May 24, 2017, 3:32 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 59101: Enabled authorization for v1 API call GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59101/ --- (Updated May 24, 2017, 3:29 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 24, 2017, 1:28 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 59100: Enabled authorization for v1 API call GET_MAINTENANCE_SCHEDULE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59100/ --- (Updated May 24, 2017, 3:25 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 59099: Enabled authorization for v1 API call UPDATE_MAINTENANCE_SCHEDULE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59099/ --- (Updated May 24, 2017, 3:22 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 58964: Added authorization support for operator endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58964/ --- (Updated May 24, 2017, 3:17 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 59074: Updated all tests that use Containerizer::launch(...).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59074/ --- (Updated May 24, 2017, 3:34 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 58905: Changed naming of Docker containers to the pre-0.23 scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58905/ --- (Updated May 24, 2017, 3:34 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59428/#review175915 --- Patch looks great! Reviews applied: [59504, 59428] Passed

Re: Review Request 55331: Added 'OCI' message into 'Image' message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55331/ --- (Updated May 24, 2017, 5:02 p.m.) Review request for mesos, Gilbert Song and

Review Request 59518: Added `StopSignal` field into `Configuration` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59518/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-6681

Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59453/ --- (Updated May 24, 2017, 10:12 a.m.) Review request for mesos, Adam B, Greg

Re: Review Request 59355: Optimized sorter performance with many inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59355/#review175908 --- Ship it! Ship It! - Michael Park On May 22, 2017, 11:30

Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59453/ --- (Updated May 24, 2017, 10:08 a.m.) Review request for mesos, Adam B, Greg

Re: Review Request 59484: Introduced `DRFSorter::Node::isLeaf()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59484/#review175906 --- src/master/allocator/sorter/drf/sorter.cpp Lines 102-108

Re: Review Request 59483: Replaced the sorter's notion of "activation" with a three-valued enum.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59483/#review175905 --- Ship it! Ship It! - Michael Park On May 22, 2017, 11:27

Re: Review Request 59383: Added benchmark for allocator perf with many suppressed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59383/#review175903 --- Fix it, then Ship it!

Re: Review Request 59500: Added Windows ReviewBot launch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59500/#review175902 --- Patch looks great! Reviews applied: [59500] Passed command:

Re: Review Request 59482: Added a new sorter test case, `HierarchicalIterationOrder`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59482/#review175901 --- Ship it! Ship It! - Michael Park On May 23, 2017, 1:15

Re: Review Request 59481: Added sorter test for allocation queries about inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59481/#review175900 --- Ship it! Ship It! - Michael Park On May 23, 2017, 1:15