Re: Review Request 59616: Add `six` python package in install_require.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59616/#review176287 --- Patch looks great! Reviews applied: [59616] Passed command:

Re: Review Request 53841: Added metrics for sorting in the role and quota sorters.

> On May 26, 2017, 4:56 p.m., Jiang Yan Xu wrote: > > For this and the next review, could you summarize how these metrics can be > > used to reason about the allocator/sorter's performance? > > > > I agree that conceptually we'd like something that tells us how well the > > (dirty or overall)

Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59583/#review176286 --- Patch looks great! Reviews applied: [59460, 59461, 59463, 59545,

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

> On May 23, 2017, 4:36 p.m., Andrei Budnik wrote: > > src/cli_new/lib/cli/tests/base.py > > Lines 321 (patched) > > > > > > return any(container["executor_id"] == self.flags["name"] for container > > in data) > >

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176282 --- src/cli_new/lib/cli/tests/base.py Lines 177-188 (patched)

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

> On May 7, 2017, 8:13 p.m., Kevin Klues wrote: > > src/cli_new/lib/cli/__init__.py > > Line 18 (original), 18 (patched) > > > > > > This should be called Mesos CLI module since the renaming. This > > shouldn't be

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/#review176284 --- Patch looks great! Reviews applied: [59294] Passed command:

Review Request 59634: Updated 'config.py' in the new Mesos CLI to take settings as parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59634/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

> On May 29, 2017, 10:24 p.m., Kevin Klues wrote: > > This is still failing for me after the rebase: > > ``` > > (mesos-cli) $ mesos > > Traceback (most recent call last): > > File "/scratch/klueska/projects/mesos/src/cli_new/bin/main.py", line 25, > > in > > import cli > > File

Re: Review Request 59628: Moved settings.py from bin to lib/cli in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59628/#review176280 --- This file does not below in here. It is something that should be

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176276 --- This is still failing for me after the rebase: ``` (mesos-cli) $

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

> On May 23, 2017, 6:30 p.m., Andrei Budnik wrote: > > src/cli_new/lib/cli/tests/base.py > > Lines 265 (patched) > > > > > > Is it possible to run multiple tasks? What will be in case of task-id > > collision? > >

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

> On May 24, 2017, 2:03 p.m., Andrei Budnik wrote: > > src/cli_new/lib/cli/tests/base.py > > Lines 269 (patched) > > > > > > Please, use Task.task_id instead of self.task_id: > > flags["name"] =

Re: Review Request 58137: Added 'mesos config show' command in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/#review176275 --- Fix it, then Ship it!

Re: Review Request 59616: Add `six` python package in install_require.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59616/#review176274 --- I agree with @benjamin. This is the improper fix for this

Re: Review Request 59632: Added 'python-six' to the list of build dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59632/#review176273 --- Ship it! Ship It! - Till Toenshoff On May 29, 2017, 7:13

Review Request 59632: Added 'python-six' to the list of build dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59632/ --- Review request for mesos. Bugs: MESOS-7584

Re: Review Request 58137: Added 'mesos config show' command in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/ --- (Updated May 29, 2017, 3:46 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 29, 2017, 3:27 p.m.) Review request for mesos and Kevin Klues.

Review Request 59628: Moved settings.py from bin to lib/cli in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59628/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 58719: CLI: Added utility functions related to HTTP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58719/#review176267 --- src/cli_new/lib/cli/http.py Lines 42 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176266 --- This needs rebasing after the changes in 59177 - Kevin Klues

Re: Review Request 58137: CLI: Added 'mesos config show' command to display the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/#review176265 --- Looks like this needs a rebase after the new `config.py` library

Re: Review Request 59177: CLI: Added Config class to manage the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59177/#review176264 --- Ship it! I am adding the JIRA issue, changing the summary

Re: Review Request 59177: CLI: Added Config class to manage the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59177/ --- (Updated May 29, 2017, 12:36 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 59616: Add `six` python package in install_require.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59616/#review176262 --- This looks like the wrong fix to me. Mesos does not depend on