Re: Review Request 60189: Prevented allocating non-capable agent resources to capable frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60189/#review178193 --- Fix it, then Ship it! src/master/allocator/mesos/hierarchical.

Re: Review Request 60041: Converted the resources to the "endpoint" format for V0 endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60041/#review178191 --- Ship it! Ship It! - Neil Conway On June 13, 2017, 8:43 a.m.,

Re: Review Request 60187: Converted the resources to the "endpoint" format for V1 endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60187/#review178192 --- Ship it! Ship It! - Neil Conway On June 19, 2017, 6:39 a.m.,

Re: Review Request 60070: Adjusted the agent to the new resources format [11/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60070/#review178190 --- src/master/master.cpp Line 7308 (original), 7308 (patched)

Review Request 60190: Added the agent `RESERVATION_REFINEMENT` capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60190/ --- Review request for mesos, Benjamin Mahler and Neil Conway. Repository: mesos

Review Request 60189: Prevented allocating non-capable agent resources to capable frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60189/ --- Review request for mesos, Benjamin Mahler and Neil Conway. Repository: mesos

Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60069/#review178189 --- Ship it! Ship It! - Neil Conway On June 14, 2017, 9:56 a.m.,

Re: Review Request 60040: Resources: Adjusted `parse` to produce the new resource format [6/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60040/#review178188 --- Ship it! Ship It! - Neil Conway On June 13, 2017, 8:42 a.m.,

Review Request 60187: Converted the resources to the "endpoint" format for V1 endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60187/ --- Review request for mesos, Benjamin Mahler and Neil Conway. Bugs: MESOS-7679

Re: Review Request 60017: Resources: Adjusted the utilities to the new resource format [5/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60017/#review178187 --- Fix it, then Ship it! src/common/resources.cpp Line 1501 (orig

Re: Review Request 60185: Adjusted the master validation to the new resource format [9/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60185/#review178186 --- Ship it! Ship It! - Neil Conway On June 19, 2017, 6:19 a.m.,

Review Request 60185: Adjusted the master validation to the new resource format [9/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60185/ --- Review request for mesos and Neil Conway. Repository: mesos Description -

Re: Review Request 60182: Resources: Adjusted the predicates to the new resource format [2/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60182/#review178184 --- Fix it, then Ship it! Ship It! include/mesos/resources.hpp Li

Re: Review Request 60184: Resources: Adjusted the `operator<<` to the new resource format [4/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60184/#review178185 --- Ship it! Ship It! - Neil Conway On June 19, 2017, 5:26 a.m.,

Re: Review Request 60016: Resources: Adjusted the comparators to new resource format [3/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60016/#review178183 --- Ship it! Ship It! - Neil Conway On June 13, 2017, 8:35 a.m.,

Re: Review Request 60017: Resources: Adjusted the utilities to the new resource format [5/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60017/#review178182 --- src/common/resources.cpp Line 1551 (original), 1556 (patched)

Re: Review Request 60040: Resources: Adjusted `parse` to produce the new resource format [6/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60040/#review178181 --- src/common/resources.cpp Line 683 (original), 693 (patched)

Review Request 60184: Resources: Adjusted the `operator<<` to the new resource format [4/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60184/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7655 https://issues.a

Review Request 60182: Resources: Adjusted the predicates to the new resource format [2/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60182/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7655 https://issues.a

Re: Review Request 60181: Resources: Updated the comment to mention the resource format [1/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60181/#review178178 --- Ship it! Ship It! - Neil Conway On June 19, 2017, 5:17 a.m.,

Re: Review Request 60015: Introduced a utility function `Resources::reservationRole`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60015/#review178177 --- Ship it! src/common/resources.cpp Line 1041 (original), 1041 (

Review Request 60181: Resources: Updated the comment to mention the resource format [1/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60181/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7655 https://issues.a

Re: Review Request 60036: Avoided exposing `role` in JSON for resources with refined reservations.

> On June 18, 2017, 6:46 p.m., Neil Conway wrote: > > src/common/http.cpp > > Lines 519 (patched) > > > > > > Backticks not double quotes? Eh... I'm referring to fields in a JSON object here, I feel like double-quot

Re: Review Request 60178: Added test for endpoint resource format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60178/ --- (Updated June 19, 2017, 1:40 a.m.) Review request for mesos and Michael Park.

Re: Review Request 60036: Avoided exposing `role` in JSON for resources with refined reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60036/#review178172 --- Tests, can do later. src/common/http.hpp Lines 131 (patched)

Re: Review Request 60036: Avoided exposing `role` in JSON for resources with refined reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60036/#review178173 --- Ship it! Ship It! - Neil Conway On June 15, 2017, 7:39 a.m.,

Re: Review Request 60022: Introduced `convertResourceFormat` to convert between resource formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60022/#review178170 --- src/common/resources_utils.hpp Lines 61 (patched)

Review Request 60179: Introduced a utility function `Resources::hasRefinedReservations`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60179/ --- Review request for mesos. Repository: mesos Description --- Introduced a

Re: Review Request 60178: Added test for endpoint resource format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60178/#review178171 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp Li

Re: Review Request 60178: Added test for endpoint resource format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60178/ --- (Updated June 19, 2017, 1:12 a.m.) Review request for mesos and Michael Park.

Re: Review Request 60174: Updated the resources validation logic to allow for the endpoint format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60174/#review178168 --- Ship it! Ship It! - Neil Conway On June 18, 2017, 10:02 p.m.

Review Request 60178: Added test for endpoint resource format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60178/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 60174: Updated the resources validation logic to allow for the endpoint format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60174/#review178165 --- In the commit message, can we explain why we need to update valida

Re: Review Request 60175: Introduced a utility function `Resources::hasRefinedReservations`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60175/#review178164 --- Ship it! Is it worth adding coverage of this to the tests? - N

Review Request 60175: Introduced a utility function `Resources::hasRefinedReservations`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60175/ --- Review request for mesos and Neil Conway. Repository: mesos Description -

Review Request 60174: Updated the resources validation logic to allow for the endpoint format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60174/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7655 https://issues.a

Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59454/#review178163 --- Ship it! lgtm, although I'll change the commit message -- there

Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59989/ --- (Updated June 18, 2017, 8:43 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 59988: Added a new protobuf message `MapMessage` for protobuf tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59988/ --- (Updated June 18, 2017, 8:42 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 59987: Added protobuf map support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ --- (Updated June 18, 2017, 8:42 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 59988: Added a new protobuf message `MapMessage` for protobuf tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59988/ --- (Updated June 18, 2017, 8:40 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 59987: Added protobuf map support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ --- (Updated June 18, 2017, 8:39 p.m.) Review request for mesos, Anand Mazumdar and