Re: Review Request 61149: Added Future::condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61149/#review181641 --- 3rdparty/libprocess/include/process/future.hpp Lines 155-156

Re: Review Request 55318: Used loop in PollSocketImpl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55318/#review181640 --- 3rdparty/libprocess/src/poll_socket.cpp Lines 192-197

Re: Review Request 61123: Added regression test for sandbox volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61123/ --- (Updated July 27, 2017, 6:47 p.m.) Review request for mesos, Ilya Pronin, Jie

Re: Review Request 61123: Added regression test for host volume ownership issue.

> On July 26, 2017, 11:08 a.m., Ilya Pronin wrote: > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > > Lines 252-255 (patched) > > > > > > Why do we need Docker for this test? The problem should be

Re: Review Request 61122: Fixed the sandbox volume relative host path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61122/ --- (Updated July 27, 2017, 6:44 p.m.) Review request for mesos, Ilya Pronin, Jie

Re: Review Request 61122: Fixed the host volume relative host path ownership.

> On July 25, 2017, 4:26 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Line 487 (original), 498 (patched) > > > > > > This is sandbox volume, not host volume. Let's change

Re: Review Request 61121: Added regression test for sandbox_path volume ownership issue.

> On July 26, 2017, 9:45 a.m., James Peach wrote: > > src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp > > Lines 187 (patched) > > > > > > Maybe simplify this (here and above): > > ``` > >

Re: Review Request 61121: Added regression test for sandbox_path volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61121/ --- (Updated July 27, 2017, 6:43 p.m.) Review request for mesos, Greg Mann, Ilya

Re: Review Request 61120: Fixed the sandbox_path volume source path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61120/ --- (Updated July 27, 2017, 6:42 p.m.) Review request for mesos, Greg Mann, Ilya

Re: Review Request 55317: Used loop in SocketImpl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55317/#review181636 --- Ship it! Some more description here would be great, i.e. is

Re: Review Request 55315: Bug fixes from failing to hold onto PollSocketImpl reference.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55315/#review181635 --- Fix it, then Ship it! Could you also clarify what the bugs

Re: Review Request 61097: Added gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61097/ --- (Updated July 28, 2017, 1:09 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 61098: Added unit tests for gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61098/ --- (Updated July 28, 2017, 12:49 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 61097: Added gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61097/ --- (Updated July 28, 2017, 12:49 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60558/#review181634 --- src/docker/docker.cpp Lines 755 (patched)

Re: Review Request 60600: Set container DNS with `--default_container_dns` in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60600/#review181633 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 60784: Fixed a bug in operator== for DiskInfo::Source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60784/#review181632 --- Ship it! I spent a while trying to come up with a good test

Re: Review Request 60793: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60793/#review181630 --- src/tests/containerizer/cni_isolator_tests.cpp Lines 1226

Re: Review Request 60761: Added a test `DockerContainerizerTest.ROOT_DOCKER_DefaultDNS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60761/#review181628 --- Fix it, then Ship it! Ship It!

Re: Review Request 60760: Parsed DNS related info from the output of `docker inspect`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60760/#review181627 --- Ship it! Ship It! - Avinash sridharan On July 11, 2017,

Review Request 61198: Added explicit EventQueue::Producer/Consumer interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61198/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/ --- (Updated July 27, 2017, 5:30 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 61075: Set container DNS with `--default_container_dns` in DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61075/#review181626 --- Fix it, then Ship it! Ship It!

Re: Review Request 61171: Enabled filtering of the 'GET_AGENTS' v1 API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61171/#review181618 --- Looking good; one small comment below to consider. We should

Re: Review Request 61098: Added unit tests for gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61098/ --- (Updated July 27, 2017, 10:26 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 61097: Added gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61097/ --- (Updated July 27, 2017, 10:24 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 61097: Added gRPC support in libprocess.

> On July 26, 2017, 10:49 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 101 (patched) > > > > > > s/method/stub/ > > > > I'd also restructure this a bit (indentation for

Re: Review Request 61194: Updated the docs for V1 Events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61194/ --- (Updated July 27, 2017, 10:18 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 61194: Updated the docs for V1 Events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61194/#review181621 --- Also, did you verify that this renders fine on markdown? - Anand

Re: Review Request 61194: Updated the docs for V1 Events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61194/#review181620 --- Fix it, then Ship it! docs/operator-http-api.md Lines 2479

Review Request 61194: Updated the docs for V1 Events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61194/ --- Review request for mesos, Anand Mazumdar and Greg Mann. Bugs: MESOS-7246

Review Request 61193: Convert resource format for completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61193/ --- Review request for mesos, Adam B and Michael Park. Bugs: MESOS-7831

Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, and Greg Mann.

Re: Review Request 60931: Added test cases for framework streaming events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60931/ --- (Updated July 27, 2017, 6:24 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60929: Added 'FRAMEWORK_UPDATED' event for master streaming api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60929/ --- (Updated July 27, 2017, 6:23 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59960: Add data structures and stats/control helpers for the Blkio cgroup subsystem

> On July 21, 2017, 4:48 p.m., James Peach wrote: > > src/linux/cgroups.hpp > > Lines 442 (patched) > > > > > > Can we come up with a better name than `Entry`? I think that this is a > > per-device sample, so

Re: Review Request 60928: Added 'FRAMEWORK_ADDED' event for master streaming api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60928/#review181593 --- Ship it! Ship It! - Anand Mazumdar On July 25, 2017, 8:24

Re: Review Request 60929: Added 'FRAMEWORK_UPDATED' event for master streaming api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60929/#review181589 --- Fix it, then Ship it! include/mesos/master/master.proto Lines

Re: Review Request 60930: Added 'FRAMEWORK_REMOVED' event for master streaming api.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60930/#review181587 --- Ship it! Ship It! - Anand Mazumdar On July 18, 2017, 12:23

Re: Review Request 60931: Added test cases for framework streaming events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60931/#review181586 --- Fix it, then Ship it! Just some minor nits to fix.

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review181574 --- Patch looks great! Reviews applied: [61179, 61180, 61181, 61182,

Review Request 61181: Stored subscribed resources in resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61181/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-7837

Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Review Request 61180: Added a resource providers total resources to the subscribe call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61180/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-7837

Review Request 61179: Added 'devolve' overload for 'ResourceProviderID'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61179/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONOptionalEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/#review181543 --- Patch looks great! Reviews applied: [61109, 61174] Passed

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review181537 --- Patch looks great! Reviews applied: [61172] Passed command:

Re: Review Request 61109: Used the default value when parsing an optional enum field.

> On July 26, 2017, 12:01 a.m., James Peach wrote: > > Could you construct a test for this by parsing a JSON object with a made-up > > enum value? Sure, here it is: https://reviews.apache.org/r/61174/ - Qian --- This is an

Review Request 61174: Added a test `ProtobufTest.ParseJSONOptionalEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/ --- Review request for mesos, Benjamin Mahler and James Peach. Bugs: MESOS-7828

Re: Review Request 61171: Enabled filtering of the 'GET_AGENTS' v1 API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61171/ --- (Updated July 27, 2017, 9:48 a.m.) Review request for mesos, Adam B, Greg

Re: Review Request 61171: Enabled filtering of the 'GET_AGENTS' v1 API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61171/#review181536 --- Patch looks great! Reviews applied: [61171] Passed command:

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated July 27, 2017, 7:09 a.m.) Review request for mesos, Armand Grillet,

Review Request 61171: Enabled filtering of the 'GET_AGENTS' v1 API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61171/ --- Review request for mesos, Adam B, Greg Mann, Quinn Leng, and Till Toenshoff.

Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- Review request for mesos. Repository: mesos Description --- Added