Re: Review Request 62230: Avoid GC pruning events from blocking other processes.

2017-09-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62230/ --- (Updated Sept. 12, 2017, 2:37 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

2017-09-11 Thread James Peach
> On Sept. 6, 2017, 1 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1051-1052 (patched) > > > > > > Can you please elaborate a bit about this? What do you mean for `the > >

Re: Review Request 62047: Allowed look up latest executor directory by virtual path.

2017-09-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62047/ --- (Updated Sept. 11, 2017, 11:18 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62047: Allowed look up latest executor directory by virtual path.

2017-09-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62047/ --- (Updated Sept. 11, 2017, 11:17 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62040: Also log attached virtual path in agent.

2017-09-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62040/ --- (Updated Sept. 11, 2017, 11:16 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62230: Avoid GC pruning events from blocking other processes.

2017-09-11 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62230/#review185123 --- src/slave/gc.cpp Lines 231 (patched)

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

2017-09-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/#review185122 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Review Request 62230: Avoid GC pruning events from blocking other processes.

2017-09-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62230/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Jiang Yan Xu. Bugs:

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-09-11 Thread Megha Sharma
> On Aug. 30, 2017, 1:05 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 8948-8950 (patched) > > > > > > If the framework is not partition aware, the `update` will already have > > a `TASK_LOST`

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-09-11 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Sept. 11, 2017, 9:23 p.m.) Review request for mesos, Vinod Kone and

Re: Review Request 62214: Added JavaScript linter.

2017-09-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review185102 --- Can you add Kevin Klues to the review and ask him to take a look

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

2017-09-11 Thread James Peach
> On Sept. 6, 2017, 1 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1051-1052 (patched) > > > > > > Can you please elaborate a bit about this? What do you mean for `the > >

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-11 Thread James Peach
> On Sept. 8, 2017, 7:43 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Line 112 (original), 112 (patched) > > > > > > Why do we need a `for` loop like this? I think

Re: Review Request 62214: Added JavaScript linter.

2017-09-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review185080 --- FAIL: Some Mesos tests failed. Please check

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

2017-09-11 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/ --- (Updated Sept. 11, 2017, 2:59 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62018: Updated logging::initialize to make flags optional.

2017-09-11 Thread Armand Grillet
> On Sept. 8, 2017, 12:30 p.m., Andrei Budnik wrote: > > src/logging/logging.cpp > > Line 156 (original), 165 (patched) > > > > > > What will be the value of `FLAGS_logtostderr` if `_flags` is `None`? > > Does it

Re: Review Request 62213: Send TASK_STARTING from the built-in executors. [2/2]

2017-09-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/#review185065 --- FAIL: Some Mesos tests failed. Please check

Review Request 62214: Added JavaScript linter.

2017-09-11 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7924

Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-11 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/ --- Review request for mesos, Andrei Budnik and Alexander Rukletsov. Bugs:

Review Request 62213: Send TASK_STARTING from the built-in executors. [2/2]

2017-09-11 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/ --- Review request for mesos, Andrei Budnik and Alexander Rukletsov. Bugs: