Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Sept. 21, 2017, 4:27 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Sept. 21, 2017, 4:23 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 62447: Revert usage of `-isystem` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/#review185844 --- Bad patch! Reviews applied: [62447, 62446, 62445, 62444, 62161,

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONOptionalEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/#review185843 --- PASS: Mesos patch 61174 was successfully built and tested.

Re: Review Request 62434: Fixed horizontal ellipsis in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62434/#review185842 --- Ship it! Ship It! - Gastón Kleiman On Sept. 20, 2017, 10:32

Re: Review Request 62434: Fixed horizontal ellipsis in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62434/#review185841 --- Patch looks great! Reviews applied: [62434] Passed command:

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONOptionalEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/ --- (Updated Sept. 21, 2017, 9:59 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 61109: Used the default value when parsing an optional enum field from JSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61109/ --- (Updated Sept. 21, 2017, 9:58 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 61109: Used the default value when parsing an optional enum field.

> On Sept. 9, 2017, 7:59 a.m., James Peach wrote: > > This looks pretty reasonable to me. It's unfortunate that this will convert > > all invalid enum names into the default value, but AFAICT that is > > unavoidable. > > Benjamin Mahler wrote: > Since we're talking about optional enums,

Re: Review Request 62418: Removed unneeded configure step in mesos-tidy Docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62418/#review185838 --- Patch looks great! Reviews applied: [62417, 62418] Passed

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review185831 --- Patch looks great! Reviews applied: [62105, 62106, 62176]

Re: Review Request 62443: Initialized tests with Google Mock initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62443/#review185826 --- Ship it! Ship It! - Andrew Schwartzmeyer On Sept. 20, 2017,

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185695 --- src/master/registry.proto Lines 116 (patched)

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review185816 --- src/slave/slave.cpp Lines 1272-1285 (patched)

Re: Review Request 62252: Added `process::Executor::execute()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62252/#review185814 --- 3rdparty/libprocess/include/process/executor.hpp Lines 71

Re: Review Request 62443: Initialized tests with Google Mock initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62443/#review185813 --- Ship it! Ship It! - Greg Mann On Sept. 20, 2017, 6:13 p.m.,

Re: Review Request 61109: Used the default value when parsing an optional enum field.

> On Sept. 8, 2017, 11:59 p.m., James Peach wrote: > > This looks pretty reasonable to me. It's unfortunate that this will convert > > all invalid enum names into the default value, but AFAICT that is > > unavoidable. > > Benjamin Mahler wrote: > Since we're talking about optional enums,

Re: Review Request 62447: Revert usage of `-isystem` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/#review185806 --- FAIL: Failed to apply the dependent review: 62161. Failed

Re: Review Request 62447: Revert usage of `-isystem` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/#review185805 --- It looks like the problem is `-isystem /usr/include` according to

Review Request 62446: Additional check when building with java bindings enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62446/ --- Review request for mesos. Repository: mesos Description --- Check

Review Request 62447: Revert usage of `-isystem` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/ --- Review request for mesos. Repository: mesos Description --- This flag

Review Request 62445: Remove duplicate block in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62445/ --- Review request for mesos. Repository: mesos Description --- This blocks

Review Request 62444: Add UNREACHABLE() macro to __cxa_pure_virtual.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62444/ --- Review request for mesos. Repository: mesos Description --- The

Re: Review Request 62160: Fix stout build with newer boost versions.

> On Sept. 19, 2017, 7:39 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/tests/json_tests.cpp > > Lines 358-359 (original) > > > > > > Since the code here was weird even before, it seems that we should > > change

Re: Review Request 62443: Initialized tests with Google Mock initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62443/#review185802 --- Bad review! Error: No reviewers specified. Please find a

Review Request 62443: Initialized tests with Google Mock initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62443/ --- Review request for mesos. Bugs: MESOS-7987

Re: Review Request 62439: Used a namespace alias for 'process::http'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62439/#review185794 --- Fix it, then Ship it! src/slave/slave.cpp Lines 155-156

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/ --- (Updated Sept. 20, 2017, 4:24 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

> On Sept. 19, 2017, 12:03 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6669 (patched) > > > > > > add a `break` for the first level switch? and a default? I added a `break` here. I did not add a

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 20, 2017, 4:24 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 62438: Ignored redundant agent resources updates in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62438/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Review Request 62439: Used a namespace alias for 'process::http'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62439/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 62158: Rescinded offers possibly affected by updates to agent total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/ --- (Updated Sept. 20, 2017, 4:24 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62434: Fixed horizontal ellipsis in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62434/#review185789 --- PASS: Mesos patch 62434 was successfully built and tested.

Review Request 62434: Fixed horizontal ellipsis in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62434/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7978

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 19, 2017, 2:13 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 437 (patched) > > > > > > I think we need to introduce a new reason > >