Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186048 --- Fix it, then Ship it! src/tests/resource_provider_manager_test

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/#review186047 --- Fix it, then Ship it! src/tests/resource_provider_manager_test

Re: Review Request 62512: Disabled RestartSlaveRequireExecutorAuthentication test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62512/#review186046 --- Patch looks great! Reviews applied: [62508, 62509, 62510, 62511,

Re: Review Request 62168: Added a test using a file URI and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62168/#review186044 --- Patch looks great! Reviews applied: [62197, 61982, 62042, 62168]

Re: Review Request 62518: Fixed default executor handling of nested container status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62518/#review186043 --- PASS: Mesos patch 62518 was successfully built and tested. Review

Re: Review Request 62507: Added documentation about 'MARK_AGENT_GONE' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62507/#review186039 --- Patch looks great! Reviews applied: [62475, 62476, 62477, 62478,

Review Request 62518: Fixed default executor handling of nested container status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62518/ --- Review request for mesos, Andrei Budnik and Anand Mazumdar. Repository: mesos

Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59989/#review186037 --- 3rdparty/stout/tests/protobuf_tests.cpp Lines 607 (patched)

Re: Review Request 59988: Added a new protobuf message `MapMessage` for protobuf tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59988/#review186036 --- 3rdparty/stout/tests/protobuf_tests.proto Lines 102 (patched)

Re: Review Request 59987: Added protobuf map support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/#review186035 --- 3rdparty/stout/include/stout/protobuf.hpp Lines 433 (patched)

Re: Review Request 59987: Added protobuf map support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/#review186031 --- 3rdparty/stout/include/stout/protobuf.hpp Lines 413 (patched)

Re: Review Request 62512: Disabled RestartSlaveRequireExecutorAuthentication test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62512/#review186030 --- PASS: Mesos patch 62512 was successfully built and tested. Review

Re: Review Request 62502: Added PUBLISH and UNPUBLISH events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review186020 --- include/mesos/resource_provider/resource_provider.proto Lines 55

Re: Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62509/#review186019 --- PASS: Mesos patch 62509 was successfully built and tested. Review

Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1 Master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62475/#review186012 --- include/mesos/master/master.proto Lines 202 (patched)

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186016 --- Patch looks great! Reviews applied: [62282, 58048, 62158, 62438,

Re: Review Request 62168: Added a test using a file URI and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62168/#review186015 --- FAIL: Failed to apply the dependent review: 62197. Failed command

Re: Review Request 62507: Added documentation about 'MARK_AGENT_GONE' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62507/#review186013 --- FAIL: Some Mesos tests failed. Reviews applied: `['62475', '62476

Re: Review Request 62512: Disabled RestartSlaveRequireExecutorAuthentication test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62512/ --- (Updated Sept. 22, 2017, 12:52 p.m.) Review request for mesos, John Kordich, Jo

Review Request 62512: Disabled RestartSlaveRequireExecutorAuthentication test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62512/ --- Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff. Bugs: ME

Re: Review Request 62502: Added PUBLISH and UNPUBLISH events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review186007 --- include/mesos/resource_provider/resource_provider.proto Lines 56

Re: Review Request 62168: Added a test using a file URI and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62168/#review186006 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp Lin

Review Request 62511: Fixed OpenSSL support in libprocess for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62511/ --- Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff. Bugs: ME

Review Request 62510: Fixed `LibeventSSLSocketImpl` for Windows file descriptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62510/ --- Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff. Bugs: ME

Review Request 62509: Added `intptr_t` constructor for `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62509/ --- Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff. Bugs: ME

Review Request 62508: Fixed ordering of Windows system headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62508/ --- Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff. Bugs: ME

Review Request 62168: Added a test using a file URI and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62168/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-7916 https:

Review Request 62507: Added documentation about 'MARK_AGENT_GONE' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62507/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-8007 https://issues.ap

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185993 --- FAIL: Failed to apply the dependent review: 62282. Failed command

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

> On Sept. 22, 2017, 2:17 a.m., Jie Yu wrote: > > src/resource_provider/registrar.cpp > > Lines 134 (patched) > > > > > > Instead of wrapping a lot of `#ifndef` in the agent code, i'd suggest > > we use the memory b

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

> On Sept. 22, 2017, 2:29 a.m., Jie Yu wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 408 (patched) > > > > > > This does not build on WINDOWS. I suggest we use in memory storage so > > that we c

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Sept. 22, 2017, 5:03 p.m.) Review request for mesos, Jie Yu and Jan Sc

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/ --- (Updated Sept. 22, 2017, 5:03 p.m.) Review request for mesos, Jie Yu and Jan Sc

Re: Review Request 62438: Ignored redundant agent resources updates in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62438/ --- (Updated Sept. 22, 2017, 5:03 p.m.) Review request for mesos, Jie Yu and Jan Sc

Re: Review Request 62502: Added PUBLISH and UNPUBLISH events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review185989 --- PASS: Mesos patch 62502 was successfully built and tested. Review

Re: Review Request 62066: Updated pylint to ignore errors for 'similar' imports across files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62066/#review185984 --- Ship it! Ship It! - Kevin Klues On Sept. 22, 2017, 12:47 p.m

Re: Review Request 61210: Renamed constants for CLI tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61210/#review185983 --- Ship it! Ship It! - Kevin Klues On Sept. 3, 2017, 8:34 a.m.,

Re: Review Request 60900: Updated Python linter to work with multiple directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60900/#review185982 --- Ship it! Ship It! - Kevin Klues On July 29, 2017, 2:15 p.m.,

Re: Review Request 62502: Added PUBLISH and UNPUBLISH events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review185980 --- Patch looks great! Reviews applied: [62502] Passed command: expo

Re: Review Request 62066: Updated pylint to ignore errors for 'similar' imports across files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62066/ --- (Updated Sept. 22, 2017, 12:47 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 61212: Added CLI utility functions to check IPs and ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61212/#review185977 --- src/python/cli_new/lib/cli/util.py Lines 158 (patched)

Review Request 62502: Added PUBLISH and UNPUBLISH events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu. Reposi