Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-28 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kapil Arya.

Review Request 62663: Updated maximum acceptable number of similar lines in Python files.

2017-09-28 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62663/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti

Re: Review Request 62663: Updated maximum acceptable number of similar lines in Python files.

2017-09-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62663/#review186552 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 28, 2017, 1

Re: Review Request 62518: Fixed default executor handling of nested container status.

2017-09-28 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62518/#review186553 --- Ship it! Ship It! - Andrei Budnik On Sept. 25, 2017, 3:21 p.

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186554 --- PASS: Mesos patch 62661 was successfully built and tested. Review

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-28 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62381/#review186559 --- src/docker/executor.cpp Line 609 (original)

Re: Review Request 62587: Added HTTP authenticatee interface definition.

2017-09-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62587/#review186390 --- include/mesos/authentication/http/authenticatee.hpp Lines 32-33 (

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186569 --- configure.ac Lines 239 (patched)

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-28 Thread Andrei Budnik
> On Sept. 28, 2017, 5:22 p.m., Benjamin Bannier wrote: > > configure.ac > > Lines 239 (patched) > > > > > > Let's call this `libtool-wrappers` to match what we use in the code (it > > also refers to multiple wrappe

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-28 Thread Gaston Kleiman
> On Sept. 19, 2017, 4:13 p.m., Gaston Kleiman wrote: > > src/tests/health_check_tests.cpp > > Lines 1121 (patched) > > > > > > I think that we have to use `TEST_F_TEMP_DISABLED_ON_WINDOWS` here. > > Andrei Budnik

Re: Review Request 62655: Made 'UpdateSlaveMessage' a union of possible updates.

2017-09-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62655/#review186600 --- Fix it, then Ship it! LGTM! src/master/master.cpp Lines 6765

Re: Review Request 62158: Rescinded offers possibly affected by updates to agent total resources.

2017-09-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/#review186601 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2017, 6:42 a.m., Ben

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186603 --- PASS: Mesos patch 62661 was successfully built and tested. Review

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-09-28 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review186580 --- src/master/master.hpp Line 849 (original), 849 (patched)

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

2017-09-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review186609 --- PASS: Mesos patch 62638 was successfully built and tested. Review

Re: Review Request 61109: Used the default value when parsing an optional enum field from JSON.

2017-09-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61109/ --- (Updated Sept. 29, 2017, 8:24 a.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONOptionalEnum`.

2017-09-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/ --- (Updated Sept. 29, 2017, 8:26 a.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 62616: Binary packaging for Centos 7.

2017-09-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186623 --- Patch looks great! Reviews applied: [62616] Passed command: expo

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

2017-09-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review186632 --- src/slave/slave.cpp Line 1278 (original), 1287 (patched)

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONOptionalEnum`.

2017-09-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/#review186637 --- PASS: Mesos patch 61174 was successfully built and tested. Review

Re: Review Request 62326: Always send TASK_KILLED when the task is killed.

2017-09-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62326/ --- (Updated Sept. 29, 2017, 2:55 p.m.) Review request for mesos, Anand Mazumdar an