Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

> On Dec. 22, 2017, 3:55 p.m., Jie Yu wrote: > > @gilbert, @zhitao, is this a 1.5.0 blocker? Do we want to land this? yes, but we still have one small issue to address. I will cherrypick it to the 1.5.x branch. thanks! - Gilbert ---

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review194469 --- src/slave/http.cpp Lines 2452 (patched)

Review Request 64823: Documented the change in the Protobuf requirement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64823/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Qian Zhang.

Re: Review Request 64822: Made protobuf version 3+ a hard requirement for building Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64822/#review194467 --- Ship it! Ship It! - Jie Yu On Dec. 22, 2017, 11:56 p.m.,

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review194466 --- @gilbert, @zhitao, is this a 1.5.0 blocker? Do we want to land

Review Request 64822: Made protobuf version 3+ a hard requirement for building Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64822/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 64818: Fixed compile error for `make distcheck`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64818/#review194465 --- Ship it! Ship It! - Jie Yu On Dec. 22, 2017, 11:35 p.m.,

Review Request 64818: Fixed compile error for `make distcheck`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64818/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 64814: Renamed isCommandExecutor to isGeneratedForCommandTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64814/#review194464 --- Ship it! Ship It! - Chun-Hung Hsiao On Dec. 22, 2017, 9:22

Re: Review Request 64793: Fixed a bug where resource over allocation may break quota headroom.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64793/#review194463 --- Fix it, then Ship it! Hm.. technically the reservation might

Re: Review Request 64806: Fixed resource provider driver disconnection handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64806/#review194462 --- src/resource_provider/http_connection.hpp Lines 167 (patched)

Re: Review Request 64798: Added an utility to shrink scalar resource while keeping its meta-data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64798/#review194460 --- Ship it! src/common/resources.cpp Lines 1261 (patched)

Review Request 64814: Renamed isCommandExecutor to isGeneratedForCommandTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64814/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Re: Review Request 64811: Cleaned up ContainerInfo generation logic in the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64811/#review194457 --- PASS: Mesos patch 64811 was successfully built and tested.

Re: Review Request 64811: Cleaned up ContainerInfo generation logic in the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64811/#review194456 --- Ship it! Ship It! - Chun-Hung Hsiao On Dec. 22, 2017, 7:47

Re: Review Request 64813: Documented new image gc support in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64813/ --- (Updated Dec. 22, 2017, 8:21 p.m.) Review request for mesos, Gilbert Song and

Review Request 64813: Documented new image gc support in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64813/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-8310

Review Request 64812: Added `excluded_images` parameter to `PRUNE_IMAGES` agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64812/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4945

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/ --- (Updated Dec. 22, 2017, 8:10 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 63598: Set container info from executor by default if available.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63598/#review194455 --- Ship it! Ship It! - Chun-Hung Hsiao On Nov. 8, 2017, 1:03

Review Request 64811: Cleaned up ContainerInfo generation logic in the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64811/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Bugs: MESOS-7007

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/ --- (Updated Dec. 22, 2017, 6:41 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/#review194452 --- Ship it! Ship It! - Michael Park On Dec. 22, 2017, 5:42

Re: Review Request 64770: Fixed a potential race condition in the test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64770/#review194441 --- PASS: Mesos patch 64770 was successfully built and tested.

Re: Review Request 64810: Fixed clang build on e.g., ubuntu16.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64810/#review194440 --- Ship it! Ship It! - Alexander Rukletsov On Dec. 22, 2017,

Review Request 64810: Fixed clang build on e.g., ubuntu16.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64810/ --- Review request for mesos, Alexander Rukletsov, Armand Grillet, and Ilya Pronin.

Re: Review Request 64770: Fixed a potential race condition in the test infrastructure.

> On Dec. 22, 2017, 3:38 a.m., Greg Mann wrote: > > This looks like a reasonable solution to me. However, it would be great if > > we could reproduce the bug and then verify the fix. Looking at the log of a > > failed test run in the JIRA, it seems to me that the problem occurs when > >

Re: Review Request 64807: Removed redundant `struct` prefix in "linux/ns.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64807/#review194435 --- FAIL: Failed to apply the dependent review: 64686. Failed

Re: Review Request 64806: Fixed resource provider driver disconnection handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64806/#review194432 --- PASS: Mesos patch 64806 was successfully built and tested.

Re: Review Request 64685: Improved the comment around the union in ns::clone().

> On Dec. 22, 2017, 2:29 p.m., Benjamin Bannier wrote: > > src/linux/ns.cpp > > Line 320 (original), 320 (patched) > > > > > > Since you are at it, could you make the first part a full sentence, > > e.g., > >

Re: Review Request 64807: Removed redundant `struct` prefix in "linux/ns.cpp".

> On Dec. 22, 2017, 2:29 p.m., Benjamin Bannier wrote: > > src/linux/ns.cpp > > Line 184 (original), 184 (patched) > > > > > > Kill this `struct` as well? Not sure we can do this. There is also `stat()` POSIX

Re: Review Request 64807: Removed redundant `struct` prefix in "linux/ns.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64807/#review194428 --- Fix it, then Ship it! src/linux/ns.cpp Line 184 (original),

Re: Review Request 64685: Improved the comment around the union in ns::clone().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64685/#review194427 --- Fix it, then Ship it! src/linux/ns.cpp Line 320 (original),

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/ --- (Updated Dec. 22, 2017, 1:42 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64685: Improved the comment around the union in ns::clone().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64685/ --- (Updated Dec. 22, 2017, 1:42 p.m.) Review request for mesos, Armand Grillet,

Review Request 64807: Removed redundant `struct` prefix in "linux/ns.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64807/ --- Review request for mesos, Benjamin Bannier and Michael Park. Repository: mesos

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

> On Dec. 21, 2017, 8 p.m., Benjamin Bannier wrote: > > src/linux/ns.cpp > > Line 397 (original), 397-399 (patched) > > > > > > Why do we put `struct` here? This is C++ (and the `memcpy` fits on a > > single line

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/ --- (Updated Dec. 22, 2017, 1:39 p.m.) Review request for mesos, Armand Grillet,

Review Request 64806: Fixed resource provider driver disconnection handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64806/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8349

Review Request 64805: Changed 'ConstantEndpointDetector' to have value semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64805/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 64798: Added an utility to shrink scalar resource while keeping its meta-data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64798/#review194421 --- PASS: Mesos patch 64798 was successfully built and tested.

Re: Review Request 64765: Removed a stale TODO in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64765/#review194420 --- PASS: Mesos patch 64765 was successfully built and tested.

Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64070/ --- (Updated Dec. 22, 2017, 11:08 a.m.) Review request for mesos, Andrei Budnik,