Re: Review Request 63991: Added helpers to create and forward offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63991/ --- (Updated March 2, 2018, 8:06 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 2, 2018, 8:07 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 2, 2018, 8:07 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/ --- (Updated March 2, 2018, 8:12 a.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198514 --- FAIL: Failed to apply the dependent review: 63989. Failed command

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/ --- (Updated March 2, 2018, 10:46 a.m.) Review request for mesos, Greg Mann, Jie Yu

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review198517 --- Patch looks great! Reviews applied: [65855, 65856, 65876] Passed

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/ --- (Updated March 2, 2018, 11:46 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

> On March 1, 2018, 2:57 p.m., Jan Schlicht wrote: > > Please add this to `v1/resources.cpp` as well. Done. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198447

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review198521 --- PASS: Mesos patch 64211 was successfully built and tested. Review

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198522 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65674/#review198523 --- PASS: Mesos patch 65674 was successfully built and tested. Review

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review198524 --- Patch looks great! Reviews applied: [65585, 65705, 64211] Passed

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

> On March 1, 2018, 11:24 p.m., Kevin Klues wrote: > > Looks like this had errors on the Windows CI? Following today's rebase, both CIs are successful. - Armand --- This is an automatically generated e-mail. To reply, visit: https://rev

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198526 --- Bad patch! Reviews applied: [63994, 63992, 63991, 63989, 63988]

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/ --- (Updated March 2, 2018, 3:15 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198531 --- Patch looks great! Reviews applied: [65838] Passed command: expo

Review Request 65886: Do not realpath executables from launcher_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65886/ --- Review request for mesos. Repository: mesos Description --- Mesos realpa

Re: Review Request 65886: Do not realpath executables from launcher_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65886/#review198537 --- PASS: Mesos patch 65886 was successfully built and tested. Review

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/#review198538 --- Ship it! Ship It! - Gilbert Song On March 2, 2018, 7:15 a.m.

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65674/#review198539 --- Patch looks great! Reviews applied: [65587, 65588, 65589, 65590,

Review Request 65887: Avoided orphan subprocess in the Docker library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65887/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. Bugs:

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/ --- (Updated March 2, 2018, 7:20 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 65886: Do not realpath executables from launcher_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65886/#review198542 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198546 --- Ship it! Ship It! - Chun-Hung Hsiao On March 2, 2018, 10:46

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated March 2, 2018, 7:40 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198547 --- src/common/resources.cpp Lines 936 (patched)

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated March 2, 2018, 7:41 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review198548 --- 3rdparty/stout/include/stout/path.hpp Lines 65 (patched)

Re: Review Request 65887: Avoided orphan subprocess in the Docker library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65887/#review198549 --- PASS: Mesos patch 65887 was successfully built and tested. Review

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review198552 --- PASS: Mesos patch 65812 was successfully built and tested. Review

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review198553 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review198554 --- Patch looks great! Reviews applied: [65855, 65856, 65876] Passed

Re: Review Request 63991: Added helpers to create and forward offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63991/#review198557 --- Fix it, then Ship it! src/common/protobuf_utils.hpp Lines 167

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review198558 --- Ship it! - Gaston Kleiman On March 2, 2018, 12:07 a.m., Greg

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198559 --- src/tests/scheduler_tests.cpp Lines 1045-1047 (patched)

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 2, 2018, 10:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 2, 2018, 10:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65887: Avoided orphan subprocess in the Docker library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65887/#review198561 --- Ship it! Ship It! - Gilbert Song On March 2, 2018, 11:07 a.m

Re: Review Request 63991: Added helpers to create and forward offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63991/ --- (Updated March 2, 2018, 10:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63991: Added helpers to create and forward offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63991/ --- (Updated March 2, 2018, 10:53 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65887: Avoided orphan subprocess in the Docker library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65887/#review198562 --- Ship it! Ship It! - Andrei Budnik On March 2, 2018, 7:07 p.m

Review Request 65890: Added used but not included header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65890/ --- Review request for mesos, Akash Gupta and Joseph Wu. Repository: mesos Descri

Review Request 65891: Windows: Fixed bug with CPU isolator not checking the max boundary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65891/ --- Review request for mesos, Akash Gupta and Joseph Wu. Repository: mesos Descri

Re: Review Request 65891: Windows: Fixed bug with CPU isolator not checking the max boundary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65891/ --- (Updated March 2, 2018, 3:21 p.m.) Review request for mesos, Akash Gupta and Jo

Re: Review Request 65868: Added inspect retries to the docker containerizer in `update` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65868/#review198564 --- Ship it! This is an improvement, but maybe we need to return a

Re: Review Request 65310: Added lambda::zip.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65310/#review198563 --- 3rdparty/stout/include/stout/lambda.hpp Line 22 (original), 22 (p

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198565 --- What's the status of this patch? - Andrew Schwartzmeyer On Jan.

Re: Review Request 65839: Windows: Removed stout W* signal macros in `windows.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65839/#review198566 --- Ship it! Ship It! - Andrew Schwartzmeyer On March 1, 2018, 1

Re: Review Request 65862: Windows: Removed signal macro in `checks/checker_process.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65862/#review198568 --- Ship it! Ship It! - Andrew Schwartzmeyer On March 1, 2018, 1

Re: Review Request 65861: Windows: Removed use of W* signal macros in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65861/#review198567 --- Ship it! Ship It! - Andrew Schwartzmeyer On March 1, 2018, 1

Re: Review Request 65840: Windows: Fixed remaining W* macros in `windows.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65840/#review198569 --- Fix it, then Ship it! 3rdparty/stout/include/stout/windows.hpp

Re: Review Request 65887: Avoided orphan subprocess in the Docker library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65887/#review198570 --- Patch looks great! Reviews applied: [65887] Passed command: expo

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198571 --- PASS: Mesos patch 63994 was successfully built and tested. Review

Re: Review Request 65890: Added used but not included header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65890/#review198573 --- Ship it! Ship It! - Akash Gupta On March 2, 2018, 11:16 p.m.

Re: Review Request 65891: Windows: Fixed bug with CPU isolator not checking the max boundary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65891/#review198574 --- Ship it! LGTM. Would want confirmation from Zihao - Akash Gupt

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65733/#review198575 --- Should we update the *bug*# to MESOS-8488? - Gilbert Song On Fe

Re: Review Request 65891: Windows: Fixed bug with CPU isolator not checking the max boundary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65891/#review198576 --- PASS: Mesos patch 65891 was successfully built and tested. Review

Re: Review Request 65840: Windows: Fixed remaining W* macros in `windows.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65840/ --- (Updated March 3, 2018, 1:16 a.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198577 --- PASS: Mesos patch 63862 was successfully built and tested. Review

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review198579 --- Patch looks great! Reviews applied: [65811, 65812] Passed comman

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198581 --- Patch looks great! Reviews applied: [63991, 63992, 63994] Passed