Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66844/ --- (Updated April 28, 2018, 12:44 a.m.) Review request for Benjamin Mahler, Gaston

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202099 --- PASS: Mesos patch 66858 was successfully built and tested. Review

Re: Review Request 66828: Introduced a push-based gauge metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66828/#review202095 --- Ship it! Ship It! - Gilbert Song On April 26, 2018, 2:54 p.m

Re: Review Request 66831: Renamed Gauge to PullGauge and documented differences to PushGauge.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66831/#review202097 --- Ship it! Ship It! - Gilbert Song On April 26, 2018, 2:54 p.m

Re: Review Request 66832: Updated mesos source for Gauge -> PullGauge renaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66832/#review202098 --- Ship it! Ship It! - Gilbert Song On April 26, 2018, 2:54 p.m

Re: Review Request 66830: Added a test for PushGauge.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66830/#review202096 --- Ship it! Ship It! - Gilbert Song On April 26, 2018, 2:54 p.m

Re: Review Request 66831: Renamed Gauge to PullGauge and documented differences to PushGauge.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66831/#review202094 --- 3rdparty/libprocess/include/Makefile.am Line 50 (original), 49-50

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 24, 2018, 9:05 p.m., Chun-Hung Hsiao wrote: > > src/master/validation.cpp > > Lines 2332 (patched) > > > > > > Can you add tests for this function in > > `src/tests/master_validation_tests.cpp`? To unbl

Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-4945 h

Re: Review Request 66438: Windows: Made `libevent` use `int_fd` correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66438/ --- (Updated April 27, 2018, 1:50 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66811: Added `libacl` as a dependency of stout.

> On April 27, 2018, 3:04 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 288 (patched) > > > > > > This file should not be committed together with the changes to stout > > (project split). Why

Re: Review Request 66843: Added 'FrameworkMetrics' to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66843/ --- (Updated April 27, 2018, 8:42 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66531: Added new authorization for `ResizeVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66531/ --- (Updated April 27, 2018, 1:14 p.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/ --- (Updated April 27, 2018, 1:09 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/ --- (Updated April 27, 2018, 1:08 p.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 25, 2018, 9:09 a.m., Greg Mann wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 451 (patched) > > > > > > It's not 100% clear to me if these tests actually verify that the > > agent's resource c

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 25, 2018, 4:59 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 501-505 (patched) > > > > > > ``` > > // Disk spaces will be merged if fixture parameter is `NONE`. > >

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 13, 2018, 9:43 a.m., Greg Mann wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 455-459 (patched) > > > > > > Is this enforced somewhere in validation code? Can we check for > > expected behavio

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 25, 2018, 9:09 a.m., Greg Mann wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 585-586 (patched) > > > > > > IIUC, the `Clock::settle()` here is ensuring that this test actually > > verifies th

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/ --- (Updated April 27, 2018, 1:04 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 27, 2018, 12:24 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated April 27, 2018, 12:23 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66836/#review202088 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:22 a.m

Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66835/#review202087 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:22 a.m

Re: Review Request 66834: Windows: Specialized `flags::parse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202086 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:22 a.m

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review202085 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:21 a.m

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/ --- (Updated April 27, 2018, 11:51 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66578/#review202082 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:20 a.m

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/#review202081 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:17 a.m

Re: Review Request 66820: Added framework metrics 'subscribed' and helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66820/ --- (Updated April 27, 2018, 11:41 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated April 27, 2018, 11:39 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66844/#review202078 --- Patch looks great! Reviews applied: [66819, 66820, 66821, 66822,

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

> On April 25, 2018, 10:39 p.m., Jiang Yan Xu wrote: > > Yan, Gaston, Please take another look. I have addressed your comments. Thanks! - Megha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66844/#review202075 --- PASS: Mesos patch 66844 was successfully built and tested. Review

Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66844/ --- (Updated April 27, 2018, 4:54 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66284: Tested `max_completion_time` support in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66284/ --- (Updated April 27, 2018, 9:09 a.m.) Review request for mesos, Jason Lai and Jam

Re: Review Request 66843: Added 'FrameworkMetrics' to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66843/ --- (Updated April 27, 2018, 3:44 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66842: Added counter metrics for offer filter durations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66842/ --- (Updated April 27, 2018, 3:42 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66841: Added a hash function for 'Duration'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66841/ --- (Updated April 27, 2018, 3:40 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66817/#review202068 --- Patch looks great! Reviews applied: [8, 9, 66670, 66671,

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66817/#review202063 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 66840: Added `libacl` into a few Dockerfiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66840/#review202061 --- Ship it! Ship It! - Benjamin Bannier On April 27, 2018, 10:3

Re: Review Request 66849: Added missing test expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66849/#review202060 --- Patch looks great! Reviews applied: [66849] Passed command: expo

Re: Review Request 66849: Added missing test expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66849/#review202059 --- PASS: Mesos patch 66849 was successfully built and tested. Review

Review Request 66849: Added missing test expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66849/ --- Review request for mesos, Gaston Kleiman and Greg Mann. Repository: mesos Des

Re: Review Request 66811: Added `libacl` as a dependency of stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66811/#review202058 --- 3rdparty/CMakeLists.txt Lines 288 (patched)

Re: Review Request 66840: Added `libacl` into a few Dockerfiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66840/ --- (Updated April 27, 2018, 4:30 p.m.) Review request for mesos, Gilbert Song, Gre

Re: Review Request 66840: Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66840/#review202052 --- support/mesos-build/centos-7.dockerfile Line 1 (original), 1 (pat