Re: Review Request 64610: Updated cpplint from upstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64610/#review203032 --- Fix it, then Ship it! Tested by comparing the result of `cpplin

Re: Review Request 64610: Updated cpplint from upstream.

> On May 15, 2018, 9:56 a.m., Armand Grillet wrote: > > support/cpplint.patch > > Line 7 (original), 8 (patched) > > > > > > ``` > > apache-mesos (r/64610) $ git commit -m "Updated cpplint from upstream." > > s

Re: Review Request 67054: Added .tox to files excluded by Python linter.

> On May 11, 2018, 1:26 p.m., Kevin Klues wrote: > > This looks good, but I think we should also add the .virtualenv and .tox > > directories to our .gitignore. They should never be part of the list of > > files that are being processed by mesos-style.py during a commit hook > > anyway. What

Re: Review Request 67123: Address comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67123/#review203103 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Review Request 67127: Updated cpplint from upstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67127/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 67128: Removed extra `containerizer->wait()` calls in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67128/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang

Re: Review Request 67127: Updated cpplint from upstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67127/#review203107 --- Patch looks great! Reviews applied: [67127] Passed command: expo

Re: Review Request 67127: Updated cpplint from upstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67127/#review203108 --- PASS: Mesos patch 67127 was successfully built and tested. Review

Re: Review Request 67127: Updated cpplint from upstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67127/#review203113 --- Fix it, then Ship it! Verified the upstream diffs against the d

Re: Review Request 67128: Removed extra `containerizer->wait()` calls in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67128/#review203117 --- PASS: Mesos patch 67128 was successfully built and tested. Review

Review Request 67130: Updated comments related to `wait`, `destroy` containerizer methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67130/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang

Re: Review Request 67127: Updated cpplint from upstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67127/ --- (Updated May 15, 2018, 2:05 p.m.) Review request for mesos and Benjamin Bannier

Re: Review Request 66621: Add support for alg RS256 to JWT library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/#review202608 --- Thanks for your contribution Clement. I appreciate how you put lar

Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65505/#review203125 --- PASS: Mesos patch 65505 was successfully built and tested. Review

Re: Review Request 67128: Removed extra `containerizer->wait()` calls in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67128/#review203128 --- Patch looks great! Reviews applied: [8, 66670, 66671, 66817,

Review Request 67135: Added test to verify presence of nested container termination status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67135/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang

Re: Review Request 67116: Change XFS Kill Test to use ASSERT_GE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67116/#review203136 --- Ship it! Ship It! - James Peach On May 14, 2018, 5:18 p.m.,

Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- Review request for mesos, Gilbert Song, Jie Yu, and James Peach. Bugs: MESOS-89

Review Request 67136: Added a function to get rlimits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/ --- Review request for mesos, Jie Yu and James Peach. Repository: mesos Descripti

Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65505/#review203145 --- Patch looks great! Reviews applied: [8, 66670, 66671, 66817,

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/#review203146 --- Ship it! - Greg Mann On May 11, 2018, 8:44 a.m., Gilbert Song

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- (Updated May 15, 2018, 5:09 p.m.) Review request for mesos, Akash Gupta, Andrew

Re: Review Request 67135: Added test to verify presence of nested container termination status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67135/#review203147 --- PASS: Mesos patch 67135 was successfully built and tested. Review

Re: Review Request 67098: Updated the container launcher mount sequence.

> On May 11, 2018, 11:46 p.m., Jie Yu wrote: > > high level comments: should we just create `/dev` in the linux > > devices isolator "prepare" phase? The linux devices isolator should also > > prepare those standard devices. Logically, this makes sense because `/dev` > > should just be owned b

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203151 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 66882: Added `normalizeMetricKey()` and `getFrameworkMetricPrefix()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66882/#review203152 --- Ship it! Ship It! - Gilbert Song On May 14, 2018, 9:47 a.m.,

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67097/ --- (Updated May 15, 2018, 5:53 p.m.) Review request for mesos, Gilbert Song, Jason

Re: Review Request 66820: Added per framework metrics 'subscribed' and helpers.

> On May 14, 2018, 3:34 p.m., Greg Mann wrote: > > src/master/master.hpp > > Lines 2977-2991 (original), 2980-2993 (patched) > > > > > > Is this constructor used anywhere? I couldn't find a callsite. Yes, around th

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203154 --- src/slave/containerizer/mesos/launch.cpp Lines 481 (patched)

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 15, 2018, 6:30 p.m.) Review request for mesos, Akash Gupta, Andrew

Re: Review Request 65900: Defer creation of volume target paths to container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65900/#review203156 --- src/slave/containerizer/mesos/isolators/volume/utils.hpp Lines 39

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review203157 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67135: Added test to verify presence of nested container termination status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67135/#review203159 --- Patch looks great! Reviews applied: [8, 66670, 66671, 66817,

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

> On May 15, 2018, 8:28 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 481 (patched) > > > > > > This kind of logic will _never_ work on Windows, because the file > > descri

Re: Review Request 66621: Add support for alg RS256 to JWT library.

> On mai 15, 2018, 2:30 après-midi, Till Toenshoff wrote: > > 3rdparty/libprocess/src/ssl/utilities.cpp > > Lines 433 (patched) > > > > > > Would it make sense to use `ERR_reason_error_string(ERR_get_error())` > > i

Re: Review Request 66621: Add support for alg RS256 to JWT library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/ --- (Updated mai 15, 2018, 8:49 après-midi) Review request for mesos, Alexander Roj

Re: Review Request 66621: Add support for alg RS256 to JWT library.

> On mai 15, 2018, 2:30 après-midi, Till Toenshoff wrote: > > 3rdparty/libprocess/src/ssl/utilities.cpp > > Lines 433 (patched) > > > > > > Would it make sense to use `ERR_reason_error_string(ERR_get_error())` > > i

Re: Review Request 66621: Add support for alg RS256 to JWT library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/ --- (Updated mai 15, 2018, 9:05 après-midi) Review request for mesos, Alexander Roj

Re: Review Request 66823: Added per framework metrics for framework events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/#review203166 --- src/master/master.hpp Lines 2381 (patched)

Re: Review Request 66621: Add support for alg RS256 to JWT library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/#review203172 --- PASS: Mesos patch 66621 was successfully built and tested. Review

Re: Review Request 66825: Added per framework offer metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66825/#review203173 --- src/master/master.cpp Lines 4019 (patched)

Re: Review Request 66847: Added per framework metric for offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66847/#review203175 --- Ship it! Ship It! - Greg Mann On May 11, 2018, 8:44 a.m., Gi

Re: Review Request 67059: Ported all support scripts to Python 3.

> On May 10, 2018, 1:34 p.m., Andrew Schwartzmeyer wrote: > > support/python3/apply-reviews.py > > Lines 2-17 (patched) > > > > > > It's unfortunate that due to a staged replacement, we can't review the > > diffs of t

Re: Review Request 66820: Added per framework metrics 'subscribed' and helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66820/#review203177 --- Ship it! Ship It! - Greg Mann On May 11, 2018, 7:24 a.m., Gi

Re: Review Request 67099: Updated support scripts to check for Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67099/#review203179 --- support/check-python3 Lines 1 (patched)

Re: Review Request 67059: Ported all support scripts to Python 3.

> On May 10, 2018, 1:34 p.m., Andrew Schwartzmeyer wrote: > > support/build-virtualenv > > Lines 49-51 (original), 49-51 (patched) > > > > > > I didn't know where else to comment to open this issue: > > > > W

Re: Review Request 67099: Updated support scripts to check for Python 3.

> On May 15, 2018, 3:48 p.m., Andrew Schwartzmeyer wrote: > > support/check-python3 > > Lines 1 (patched) > > > > > > Augh we're going to need a Windows version... or honestly I think it'd > > be easiest just to hard-

Re: Review Request 67055: Updated cpplint to be compatible with Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67055/#review203182 --- Ship it! Nice work patching cpplint to be single-source compati

Re: Review Request 67008: Added documentation to website for Python components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67008/#review203184 --- docs/python.md Lines 21-24 (patched)

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/#review203185 --- src/slave/containerizer/composing.cpp Line 361 (original), 360-36

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67075/ --- (Updated May 15, 2018, 11:14 p.m.) Review request for mesos and Andrew Schwartz

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203190 --- Patch looks great! Reviews applied: [67136, 67137] Passed comman

Review Request 67145: Added `linux/devices` isolator whitelist tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67145/ --- Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Bugs: MESOS-8792

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated May 15, 2018, 5:31 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated May 15, 2018, 5:33 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66820: Added per framework metrics 'subscribed' and helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66820/ --- (Updated May 15, 2018, 5:33 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/ --- (Updated May 15, 2018, 5:35 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66823: Added per framework metrics for framework events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/ --- (Updated May 15, 2018, 5:41 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66823: Added per framework metrics for framework events.

> On May 15, 2018, 2:58 p.m., Greg Mann wrote: > > src/master/master.hpp > > Lines 2381 (patched) > > > > > > I'm curious what the performance impact of this will be during a period > > of high event throughput. Do

Re: Review Request 66845: Made per-framework metrics count heartbeat events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66845/ --- (Updated May 15, 2018, 5:42 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66825: Added per framework offer metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66825/ --- (Updated May 15, 2018, 5:43 p.m.) Review request for mesos, Benjamin Mahler, Ga

Review Request 67146: Updated the container logger interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67146/ --- Review request for mesos, Chun-Hung Hsiao, Joseph Wu, and Till Toenshoff. Bugs:

Re: Review Request 66846: Added per framework metrics support for terminal task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66846/ --- (Updated May 15, 2018, 5:45 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66847: Added per framework metric for offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66847/ --- (Updated May 15, 2018, 5:46 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66621: Add support for alg RS256 to JWT library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/#review203192 --- Ship it! Ship It! - Till Toenshoff On May 15, 2018, 9:05 p.m

Re: Review Request 66842: Added counter metrics for offer filter durations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66842/ --- (Updated May 16, 2018, 1:07 a.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 67146: Updated the container logger interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67146/#review203193 --- Ship it! Nicely simplifying update, thanks Jie! src/slave/con

Re: Review Request 67043: Made the master task state metrics track reregistered agents' tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67043/ --- (Updated May 16, 2018, 1:45 a.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 67145: Added `linux/devices` isolator whitelist tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67145/#review203195 --- PASS: Mesos patch 67145 was successfully built and tested. Review

Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66844/ --- (Updated May 16, 2018, 2:11 a.m.) Review request for mesos, Benjamin Mahler, Ga

Review Request 67147: Included a missing header in the master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67147/ --- Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Gilbert Song. Bu

Re: Review Request 67146: Updated the container logger interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67146/#review203198 --- PASS: Mesos patch 67146 was successfully built and tested. Review

Re: Review Request 66621: Add support for alg RS256 to JWT library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/#review203199 --- Patch looks great! Reviews applied: [66621] Passed command: expo