Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/#review203731 --- Patch looks great! Reviews applied: [67271, 67195] Passed comman

Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67255/ --- (Updated May 24, 2018, 3:28 a.m.) Review request for mesos, Benjamin Bannier, G

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/ --- (Updated May 24, 2018, 3:19 a.m.) Review request for mesos, Benjamin Bannier, G

Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67255/ --- (Updated May 24, 2018, 2:55 a.m.) Review request for mesos, Benjamin Bannier, G

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203725 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/#review203724 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/ --- (Updated May 23, 2018, 6:08 p.m.) Review request for mesos, Gaston Kleiman, Jie

Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67255/ --- (Updated May 24, 2018, 12:49 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/ --- (Updated May 24, 2018, 12:47 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/ --- (Updated May 24, 2018, 12:46 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67270: Fixed compilation error in libprocess example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67270/#review203722 --- Patch looks great! Reviews applied: [67270] Passed command: expo

Re: Review Request 67098: Updated the container launcher mount sequence.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67098/ --- (Updated May 24, 2018, 12:27 a.m.) Review request for mesos, Gilbert Song, Jaso

Re: Review Request 67145: Added `linux/devices` isolator whitelist tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67145/ --- (Updated May 24, 2018, 12:28 a.m.) Review request for mesos, Gilbert Song, Jaso

Re: Review Request 67098: Updated the container launcher mount sequence.

> On May 11, 2018, 11:46 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 399-410 (patched) > > > > > > + @jasonlai > > > > This might be related to your chain. Please let us know w

Re: Review Request 67098: Updated the container launcher mount sequence.

> On May 23, 2018, 6:56 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 401 (patched) > > > > > > I'd still prefer printing the error so that the error can be more > > specific. Fixed.

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/ --- (Updated May 24, 2018, 12:14 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/#review203717 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67145: Added `linux/devices` isolator whitelist tests.

> On May 23, 2018, 7:05 p.m., Jie Yu wrote: > > src/tests/containerizer/linux_devices_isolator_tests.cpp > > Lines 133 (patched) > > > > > > ```[jie@core-dev ~]$ echo $SUDO_USER > > > > ``` > > > >

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review203713 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67274: Validated that resources from frameworks are finite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/#review203709 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203708 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/ --- (Updated May 23, 2018, 11:14 p.m.) Review request for mesos and Andrew Schwartz

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 23, 2018, 11:03 p.m.) Review request for mesos, Akash Gupta, Andre

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/ --- (Updated May 23, 2018, 11:03 p.m.) Review request for mesos, Akash Gupta, Andre

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- (Updated May 23, 2018, 11:03 p.m.) Review request for mesos, Akash Gupta, Andre

Re: Review Request 67274: Validated that resources from frameworks are finite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/#review203707 --- src/common/validation.hpp Lines 57 (patched)

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203706 --- Fix it, then Ship it! src/slave/containerizer/mesos/io/switchb

Review Request 67274: Validated that resources from frameworks are finite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, Michael Park, and Neil C

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203705 --- Fix it, then Ship it! src/slave/containerizer/mesos/launch.cpp

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- (Updated May 24, 2018, 12:25 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 66841: Added a hash function for 'Duration'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66841/#review203703 --- Ship it! Ship It! - Gilbert Song On May 8, 2018, 4:18 p.m.,

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/#review203702 --- src/master/metrics.cpp Lines 885 (patched)

Re: Review Request 66846: Added per framework metrics support for terminal task state.

> On May 16, 2018, 10:34 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 12113 (patched) > > > > > > When `task->statuses.size == 0`, I think we probably want to increment > > the terminal task state me

Re: Review Request 66962: Windows: Added tests for async IO functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review203698 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018, 3:

Re: Review Request 66961: Windows: Ported sendfile_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66961/#review203697 --- Ship it! Awesome! 3rdparty/stout/tests/os/sendfile_tests.cpp

Re: Review Request 66960: Windows: Added async version of `os::sendfile`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66960/#review203696 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018, 3:

Re: Review Request 66959: Windows: Fixed pipe inheritance in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66959/#review203695 --- src/slave/containerizer/mesos/containerizer.cpp Lines 1874-1878 (

Re: Review Request 66959: Windows: Fixed pipe inheritance in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66959/#review203693 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 4, 2018, 10:

Re: Review Request 66958: Windows: Fixed inheritance in subprocess_windows.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66958/#review203692 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018, 3:

Re: Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66957/#review203691 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018, 3:

Re: Review Request 66956: Windows: Added overlapped support to `os::write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66956/#review203688 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018, 3:

Re: Review Request 66955: Windows: Added overlapped support to `os::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66955/#review203687 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018, 3:

Re: Review Request 66954: Windows: Added internal windows file for overlapped helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66954/#review203686 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 4, 2018, 10:

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66952/#review203685 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 4, 2018, 10:

Re: Review Request 67059: Ported all support scripts to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review203684 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018, 8:

Re: Review Request 67099: Updated support scripts to check for Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67099/#review203683 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018, 7:

Re: Review Request 67247: Added support script to check if Python >= 3.6 is available.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67247/#review203682 --- support/check-python3.py Lines 34-37 (patched)

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/#review203681 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67098: Updated the container launcher mount sequence.

> On May 23, 2018, 6:56 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 406-407 (patched) > > > > > > Can you address this TODO? sounds like just a `dirname` and `mkdir`? Jason's patch ser

Re: Review Request 67191: Supported custom error types for the `Future(Try<...>)` constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67191/ --- (Updated May 23, 2018, 7:17 p.m.) Review request for mesos, Benjamin Bannier, B

Re: Review Request 67190: Overloaded `stringify` for `Error`s to reduce overheads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67190/ --- (Updated May 23, 2018, 7:16 p.m.) Review request for mesos, Benjamin Bannier, B

Re: Review Request 67153: Enforced that `allowed_devices` entries must have a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67153/#review203679 --- Ship it! Ship It! - Jie Yu On May 16, 2018, 5:56 p.m., James

Re: Review Request 67145: Added `linux/devices` isolator whitelist tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67145/#review203678 --- src/tests/containerizer/linux_devices_isolator_tests.cpp Lines 13

Re: Review Request 67271: Change ambiguous parameter name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/#review203677 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67098: Updated the container launcher mount sequence.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67098/#review203675 --- src/slave/containerizer/mesos/launch.cpp Lines 401 (patched)

Re: Review Request 67271: Change ambiguous parameter name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/ --- (Updated May 23, 2018, 6:42 p.m.) Review request for mesos and James Peach. B

Re: Review Request 67270: Fixed compilation error in libprocess example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67270/#review203676 --- Could you follow this up with a patch which compiles the example a

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/ --- (Updated May 23, 2018, 6:33 p.m.) Review request for mesos, James Peach and Jia

Re: Review Request 67271: Change ambiguous parameter name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/ --- (Updated May 23, 2018, 6:32 p.m.) Review request for mesos and James Peach. B

Re: Review Request 67270: Fixed compilation error in libprocess example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67270/#review203674 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 67271: Change ambiguous parameter name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/ --- Review request for mesos and James Peach. Bugs: MESOS-8340 https://issues.a

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/ --- (Updated May 23, 2018, 5:57 p.m.) Review request for mesos, James Peach and Jia

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/#review203671 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 67270: Fixed compilation error in libprocess example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67270/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/ --- (Updated May 23, 2018, 4:54 p.m.) Review request for mesos and Andrew Schwartzm

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/ --- (Updated May 23, 2018, 4:40 p.m.) Review request for mesos and Andrew Schwartzm

Re: Review Request 67153: Enforced that `allowed_devices` entries must have a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67153/#review203667 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67097/ --- (Updated May 23, 2018, 3:44 p.m.) Review request for mesos, Gilbert Song, Jason

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device >

Re: Review Request 64074: Added ENABLE_HTTP_SERVER option for cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64074/#review203664 --- Bad patch! Reviews applied: [64074, 61158, 64909, 64908, 64907, 6

Re: Review Request 66671: Updated composing containerizer tests.

> On May 22, 2018, 9:26 a.m., Qian Zhang wrote: > > For the tests `DestroyDuringUnsupportedLaunchLoop` and > > `DestroyAfterLaunchLoop`, I think the intention of both of them is to check > > the value of `container->destroyed` set in > > `ComposingContainerizerProcess::_launch()`. But in your

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 21, 2018, 1:21 p.m., Qian Zhang wrote: > > Can you please explain how the container will be cleaned up from the > > `containers_` map after agent recovery? > > Andrei Budnik wrote: > In the current implementation, a recovered container can be cleaned up > only when someone calls `

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203655 --- Patch looks great! Reviews applied: [67241] Passed command: expo

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 21, 2018, 1:21 p.m., Qian Zhang wrote: > > src/slave/containerizer/composing.cpp > > Lines 396-400 (original) > > > > > > Previously, in the case that `destroy-in-progress stopped an > > launch-in-progress`

Re: Review Request 67191: Supported custom error types for the `Future(Try<...>)` constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67191/#review203653 --- Fix it, then Ship it! 3rdparty/libprocess/include/process/futu

Re: Review Request 67190: Overloaded `stringify` for `Error`s to reduce overheads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67190/#review203652 --- Ship it! The assumption here is that stringification of `Error`

Re: Review Request 66962: Windows: Added tests for async IO functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review203650 --- Patch looks great! Reviews applied: [67248, 66952, 66954, 66955,

Re: Review Request 67258: Fixed flakiness for some `AgentResourceProviderConfigApiTest` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67258/#review203648 --- Bad patch! Reviews applied: [67258, 67257, 67256, 67255, 67224, 6

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/#review203647 --- Patch looks great! Reviews applied: [66882, 66819, 66820, 66822,