Re: Review Request 67993: Avoid resource copying while serving state json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67993/#review206259 --- FAIL: Failed to apply the dependent review: 67987. Failed

Review Request 67993: Avoid resource copying while serving state json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67993/ --- Review request for mesos, Alexander Rukletsov and Benno Evers. Repository:

Re: Review Request 67980: Windows: Enabled rest of `ProcessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67980/#review206258 --- Patch looks great! Reviews applied: [67951, 67952, 67976, 67977,

Re: Review Request 67992: Avoid performance cost of ostringstream in http::OK json constructors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67992/#review206257 --- FAIL: Failed to apply the dependent review: 67987. Failed

Review Request 67992: Avoid performance cost of ostringstream in http::OK json constructors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67992/ --- Review request for mesos, Alexander Rukletsov and Benno Evers. Repository:

Review Request 67991: Adjusted Mesos to compile against jsonify rapidjson changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67991/ --- Review request for mesos, Alexander Rukletsov and Benno Evers. Bugs:

Review Request 67989: Fixed issues with the JSON serialization tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67989/ --- Review request for mesos, Alexander Rukletsov and Benno Evers. Bugs:

Review Request 67988: Improved performance of jsonify by integrating with rapidjson.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67988/ --- Review request for mesos, Alexander Rukletsov, Benno Evers, and Michael Park.

Review Request 67985: Added rapidjson to the stout build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67985/ --- Review request for mesos, Alexander Rukletsov and Benno Evers. Bugs:

Review Request 67986: Added rapidjson to the libprocess build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67986/ --- Review request for mesos, Alexander Rukletsov and Benno Evers. Bugs:

Review Request 67990: Fixed libprocess tests against rapidjson.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67990/ --- Review request for mesos, Alexander Rukletsov and Benno Evers. Bugs:

Review Request 67987: Added rapidjson to the mesos build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67987/ --- Review request for mesos, Alexander Rukletsov, Benno Evers, and James Peach.

Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/#review206256 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206255 --- PASS: Mesos patch 67914 was successfully built and tested.

Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/ --- Review request for mesos. Repository: mesos Description --- Windows:

Re: Review Request 67878: Added/updated tests to check per-framework metrics.

> On July 19, 2018, 3:45 p.m., Gastón Kleiman wrote: > > Can you add a test that verifies whether allocator and non-allocator > > per-framework metrics are evicted once the `max_completed_frameworks` bound > > is reached? And also one testing the `suppressed` metric. - Gastón

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

> On July 18, 2018, 1:51 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 495 (original), 504 (patched) > > > > > > I'm a little concerned that we could exhaust the project

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/ --- (Updated July 19, 2018, 4:12 p.m.) Review request for mesos and James Peach.

Re: Review Request 66870: Added per-framework metrics for suppressed roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66870/#review206253 --- Can you add a test? At least one that calls suppress/revive, but

Re: Review Request 66856: Tracked completed framework metrics in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66856/#review206252 --- Fix it, then Ship it!

Re: Review Request 67878: Added/updated tests to check per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/#review206251 --- Can you add a test that verifies whether allocator and

Re: Review Request 67980: Windows: Enabled rest of `ProcessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67980/#review206250 --- PASS: Mesos patch 67980 was successfully built and tested.

Re: Review Request 67980: Windows: Enabled rest of `ProcessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67980/ --- (Updated July 19, 2018, 1:47 p.m.) Review request for mesos, Akash Gupta, Eric

Review Request 67980: Windows: Enabled rest of `ProcessTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67980/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu,

Review Request 67979: Windows: Documented why the `RemoteLinkLeak` test is not enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67979/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu,

Re: Review Request 67977: Fixed `test-linkee` logic in `ProcessRemoteLinkTest::SetUp()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67977/#review206249 --- Ship it! Ship It! - Radhika Jandhyala On July 19, 2018,

Review Request 67978: Windows: Enabled `RemoteLink` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67978/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu,

Review Request 67977: Fixed `test-linkee` logic in `ProcessRemoteLinkTest::SetUp()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67977/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu,

Review Request 67976: Windows: Added `nullptr` checks when using `libwinio_loop` pointer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67976/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu,

Re: Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67951/ --- (Updated July 19, 2018, 1:41 p.m.) Review request for mesos, Eric Mumau, John

Re: Review Request 67955: Added some new generic flag parsers.

> On July 19, 2018, 6:51 p.m., Kevin Klues wrote: > > 3rdparty/stout/include/stout/flags/parse.hpp > > Lines 249-251 (patched) > > > > > > This comment is wrong. It's not for unsigned ints, it's for strings. Okay

Re: Review Request 67956: Removed some generic flag parsers that are now in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67956/#review206247 --- Ship it! I assume removing these in this commit seprate from

Re: Review Request 67955: Added some new generic flag parsers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67955/#review206242 --- 3rdparty/stout/include/stout/flags/parse.hpp Lines 249-251

Re: Review Request 67503: Added support helper for fetching review ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- (Updated July 19, 2018, 3:48 p.m.) Review request for mesos, Andrew

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated July 19, 2018, 3:48 p.m.) Review request for mesos, Andrew

Re: Review Request 67504: Added support script to post build results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- (Updated July 19, 2018, 3:39 p.m.) Review request for mesos, Andrew

Re: Review Request 67504: Added support script to post build results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/#review206240 --- dummy All the build artifacts available at:

Re: Review Request 67972: RFC: Added RetentionPolicy for task metadata and sandboxes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67972/#review206239 --- PASS: Mesos patch 67972 was successfully built and tested.

Review Request 67972: RFC: Added RetentionPolicy for task metadata and sandboxes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67972/ --- Review request for mesos, Gilbert Song, Qian Zhang, and Vinod Kone. Bugs:

Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67896/ --- (Updated July 19, 2018, 5:10 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

> On July 19, 2018, 6:46 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 628 (patched) > > > > > > Should we also use `CGROUP_SEPARATOR` and move it to a common