Re: Review Request 68597: Made copy backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68597/#review208220 --- PASS: Mesos patch 68597 was successfully built and tested.

Re: Review Request 68598: Added a missing failure message in overlay backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68598/#review208219 --- Ship it! Ship It! - Gilbert Song On Aug. 31, 2018, 9:56

Re: Review Request 68594: Made overlay backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68594/#review208215 --- Ship it! Ship It! - Gilbert Song On Aug. 31, 2018, 9:50

Re: Review Request 68596: Made bind backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68596/#review208217 --- Ship it! Ship It! - Gilbert Song On Aug. 31, 2018, 9:50

Re: Review Request 68597: Made copy backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68597/#review208218 --- Ship it! Ship It! - Gilbert Song On Aug. 31, 2018, 9:50

Re: Review Request 68595: Made aufs backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68595/#review208216 --- Ship it! Ship It! - Gilbert Song On Aug. 31, 2018, 9:50

Review Request 68598: Added a missing failure message in overlay backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68598/ --- Review request for mesos, Gilbert Song and Zhitao Li. Repository: mesos

Re: Review Request 68597: Made copy backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68597/ --- (Updated Sept. 1, 2018, 4:50 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68594: Made overlay backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68594/ --- (Updated Sept. 1, 2018, 4:50 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68596: Made bind backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68596/ --- (Updated Sept. 1, 2018, 4:50 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68595: Made aufs backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68595/ --- (Updated Sept. 1, 2018, 4:50 a.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 68597: Made copy backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68597/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Bugs: MESOS-9196

Review Request 68596: Made bind backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68596/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Bugs: MESOS-9196

Review Request 68594: Made overlay backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68594/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Bugs: MESOS-9196

Review Request 68595: Made aufs backend destroy more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68595/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Bugs: MESOS-9196

Re: Review Request 68582: Windows: Add `WclayerBackend` to provision Docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68582/#review208214 --- Patch looks great! Reviews applied: [68581, 68582] Passed

Re: Review Request 68592: Fixed flakiness in an operation reconciliation test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68592/#review208211 --- PASS: Mesos patch 68592 was successfully built and tested.

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review208210 --- Patch looks great! Reviews applied: [68131] Passed command:

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/#review208207 --- PASS: Mesos patch 68591 was successfully built and tested.

Re: Review Request 68555: Made checker library retry to remove the previous check container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68555/#review208205 --- Patch looks great! Reviews applied: [68495, 68555] Passed

Re: Review Request 68592: Fixed flakiness in an operation reconciliation test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68592/#review208204 --- Ship it! Ship It! - Gastón Kleiman On Aug. 31, 2018, 3:28

Review Request 68592: Fixed flakiness in an operation reconciliation test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68592/ --- Review request for mesos and Gastón Kleiman. Repository: mesos Description

Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- Review request for mesos, Meng Zhu and Till Toenshoff. Bugs: MESOS-9187

Re: Review Request 68548: Added allocator benchmark test harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208203 --- PASS: Mesos patch 68548 was successfully built and tested.

Re: Review Request 68538: Added Python 3.6 and pip to Docker images.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68538/#review208199 --- Patch looks great! Reviews applied: [68538] Passed command:

Re: Review Request 68578: Stout: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68578/#review208195 --- Ship it! Ship It! - Benjamin Bannier On Aug. 31, 2018, 7:44

Re: Review Request 68579: Libprocess: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68579/#review208196 --- Ship it! Ship It! - Benjamin Bannier On Aug. 31, 2018, 7:45

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/#review208194 --- Ship it! Ship It! - Benjamin Bannier On Aug. 31, 2018, 7:43

Re: Review Request 68577: Stout: Fixed standalone build with libarchive.

> On Aug. 31, 2018, 9:50 a.m., Benjamin Bannier wrote: > > Thanks for fixing this. > > > > I confirmed that `make check` works in standalone `stout` builds now. > > Unfortunately `make distcheck` still fails though. Spend a bit time on `make distcheck`. There seems to be two issues: 1.

Re: Review Request 68587: Fixed fetcher deadlock with duplicate URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68587/#review208192 --- PASS: Mesos patch 68587 was successfully built and tested.

Re: Review Request 68564: Set up `-Wno-inconsistent-missing-override` conditionally.

> On Aug. 31, 2018, 11:36 a.m., Benjamin Bannier wrote: > > configure.ac > > Lines 639 (patched) > > > > > > If you implement https://reviews.apache.org/r/68576/#comment291938 this > > would be another candidate to

Re: Review Request 68579: Libprocess: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68579/ --- (Updated Aug. 31, 2018, 5:45 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68578: Stout: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68578/ --- (Updated Aug. 31, 2018, 5:44 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/ --- (Updated Aug. 31, 2018, 5:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

> On Aug. 31, 2018, 11:31 a.m., Benjamin Bannier wrote: > > m4/ax_append_compile_flags.m4 > > Lines 1 (patched) > > > > > > Let's use the file from upstream `HEAD`, e.g., from > >

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/ --- (Updated Aug. 31, 2018, 5:27 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

> On Aug. 31, 2018, 11:31 a.m., Benjamin Bannier wrote: > > m4/ax_append_compile_flags.m4 > > Lines 1 (patched) > > > > > > Let's use the file from upstream `HEAD`, e.g., from > >

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

> On Aug. 31, 2018, 11:31 a.m., Benjamin Bannier wrote: > > configure.ac > > Line 635 (original), 635 (patched) > > > > > > This code is pretty robust and should work with any compiler. How about > > moving it out

Review Request 68587: Fixed fetcher deadlock with duplicate URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68587/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-9172

Review Request 68586: Add the output file to the hash on CommandInfo::URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68586/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-9172

Re: Review Request 68553: Set 'Connection: close' in the master's streaming API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68553/#review208180 --- Patch looks great! Reviews applied: [68553] Passed command:

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/ --- (Updated Aug. 31, 2018, 3:08 p.m.) Review request for mesos and Alexander

Re: Review Request 68231: Added `AgentAPITest.AttachContainerInputRepeat` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68231/ --- (Updated Aug. 31, 2018, 2:15 p.m.) Review request for mesos, Alexander

Re: Review Request 68543: Added stout helper to parse strings to protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68543/#review208173 --- Patch looks great! Reviews applied: [68543] Passed command:

Re: Review Request 68230: Added `AgentAPITest.LaunchNestedContainerSessionKillTask` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68230/ --- (Updated Aug. 31, 2018, 1:11 p.m.) Review request for mesos, Alexander

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/ --- (Updated Aug. 31, 2018, 11:48 a.m.) Review request for mesos, Alexander

Re: Review Request 68564: Set up `-Wno-inconsistent-missing-override` conditionally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68564/#review208169 --- Fix it, then Ship it! configure.ac Lines 639 (patched)

Re: Review Request 68579: Libprocess: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68579/#review208168 --- Could you fix the issues pointed out in

Re: Review Request 68578: Stout: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68578/#review208167 --- Could you fix the issues pointed out in

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/#review208165 --- Fix it, then Ship it! LGTM, but to ease future maintenance I'd

Re: Review Request 68577: Stout: Fixed standalone build with libarchive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68577/#review208162 --- Ship it! Thanks for fixing this. I confirmed that `make

Re: Review Request 68566: Updated Python dependencies for Python 3.7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68566/#review208160 --- Ship it! LGTM! Thanks Armand. - Benjamin Bannier On Aug.

Re: Review Request 68535: Simplified Python dependencies management.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68535/#review208159 --- Ship it! Ship It! - Benjamin Bannier On Aug. 30, 2018,