Review Request 68924: Updated the Docker library to avoid 'os::killtree()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68924/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-9283

Review Request 68923: Updated 'Docker::inspect()' to avoid 'os::killtree()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-9283

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68921/#review209204 --- PASS: Mesos patch 68921 was successfully built and tested.

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

> On Oct. 3, 2018, 3:43 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Lines 2268-2270 (patched) > > > > > > Do we still need this fallback if we are confident enough?

Re: Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68906/ --- (Updated Oct. 3, 2018, 11:06 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

> On Oct. 3, 2018, 10:43 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Lines 2268-2270 (patched) > > > > > > Do we still need this fallback if we are confident

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68921/#review209201 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 68921: Bring up the loopback interface using `iproute2`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68921/#review209200 --- Ship it! Ship It! - Gilbert Song On Oct. 3, 2018, 3:36

Review Request 68921: Bring up the loopback interface using `iproute2`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68921/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-9270

Re: Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68919/#review209199 --- PASS: Mesos patch 68919 was successfully built and tested.

Re: Review Request 68507: Pulled out nested `Framework` and `Slave` classes in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68507/#review209198 --- Ship it! Ship It! - Benjamin Mahler On Sept. 25, 2018, 8:49

Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68508/#review209197 --- Ship it! Can you do a quick benchmark comparison to see if

Re: Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68906/#review209196 --- Fix it, then Ship it! Thanks for tracking this down!

Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68919/ --- Review request for mesos, Benjamin Bannier and James Peach. Repository: mesos

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68916/#review209194 --- PASS: Mesos patch 68916 was successfully built and tested.

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68916/ --- (Updated Oct. 3, 2018, 7:32 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68915: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68915/ --- (Updated Oct. 3, 2018, 7:32 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68913: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68913/#review209193 --- PASS: Mesos patch 68913 was successfully built and tested.

Re: Review Request 68912: Added a log line to `MesosContainerizer::kill()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68912/#review209192 --- Ship it! Ship It! - Gilbert Song On Oct. 3, 2018, 8:05

Review Request 68915: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68915/ --- Review request for mesos, Benjamin Bannier and James Peach. Repository: mesos

Review Request 68916: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68916/ --- Review request for mesos, Benjamin Bannier and James Peach. Repository: mesos

Review Request 68914: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68914/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9222

Review Request 68913: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68913/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9222

Re: Review Request 68912: Added a log line to `MesosContainerizer::kill()`.

> On Oct. 3, 2018, 4:05 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['68912']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 67748: Added monitoring paragraph to high-availability.md.

> On June 26, 2018, 9:12 p.m., Joerg Schad wrote: > > docs/high-availability.md > > Lines 58 (patched) > > > > > > Can we check what the exact defintion of this metric is? (connected to > > each other, connected to

Re: Review Request 68912: Added a log line to `MesosContainerizer::kill()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68912/#review209187 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68866/#review209186 --- Ship it! Ship It! - Vinod Kone On Sept. 27, 2018, 5:41

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

> On Sept. 27, 2018, 6:23 p.m., Vinod Kone wrote: > > src/java/jni/org_apache_mesos_v1_scheduler_V1Mesos.cpp > > Lines 294 (patched) > > > > > > Looks like you are doing `call` here instead of `send` so that you

Re: Review Request 68865: Put `TerminateEvent` at the end of the queue in the Mesos library.

> On Sept. 27, 2018, 6:24 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp > > Line 1041 (original), 1041 (patched) > > > > > > Can you add a comment on why you are doing this for posterity? +1 Could you

Review Request 68912: Added a log line to `MesosContainerizer::kill()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68912/ --- Review request for mesos and Gilbert Song. Repository: mesos Description