Re: Review Request 69149: Automatically remounted read-only bind mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69149/#review210125 --- PASS: Mesos patch 69149 was successfully built and tested.

Re: Review Request 69194: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69194/#review210124 --- PASS: Mesos patch 69194 was successfully built and tested. All

Re: Review Request 69172: Added `FetcherCacheTest.LocalCachedMissing` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69172/#review210123 --- Patch looks great! Reviews applied: [69171, 69172] Passed

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review210122 --- PASS: Mesos patch 69110 was successfully built and tested.

Re: Review Request 69194: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69194/#review210121 --- Ship it! Ship It! - Joseph Wu On Oct. 26, 2018, 3:34 p.m.,

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review210120 --- Ship it! Ship It! - Gastón Kleiman On Oct. 26, 2018, 3:08

Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69178/#review210119 --- Ship it! Ship It! - Joseph Wu On Oct. 26, 2018, 4 p.m.,

Re: Review Request 69172: Added `FetcherCacheTest.LocalCachedMissing` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69172/#review210117 --- Ship it! Ship It! - Joseph Wu On Oct. 25, 2018, 1:47 p.m.,

Re: Review Request 69171: Added validation of cache files to the URI Fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69171/#review210115 --- src/slave/containerizer/fetcher.cpp Lines 1030-1031 (patched)

Re: Review Request 69185: Added streaming header support for /api/v1 SUBSCRIBE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69185/#review210116 --- Patch looks great! Reviews applied: [69180, 69181, 69182, 69183,

Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`.

> On Oct. 26, 2018, 3:30 p.m., Joseph Wu wrote: > > src/tests/master_tests.cpp > > Lines 9562-9566 (original), 9562-9566 (patched) > > > > > > Let's do this instead: > > ``` > > testing::Sequence

Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69178/ --- (Updated Oct. 26, 2018, 4 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 69149: Automatically remounted read-only bind mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69149/ --- (Updated Oct. 26, 2018, 10:58 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69186: Added tests for master SUBSCRIBE heartbeating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69186/#review210113 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69194: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69194/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5048

Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69178/#review210112 --- src/tests/master_tests.cpp Lines 9562-9566 (original), 9562-9566

Re: Review Request 69176: Fixed flaky test `SchedulerHttpApiTest.UpdatePidToHttpScheduler`.

> On Oct. 26, 2018, 2:56 p.m., Joseph Wu wrote: > > Good catch! > > > > Do you want to ship this (have your gotten your commit bits?), or shall I? Thanks! I am still waiting for the account creation. If you can push this, that would be great! - Meng

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 26, 2018, 10:08 p.m.) Review request for mesos, Alexander

Review Request 69186: Added tests for master SUBSCRIBE heartbeating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69186/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-9258

Re: Review Request 69176: Fixed flaky test `SchedulerHttpApiTest.UpdatePidToHttpScheduler`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69176/#review210110 --- Ship it! Good catch! Do you want to ship this (have your

Re: Review Request 69149: Automatically remounted read-only bind mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69149/#review210109 --- Fix it, then Ship it! Looks good to me! Nice simplification.

Re: Review Request 69193: Added filters info to the `DECLINE` call log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69193/#review210107 --- PASS: Mesos patch 69193 was successfully built and tested.

Re: Review Request 69188: Fixed a wrong way to install callback for OOM notifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69188/#review210104 --- Ship it! Perhaps a little more description would be helpful?

Re: Review Request 69180: Enabled streaming requests on the master /api/v1 endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69180/ --- (Updated Oct. 26, 2018, 11:29 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

> On Oct. 25, 2018, 8:07 a.m., Qian Zhang wrote: > > src/linux/cgroups.cpp > > Lines 1071-1080 (original), 1071-1089 (patched) > > > > > > I see we already have an onAny callback `_listen`, can we close the fd > >

Re: Review Request 68812: Added example framework for inverse-offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68812/#review210100 --- PASS: Mesos patch 68812 was successfully built and tested.

Re: Review Request 69193: Added filters info to the `DECLINE` call log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69193/#review210099 --- Ship it! Ship It! - Vinod Kone On Oct. 26, 2018, 5:42 p.m.,

Review Request 69193: Added filters info to the `DECLINE` call log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69193/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Repository:

Re: Review Request 68812: Added example framework for inverse-offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68812/ --- (Updated Oct. 26, 2018, 5:20 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 68812: Added example framework for inverse-offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68812/ --- (Updated Oct. 26, 2018, 4:45 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 69160: Included corresponding header file first.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69160/#review210096 --- Ship it! Ship It! - Till Toenshoff On Oct. 25, 2018, 10:54

Re: Review Request 69160: Included corresponding header file first.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69160/#review210090 --- Ship it! Ship It! - Jan Schlicht On Oct. 25, 2018, 12:54

Re: Review Request 69159: Used an alias for reoccuring complicated type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69159/#review210089 --- Fix it, then Ship it! src/tests/mesos.hpp Lines 2921-2930