Re: Review Request 69480: Made non-root containers can access shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69480/ --- (Updated Dec. 1, 2018, 3:39 p.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210995 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review210994 --- src/slave/slave.cpp Lines 8209-8210 (patched)

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review210993 --- src/resource_provider/manager.cpp Lines 579 (patched)

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/ --- (Updated Nov. 30, 2018, 6:49 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210990 --- src/master/master.cpp Lines 12105-12108 (original), 12105-12108

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review210989 --- I've given a shot at making the

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/#review210988 --- In the first line of the commit message: s/provide/provider/ :)

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210958 --- LGTM bar comments left by the other reviewers.

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69452/#review210985 --- PASS: Mesos patch 69452 was successfully built and tested.

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69493/#review210976 --- FAIL: Failed to apply the dependent review: 67844. Failed

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69452/#review210975 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69493: Documented the `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69493/ --- Review request for mesos, Gilbert Song, James Peach, and Qian Zhang. Bugs:

Re: Review Request 69412: Fixed thread safety issue in jwt signature validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69412/#review210906 --- Fix it, then Ship it! The test itself appears a bit wonky and

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

> On Nov. 30, 2018, 3:14 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 2254-2255 (patched) > > > > > > It would make sense to me that we set these IDs if/when they are > > available. Currently I don't

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/ --- (Updated Nov. 30, 2018, 12:06 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/ --- (Updated Nov. 30, 2018, 12:06 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69490: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69490/ --- (Updated Nov. 30, 2018, 6:14 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69490: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69490/#review210972 --- FAIL: Failed to apply the dependent review: 69344. Failed

Re: Review Request 69490: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69490/#review210971 --- FAIL: Failed to apply the dependent review: 69344. Failed

Review Request 69490: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69490/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Re: Review Request 69481: Deallocated the shared persistent volume's gid when it is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69481/#review210970 --- FAIL: Failed to apply the dependent review: 69344. Failed

Re: Review Request 69481: Deallocated the shared persistent volume's gid when it is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69481/ --- (Updated Nov. 30, 2018, 5:08 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69344: Added volume gid manager to Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69344/ --- (Updated Nov. 30, 2018, 4:53 p.m.) Review request for mesos, Gilbert Song,