Re: Review Request 69578: Set up `Object.value` for `CREATE_DISK` and `REMOVE_DISK` authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69578/#review211383 --- PASS: Mesos patch 69578 was successfully built and tested. Review

Re: Review Request 68018: Added `SeccompFilter` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68018/#review211378 --- src/linux/seccomp/seccomp.hpp Lines 31 (patched)

Review Request 69578: Set up `Object.value` for `CREATE_DISK` and `REMOVE_DISK` authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69578/ --- Review request for mesos, Benjamin Bannier, Greg Mann, Jan Schlicht, and Till To

Review Request 69577: Documented `Object.value` authorization field for certain operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69577/ --- Review request for mesos, Benjamin Bannier, Greg Mann, Jan Schlicht, and Till To

Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler` members.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69071/ --- (Updated Dec. 18, 2018, 1:24 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 69575: WIP: Send operation feedback when agent is marked as gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69575/#review211380 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69421: Exposed private data members for testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69421/#review211376 --- Ship it! Ship It! - Greg Mann On Dec. 12, 2018, 8:52 p.m., B

Re: Review Request 69563: Made master to authorize `CREATE_DISK` and `DESTROY_DISK` properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69563/#review211374 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 69575: WIP: Send operation feedback when agent is marked as gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69575/ --- Review request for mesos. Repository: mesos Description --- WIP: Send op

Re: Review Request 69563: Made master to authorize `CREATE_DISK` and `DESTROY_DISK` properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69563/ --- (Updated Dec. 17, 2018, 11 p.m.) Review request for mesos, Benjamin Bannier, Gr

Re: Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69571/ --- (Updated Dec. 17, 2018, 10:58 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68795: Added deduplication for read-only master requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68795/#review211373 --- Fix it, then Ship it! src/master/http.cpp Lines 2385-2395 (pat

Re: Review Request 69572: Validated that resource providers use correct ID in operation states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69572/#review211372 --- src/tests/master_slave_reconciliation_tests.cpp Lines 501 (patche

Re: Review Request 69572: Validated that resource providers use correct ID in operation states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69572/#review211371 --- Ship it! Ship It! - Chun-Hung Hsiao On Dec. 17, 2018, 9:56 a

Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler` members.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69071/#review211370 --- Ship it! Ship It! - Greg Mann On Dec. 12, 2018, 8:47 p.m., B

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review211369 --- Patch looks great! Reviews applied: [69082] Passed command: expo

Re: Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`.

> On Dec. 17, 2018, 11:53 a.m., Jan Schlicht wrote: > > src/master/master.cpp > > Line 4758 (original), 4758 (patched) > > > > > > I don't see how this is an improvement over using `std::deque`. We > > still need t

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/#review211362 --- Ship it! Ship It! - Chun-Hung Hsiao On Dec. 17, 2018, 9:57 a

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

> On Dec. 14, 2018, 10:39 p.m., Chun-Hung Hsiao wrote: > > src/common/protobuf_utils.cpp > > Lines 470 (patched) > > > > > > Since we set the agent ID and RP ID here in SLRP, how about doing the > > following change

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

> On Dec. 14, 2018, 9:39 p.m., Chun-Hung Hsiao wrote: > > src/common/protobuf_utils.cpp > > Lines 470 (patched) > > > > > > Since we set the agent ID and RP ID here in SLRP, how about doing the > > following changes

Re: Review Request 68016: Added libseccomp to the build.

> On Dec. 12, 2018, 3:51 p.m., Gilbert Song wrote: > > configure.ac > > Lines 352 (patched) > > > > > > Do we have a plan to deprecate this configuraton flag in the future? > > E.g., always only compile the seccomp

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211359 --- PASS: Mesos patch 69559 was successfully built and tested. Review

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/ --- (Updated Dec. 17, 2018, 4:55 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

> On Dec. 17, 2018, 1:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Line 77 (original), 72 (patched) > > > > > > Does this display as JSON? It doesn't as we go back to the old codebase. > On Dec.

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review211357 --- PASS: Mesos patch 69082 was successfully built and tested. Review

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

> On Dec. 17, 2018, 12:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Lines 277 (patched) > > > > > > Python's way of `contains` for a dictionary is commonly something like > > this; > > > >

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211355 --- support/verify-reviews.py Lines 36 (patched)

Re: Review Request 69572: Validated that resource providers use correct ID in operation states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69572/#review211354 --- PASS: Mesos patch 69572 was successfully built and tested. Review

Re: Review Request 69571: Made master process all authorization results for `LAUNCH_GROUP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69571/#review211353 --- src/master/master.cpp Line 4758 (original), 4758 (patched)

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/ --- (Updated Dec. 17, 2018, 11:54 a.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Dec. 1, 2018, 4:32 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 8209-8210 (patched) > > > > > > Some high-level feedback after my first glance at this patch: for the > > MARK_AGENT_GONE call, the

Re: Review Request 69398: Added validation for framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69398/#review211351 --- PASS: Mesos patch 69398 was successfully built and tested. Review

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

> On Dec. 14, 2018, 8:07 p.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 8208 (patched) > > > > > > Does it make sense to move this line before L8016 I am not sure what you have in mind. It seems

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/ --- (Updated Dec. 17, 2018, 10:57 a.m.) Review request for mesos, Chun-Hung Hsiao a

Review Request 69572: Validated that resource providers use correct ID in operation states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69572/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9479 https://issu

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

> On Dec. 14, 2018, 10:39 p.m., Chun-Hung Hsiao wrote: > > src/common/protobuf_utils.cpp > > Lines 470 (patched) > > > > > > Since we set the agent ID and RP ID here in SLRP, how about doing the > > following change

Re: Review Request 69557: Tested framework subscription with set but empty ID.

> On Dec. 12, 2018, 7:17 p.m., Benjamin Mahler wrote: > > Can you clarify when the transition from "previously" to "now" occurred? Is > > it due to your other pending patches, or was this something we changed in a > > previous release? > > > > If it's part of your pending patches, we might hav

Re: Review Request 69557: Tested framework subscription with set but empty ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69557/ --- (Updated Dec. 17, 2018, 9:43 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69398: Added validation for framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69398/ --- (Updated Dec. 17, 2018, 9:43 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69563: Made master to authorize `CREATE_DISK` and `DESTROY_DISK` properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69563/#review211346 --- PASS: Mesos patch 69563 was successfully built and tested. Review