Re: Review Request 68016: Added libseccomp to the build.

2018-12-20 Thread Qian Zhang
> On Dec. 20, 2018, 5:39 p.m., Qian Zhang wrote: > > configure.ac > > Lines 1607-1608 (patched) > > > > > > What is the difference between `use a preinstalled libseccomp` and > > `ignore all bundled libraries`?

Review Request 69615: Disable containerizer ptrace attach.

2018-12-20 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/ --- Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.

Re: Review Request 69575: Send operation feedback when agent was marked as gone.

2018-12-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69575/#review211485 --- src/tests/api_tests.cpp Lines 4885 (patched)

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2018-12-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69544/ --- (Updated Dec. 21, 2018, 11 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69542: Made non-root containers can access SANDBOX_PATH volume of PARENT type.

2018-12-20 Thread Qian Zhang
> On Dec. 11, 2018, 11:22 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > > Lines 422 (patched) > > > > > > Let's assume that the `volumeGidManager` got backlogged

Re: Review Request 69542: Made non-root containers can access SANDBOX_PATH volume of PARENT type.

2018-12-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69542/ --- (Updated Dec. 21, 2018, 10:59 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69541: Added volume gid manager.

2018-12-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/ --- (Updated Dec. 21, 2018, 10:57 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-12-20 Thread Qian Zhang
> On Dec. 13, 2018, 12:13 a.m., Andrei Budnik wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 2521 (patched) > > > > > > Do we have a check in the Mesos agent that all related paths have read > >

Review Request 69614: Reverted "Added `libacl` into a few Dockerfiles.".

2018-12-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69614/ --- Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin,

Review Request 69613: Added tests for volume gid manager.

2018-12-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69613/ --- Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin,

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

2018-12-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/ --- (Updated Dec. 21, 2018, 8:57 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 68016: Added libseccomp to the build.

2018-12-20 Thread Andrei Budnik
> On Dec. 20, 2018, 9:39 a.m., Qian Zhang wrote: > > cmake/CompilationConfigure.cmake > > Lines 569 (patched) > > > > > > Just curious why we need add this definition? It seems we do not do > > this for other

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

2018-12-20 Thread Chun-Hung Hsiao
> On Dec. 14, 2018, 7:07 p.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 8208 (patched) > > > > > > Does it make sense to move this line before L8016 > > Benjamin Bannier wrote: > I am not

Review Request 69612: Refactored parallel test runner.

2018-12-20 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69612/ --- Review request for mesos, Armand Grillet and Benjamin Bannier. Repository:

Re: Review Request 69597: Remove outstanding operations when marking agents as gone.

2018-12-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69597/#review211464 --- src/master/master.cpp Lines 8885 (patched)

Re: Review Request 69597: Remove outstanding operations when marking agents as gone.

2018-12-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69597/ --- (Updated Dec. 20, 2018, 1:46 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 69575: Send operation feedback when agent was marked as gone.

2018-12-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69575/ --- (Updated Dec. 20, 2018, 12:19 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 69575: Send operation feedback when agent was marked as gone.

2018-12-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69575/#review211460 --- Fix it, then Ship it! src/master/master.cpp Lines 8835

Re: Review Request 68016: Added libseccomp to the build.

2018-12-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review211456 --- 3rdparty/CMakeLists.txt Lines 637 (patched)

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

2018-12-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review211459 --- Ship it! Ship It! - Greg Mann On Dec. 19, 2018, 6:39 p.m.,