Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211821 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211820 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211819 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211818 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211817 --- PASS: Mesos patch 69694 was successfully built and tested.

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211816 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211815 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211814 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211813 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211812 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211811 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211810 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/ --- (Updated Jan. 10, 2019, 3:52 a.m.) Review request for mesos. Repository:

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211809 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/ --- (Updated Jan. 10, 2019, 2:32 a.m.) Review request for mesos. Repository:

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211806 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69661: Added resource provider information to v0 agent state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69661/#review211804 --- Ship it! Ship It! - Chun-Hung Hsiao On Jan. 3, 2019, 3

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/ --- (Updated Jan. 9, 2019, 10:54 p.m.) Review request for mesos. Changes ---

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211802 --- Fix it, then Ship it! It looks like a great start. Thanks for

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69493/#review211803 --- FAIL: Failed to apply the dependent review: 67844. Failed

Re: Review Request 69695: Fixed compile error with Clang 3.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69695/#review211801 --- PASS: Mesos patch 69695 was successfully built and tested.

Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69689/#review211800 --- Ship it! Ship It! - Meng Zhu On Jan. 8, 2019, 6:53 p.m.,

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211799 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69687: Fixed flakiness of resource provider ContainerTerminationMetric test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69687/#review211798 --- PASS: Mesos patch 69687 was successfully built and tested.

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review211797 --- PASS: Mesos patch 69064 was successfully built and tested.

Re: Review Request 69695: Fixed compile error with Clang 3.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69695/#review211794 --- Ship it! Ship It! - Chun-Hung Hsiao On Jan. 9, 2019, 2:37

Re: Review Request 68565: Fixed SLRP compilation with Clang 3.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68565/#review211793 --- Ship it! - Chun-Hung Hsiao On Aug. 30, 2018, 5:09 a.m.,

Re: Review Request 69681: Fixed the FD leak if containerizer::_launch() failed or discarded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69681/#review211792 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/#review211791 --- PASS: Mesos patch 69680 was successfully built and tested.

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69684/#review211790 --- Fix it, then Ship it!

Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69669/#review211789 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

> On Jan. 9, 2019, 5:39 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1391-1397 (patched) > > > > > > style nits, how about: > > > > ``` > > return result >

Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69689/#review211787 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211786 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69684/#review211784 --- Ship it! Ship It! - Gilbert Song On Jan. 7, 2019, 7:27

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69684/#review211783 --- src/slave/containerizer/mesos/containerizer.cpp Lines 1391-1397

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69684/#review211782 --- PASS: Mesos patch 69684 was successfully built and tested.

Re: Review Request 69701: Improved debuggability of `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69701/#review211781 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211780 --- PASS: Mesos patch 69694 was successfully built and tested.

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211779 --- Fix it, then Ship it! src/webui/app/controllers.js Lines

Re: Review Request 69701: Improved debuggability of `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69701/#review211778 --- Ship it! Ship It! - Till Toenshoff On Jan. 9, 2019, 3:46

Review Request 69701: Improved debuggability of `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69701/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9514

Re: Review Request 69698: Added try/except for `shell()` calls in `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69698/#review211777 --- Ship it! Ship It! - Till Toenshoff On Jan. 9, 2019, 9:35

[GitHub] dlazarus opened a new pull request #324: MESOS-9499 extended URI syntax to support any Zookeeper authentication schemes

dlazarus opened a new pull request #324: MESOS-9499 extended URI syntax to support any Zookeeper authentication schemes URL: https://github.com/apache/mesos/pull/324 Zookeeper URL now optionally can have syntax: zk://zk_auth_scheme!zk_auth_data@host:port/path If there is not "!"

Re: Review Request 69697: Reverted cleanup step of `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69697/#review211776 --- Ship it! Ship It! - Till Toenshoff On Jan. 9, 2019, 9:30

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

> On Jan. 8, 2019, 8:04 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1366 (patched) > > > > > > Just realize .repair may not be sufficient because it could only handle >

Review Request 69698: Added try/except for `shell()` calls in `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69698/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9514

Review Request 69697: Reverted cleanup step of `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69697/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9514