Re: Review Request 67177: Sorted container mounts by their target paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67177/#review213345 --- Bad review! Reviews applied: [67177, 67176, 67175, 65812, 68804,

Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/#review213344 --- Bad review! Reviews applied: [54987, 54986, 66871, 53267]

Re: Review Request 66344: Supported non-speculative operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66344/#review213343 --- Bad review! Reviews applied: [66344, 66049, 66218] Error:

Re: Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66327/#review213342 --- Bad review! Reviews applied: [66327, 66326, 66325, 66318]

Review Request 70085: Fixed a link error on Windows caused by volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70085/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9621

Re: Review Request 69588: Removed outdated authorization logic for offer operations.

> On Jan. 15, 2019, 7:27 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 3604-3605 (original), 3604-3605 (patched) > > > > > > Isn't the empty case valid? Also, use `Resources::reservationRole`? >

Review Request 70084: Avoid dereferencing removed executors and launching containers for them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70084/ --- Review request for mesos, Gilbert Song, Jie Yu, Meng Zhu, and Vinod Kone.

Re: Review Request 70082: Converted `UUID` proto messages to `id::UUID` in the RP manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70082/ --- (Updated March 1, 2019, 11:48 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70081/ --- (Updated March 1, 2019, 11:46 p.m.) Review request for mesos, Benjamin

Re: Review Request 70080: Changed the `getResourceProviderId` helper to take a `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70080/ --- (Updated March 1, 2019, 11:41 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70082: Used `id::UUID` to index publishing requests in the RP manager.

> On March 1, 2019, 10:17 p.m., Benjamin Bannier wrote: > > This does not look wrong to me, but with just at this patch and its chain > > it isn't really clear what exactly is _better_ with this approach. Could > > you expand the commit message? Such information is valuable when trying to > >

Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider.

> On March 1, 2019, 10:15 p.m., Benjamin Bannier wrote: > > src/slave/slave.cpp > > Line 8777 (original), 8785 (patched) > > > > > > We potentially publish to multiple resource providers here where each > > could

Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70081/#review213338 --- Patch looks great! Reviews applied: [70080, 70082, 70081]

Re: Review Request 70082: Used `id::UUID` to index publishing requests in the RP manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70082/#review213336 --- Fix it, then Ship it! This does not look wrong to me, but with

Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70081/#review213337 --- src/slave/slave.cpp Line 8777 (original), 8785 (patched)

Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70060/ --- (Updated March 1, 2019, 10:11 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70080: Changed the `getResourceProviderId` helper to take a `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70080/#review213335 --- Fix it, then Ship it! src/common/resources_utils.cpp Line 337

Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70081/ --- (Updated March 1, 2019, 8:11 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 70082: Used `id::UUID` to index publishing requests in the RP manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70082/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-9607

Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70060/#review21 --- Fix it, then Ship it! support/verify-reviews.py Lines 51

Re: Review Request 70049: Assured a set USER within RPM build.

> On Feb. 28, 2019, 8:52 p.m., Benjamin Bannier wrote: > > support/packaging/centos/build_rpm.sh > > Lines 29 (patched) > > > > > > What about only setting this if unset? > > > > export

Re: Review Request 70047: Updated build specific artefact generation.

> On Feb. 26, 2019, 9:22 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 630-637 (original), 663-667 (patched) > > > > > > I don't think the CMake build needs to follow the autotools one here.