Re: Review Request 70183: Made setting volume ownership asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70183/#review213617 --- Ship it! Ship It! - Gilbert Song On March 11, 2019, 8:03 a.m

Re: Review Request 70156: Added helper to test for metrics values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70156/#review213611 --- Ship it! Ship It! - Joseph Wu On March 8, 2019, 3:46 p.m., B

Re: Review Request 70186: Updated protobuf comments related to operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70186/#review213610 --- Patch looks great! Reviews applied: [70186] Passed command: expo

Re: Review Request 70151: Added `class ResourceLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70151/#review213609 --- Looks good, just the same comments as the earlier review for Resou

Re: Review Request 70171: Added `Try` constructors from `_Some`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70171/#review213608 --- Ship it! Ship It! - Benjamin Mahler On March 9, 2019, 1:56 a

Re: Review Request 70152: Added tests for `ResourceLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70152/#review213607 --- Ship it! src/tests/resource_quantities_tests.cpp Lines 389-427

Re: Review Request 70150: Added a constructor for `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70150/#review213606 --- Ship it! Should probably clarify that we're replacing the const

Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70062/#review213605 --- src/common/resource_quantities.cpp Lines 153 (patched)

Re: Review Request 70149: Added a `contains` method in `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70149/#review213603 --- src/common/resource_quantities.cpp Lines 144-146 (patched)

Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70062/#review213599 --- src/common/resource_quantities.hpp Lines 109-111 (original), 112-

Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70062/#review213604 --- src/common/resource_quantities.cpp Lines 143 (patched)

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213601 --- src/tests/resource_quantities_tests.cpp Lines 169 (patched)

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213602 --- Ship it! Ship It! - Benjamin Mahler On Feb. 27, 2019, 1:30 a

Re: Review Request 70069: Improved `ResourceQuantities` test's readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70069/#review213600 --- Ship it! src/tests/resource_quantities_tests.cpp Lines 46 (pat

Re: Review Request 70184: Fixed flakiness in 'RetryRpcWithExponentialBackoff'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70184/#review213597 --- Patch looks great! Reviews applied: [70184] Passed command: expo

[GitHub] [mesos] kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264386992 ## File path: include/mesos/mesos.proto ## @@ -3328,6 +3328,9 @@ message TTY

[GitHub] [mesos] kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264389356 ## File path: src/tests/containerizer/composing_containerizer_tests.cpp ## @

[GitHub] [mesos] kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264382919 ## File path: src/slave/containerizer/composing.cpp ## @@ -425,6 +425,28 @@

[GitHub] [mesos] kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264386370 ## File path: include/mesos/mesos.proto ## @@ -3328,6 +3328,9 @@ message TTY

[GitHub] [mesos] kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264383368 ## File path: src/slave/containerizer/composing.cpp ## @@ -425,6 +425,28 @@

Review Request 70186: Updated protobuf comments related to operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70186/ --- Review request for mesos, Benjamin Bannier and Gastón Kleiman. Repository: meso

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/ --- (Updated March 11, 2019, 7:15 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/ --- (Updated March 11, 2019, 7:14 p.m.) Review request for mesos, Gastón Kleiman, G

Review Request 70185: Renamed Master::sendBulkOperationFeedback() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70185/ --- Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. Repository:

Re: Review Request 70183: Made setting volume ownership asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70183/#review213596 --- Patch looks great! Reviews applied: [70183] Passed command: expo

Review Request 70184: Fixed flakiness in 'RetryRpcWithExponentialBackoff'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70184/ --- Review request for mesos and Chun-Hung Hsiao. Summary (updated) ---

[GitHub] [mesos] asekretenko opened a new pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

asekretenko opened a new pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326 To avoid situations like described in [MESOS-6874](https://issues.apache.org/jira/browse/MESOS-6874), I'm clarifying the v

Review Request 70183: Made setting volume ownership asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70183/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9643

Re: Review Request 70165: Fixed operator operation handling with resource provider resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70165/#review213594 --- Patch looks great! Reviews applied: [70165] Passed command: expo

Re: Review Request 70165: Fixed operator operation handling with resource provider resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70165/ --- (Updated March 11, 2019, 10:42 a.m.) Review request for mesos, Benjamin Bannier