Re: Review Request 70161: Added validation for `QuotaConfig`.

> On March 8, 2019, 9:45 a.m., Benjamin Mahler wrote: > > src/master/quota.cpp > > Lines 328-331 (patched) > > > > > > Maybe also check isnormal? Checked as part of the input scalar validation. - Meng --

Review Request 70203: Updated a test for `UPDATE_QUOTA` call validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70203/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9596 https://issu

Review Request 70202: Added call handler for `UPDATE_QUOTA`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70202/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9596 https://issu

Re: Review Request 70161: Added validation for `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70161/ --- (Updated March 12, 2019, 11:41 p.m.) Review request for mesos and Benjamin Mahl

Re: Review Request 70161: Added validation for `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70161/#review213651 --- Bad review! Reviews applied: [70161, 70201, 70152, 70151, 70150,

Review Request 70201: Added a method to check `ResourceLimits::contains(ResourceQuantities)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70201/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 70199: Replaced `.get().get()` with `**` in `result.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70199/#review213644 --- Ship it! Ship It! - Joseph Wu On March 12, 2019, 5:55 p.m.,

Re: Review Request 70161: Added validation for `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70161/#review213642 --- Patch looks great! Reviews applied: [70061, 70062, 70069, 70063,

Review Request 70199: Replaced `.get().get()` with `**` in `result.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70199/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Repository: mes

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213641 --- src/tests/storage_local_resource_provider_tests.cpp Lines 3832-38

Review Request 70198: Added validation method for input scalar values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70198/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 70160: Added `<<` operator to `protobuf::Map`.

> On March 8, 2019, 9:33 a.m., Benjamin Mahler wrote: > > include/mesos/type_utils.hpp > > Lines 533-545 (patched) > > > > > > Can we follow the existing map formats? > > > > > > https://github.com/apache/m

Re: Review Request 70152: Added tests for `ResourceLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70152/ --- (Updated March 12, 2019, 4:40 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 70151: Added `class ResourceLimits`.

> On March 11, 2019, 3:49 p.m., Benjamin Mahler wrote: > > Looks good, just the same comments as the earlier review for > > ResourceQuantities Thanks. The patch has been updated. > On March 11, 2019, 3:49 p.m., Benjamin Mahler wrote: > > src/common/resource_quantities.cpp > > Lines 334 (patch

Re: Review Request 70149: Added a `contains` method in `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70149/ --- (Updated March 12, 2019, 4:30 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

> On March 11, 2019, 3:28 p.m., Benjamin Mahler wrote: > > src/common/resource_quantities.cpp > > Lines 143 (patched) > > > > > > naming wise, perhaps 'this' and 'other' / 'otherIndex' or 'left' and > > 'right' / 'r

Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

> On March 11, 2019, 3:35 p.m., Benjamin Mahler wrote: > > src/common/resource_quantities.cpp > > Lines 153 (patched) > > > > > > Maybe some one-liner comments on these conditions to help the reader? > > E.g. > >

Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70062/ --- (Updated March 12, 2019, 4:17 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

> On March 11, 2019, 3:15 p.m., Benjamin Mahler wrote: > > src/common/resource_quantities.hpp > > Lines 109-111 (original), 112-115 (patched) > > > > > > Do we still need this now that we're splitting the class? Ma

Re: Review Request 70186: Updated protobuf comments related to operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70186/#review213633 --- Ship it! Ship It! - Joseph Wu On March 11, 2019, 12:18 p.m.,

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/#review213632 --- One discussion point, but otherwise LGTM. src/master/master.cpp

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/ --- (Updated March 12, 2019, 8:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70168: Added `ServiceManager` to manage CSI plugin container lifecycles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70168/ --- (Updated March 12, 2019, 6:59 p.m.) Review request for mesos, Benjamin Bannier

[GitHub] [mesos] kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

kaysoky commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264819458 ## File path: src/tests/containerizer/composing_containerizer_tests.cpp ## @

Re: Review Request 70186: Updated protobuf comments related to operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70186/#review213626 --- Ship it! Ship It! - Gastón Kleiman On March 11, 2019, 12:18

[GitHub] [mesos] asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264652265 ## File path: src/slave/containerizer/composing.cpp ## @@ -425,6 +425,28

[GitHub] [mesos] asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264650408 ## File path: src/tests/containerizer/composing_containerizer_tests.cpp #

[GitHub] [mesos] asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264639836 ## File path: include/mesos/mesos.proto ## @@ -3328,6 +3328,9 @@ message

[GitHub] [mesos] lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264624389 ## File path: src/tests/health_check_tests.cpp ## @@ -1889,9 +1900,12 @@ TEST_F

[GitHub] [mesos] lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264619462 ## File path: include/mesos/mesos.proto ## @@ -3328,6 +3328,9 @@ message TTYInf

[GitHub] [mesos] lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264621825 ## File path: src/slave/containerizer/composing.cpp ## @@ -435,6 +457,14 @@ Fut

[GitHub] [mesos] lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264623839 ## File path: src/tests/containerizer/composing_containerizer_tests.cpp ## @@ -

[GitHub] [mesos] lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264624869 ## File path: include/mesos/mesos.proto ## @@ -3328,6 +3328,9 @@ message TTYInf

[GitHub] [mesos] lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

lava commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264618371 ## File path: src/slave/containerizer/composing.cpp ## @@ -425,6 +425,28 @@ Fut