Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214437 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70396: Added a test to ensure correct role consumed quota accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70396/#review214436 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70409: Parameterized some allocator benchmarks for DRF and random sorters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70409/#review214435 --- Patch looks great! Reviews applied: [70409] Passed command: expo

Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/ --- Review request for mesos, Benno Evers and Greg Mann. Repository: mesos Descri

Review Request 70411: Changed naming of example framework class fields to match convention.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70411/ --- Review request for mesos, Benno Evers and Greg Mann. Repository: mesos Descri

Re: Review Request 70396: Added a test to ensure correct role consumed quota accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70396/#review214434 --- Patch looks great! Reviews applied: [70391, 70392, 70393, 70395,

Review Request 70409: Parameterized some allocator benchmarks for DRF and random sorters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70409/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 70396: Added a test to ensure correct role consumed quota accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70396/#review214429 --- Fix it, then Ship it! src/tests/hierarchical_allocator_tests.c

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/#review214427 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70378: Wrapped access to hashmaps in `frameworks.principals` and `authorized`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70378/#review214426 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70395: Enhanced HierarchicalAllocatorTest.QuotaWithNestedRoleReservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70395/#review214425 --- Fix it, then Ship it! src/tests/hierarchical_allocator_tests.c

Re: Review Request 70393: Fixed incorrect quota headroom and consumption calculations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70393/#review214424 --- Ship it! Ship It! - Meng Zhu On April 4, 2019, 7:47 p.m., Be

Re: Review Request 70407: Clarified a comment for `SeccompInfo` in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70407/#review214423 --- Patch looks great! Reviews applied: [70407] Passed command: expo

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

> On April 4, 2019, 9:53 p.m., Gastón Kleiman wrote: > > src/master/master.cpp > > Lines 2558-2560 (patched) > > > > > > We use stout's `stringify()` for this, which delegates to the > > corresponding `operator<<`

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/ --- (Updated April 5, 2019, 3:12 p.m.) Review request for mesos and Gastón Kleiman.

Re: Review Request 70377: Added tests to check that framework cannot change its principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70377/ --- (Updated April 5, 2019, 3:10 p.m.) Review request for mesos and Gastón Kleiman.

Review Request 70408: Deduplicated common validation code in Master::subscribe()'s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70408/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-2842 https://issue

Re: Review Request 70407: Clarified a comment for `SeccompInfo` in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70407/#review214421 --- Ship it! Ship It! - Gilbert Song On April 5, 2019, 7:18 a.m.

Review Request 70407: Clarified a comment for `SeccompInfo` in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70407/ --- Review request for mesos, Gilbert Song, Qian Zhang, and Vinod Kone. Repository:

Re: Review Request 70405: Fixed use-after-free bug in Docker provisioner store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70405/#review214418 --- Patch looks great! Reviews applied: [70287, 70354, 70365, 70288,

Re: Review Request 70396: Added a test to ensure correct role consumed quota accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70396/#review214417 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70405: Fixed use-after-free bug in Docker provisioner store.

> On April 5, 2019, 11:57 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > > Line 449 (original), 449 (patched) > > > > > > We only depend on `this` so we can access a si

Re: Review Request 70405: Fixed use-after-free bug in Docker provisioner store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70405/#review214415 --- Fix it, then Ship it! Thanks for cleaning this up, Andrei. I l

Re: Review Request 70288: Supported docker manifest v2 schema2.

> On April 5, 2019, 7:11 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > > Line 433 (original), 449-467 (patched) > > > > > > This lambda captures this but does not defe

Review Request 70405: Fixed use-after-free bug in Docker provisioner store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70405/ --- Review request for mesos, Benjamin Bannier, Gilbert Song, and Qian Zhang. Bugs:

Re: Review Request 70386: Quote chmod arguments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70386/#review214413 --- Ship it! Ship It! - Benno Evers On April 5, 2019, 8:27 a.m.,

Re: Review Request 70404: Supported CSI v1 in the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70404/#review214410 --- Patch looks great! Reviews applied: [70313, 70314, 70315, 70316,

Re: Review Request 70398: [WIP] Fixed the URI fetcher image fetch test failure on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70398/#review214409 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70398: [WIP] Fixed the URI fetcher image fetch test failure on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70398/#review214406 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 70288: Supported docker manifest v2 schema2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70288/#review214405 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp Line 4