Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70492/#review214717 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70492/#review214716 --- Patch looks great! Reviews applied: [70492] Passed command:

Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

> On April 16, 2019, 8:22 p.m., Benjamin Mahler wrote: > > Do we have a range of percentages we see from benchmarks that we can make > > to give users a better sense of how much? Added some numbers. - Meng --- This is an automatically

Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70492/ --- (Updated April 16, 2019, 8:38 p.m.) Review request for mesos and Benjamin

Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70492/#review214713 --- Do we have a range of percentages we see from benchmarks that we

Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70492/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70489/#review214711 --- Patch looks great! Reviews applied: [70489] Passed command:

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70489/#review214709 --- Ship it! Ship It! - Joseph Wu On April 16, 2019, 5:11 p.m.,

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

> On April 16, 2019, 4:56 p.m., Joseph Wu wrote: > > docs/container-image.md > > Line 184 (original), 184 (patched) > > > > > > Should the link text be `v2 schema1` (not `v1`)? ah, typo! - Gilbert

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70489/ --- (Updated April 16, 2019, 5:11 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70489/#review214707 --- docs/container-image.md Lines 188-190 (patched)

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70489/#review214706 --- docs/container-image.md Line 184 (original), 184 (patched)

Review Request 70489: Documented docker manifest v2 schema2 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70489/ --- Review request for mesos, Jie Yu and Qian Zhang. Repository: mesos

Re: Review Request 65085: WIP: Added a unit test for fd leakage with blocking HTTP calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65085/ --- (Updated April 16, 2019, 10 p.m.) Review request for Benjamin Bannier. Bugs:

Re: Review Request 70483: Added docker manifest v2s2 config to 'ImageInfo'.

> On April 16, 2019, 7:23 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/store.hpp > > Line 49 (original), 49 (patched) > > > > > > This comment seems not accurate, this field should be either

Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation.

> On April 16, 2019, 1:06 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3128 (patched) > > > > > > Are we checking that the resources get returned to the offer

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

> On April 16, 2019, 1:18 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3328 (patched) > > > > > > If we need to await offers, lets also check their contents. It

Re: Review Request 70469: Optimized weighted shuffling in the random sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70469/ --- (Updated April 16, 2019, 9:39 a.m.) Review request for mesos and Benjamin

Re: Review Request 70484: Supported docker manifest v2s2 config with image GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70484/#review214694 --- Ship it! Ship It! - Qian Zhang On April 16, 2019, 2:08

Re: Review Request 70483: Added docker manifest v2s2 config to 'ImageInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70483/#review214683 --- Fix it, then Ship it!

Re: Review Request 70484: Supported docker manifest v2s2 config with image GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70484/#review214692 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70482: Added docker manifest v2s2 config to protobuf 'ContainerLayers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70482/#review214691 --- Ship it! Ship It! - Qian Zhang On April 16, 2019, 2:07

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review214690 --- Fix it, then Ship it!

Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69954/#review214689 --- Fix it, then Ship it!

Re: Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70431/#review214688 --- Fix it, then Ship it! src/examples/test_csi_plugin.cpp Lines

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/#review214686 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 70484: Supported docker manifest v2s2 config with image GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70484/ --- Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.

Review Request 70482: Added docker manifest v2s2 config to protobuf 'ContainerLayers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70482/ --- Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.

Review Request 70483: Added docker manifest v2s2 config to 'ImageInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70483/ --- Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.