Re: Review Request 70441: Made CSI volume managers no longer maintain a list of services.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70441/#review215009 --- Patch looks great! Reviews applied: [70468, 70431, 70441]

Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70133/ --- (Updated May 2, 2019, 11:40 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/ --- (Updated May 2, 2019, 10:46 p.m.) Review request for mesos and Benjamin

Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69954/ --- (Updated May 2, 2019, 10:44 p.m.) Review request for mesos and Benjamin

Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation.

> On April 16, 2019, 1:06 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3128 (patched) > > > > > > Are we checking that the resources get returned to the offer

Re: Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70431/ --- (Updated May 2, 2019, 10:42 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215004 --- The new flag should also be documented in the

Review Request 70587: Fixed unguarded calls to `Option::get()` in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70587/ --- Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Till

Review Request 70585: Test for a race between resubscriptions with different principals - WIP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70585/ --- Review request for mesos. Bugs: MESOS-9763

Review Request 70581: Add flag ignoring docker manifest config metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/ --- Review request for mesos, Gilbert Song and James Peach. Bugs: MESOS-9760

Re: Review Request 70534: Added tests for UPDATE_FRAMEWORK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/ --- (Updated May 2, 2019, 4:06 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70534: Added tests for the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/ --- (Updated May 2, 2019, 4:04 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 2, 2019, 4:03 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70133/#review214996 --- Ship it! Ship It! - Benjamin Mahler On April 9, 2019, 9:21

Re: Review Request 70521: Renamed variables in `Master::_accept` to improve readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70521/#review214995 --- Ship it! Ship It! - Benjamin Mahler On May 1, 2019, 8:36

Re: Review Request 70558: Added sending UpdateFrameworkMessage and FRAMEWORK_UPDATED - WIP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70558/#review214994 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 2, 2019, 3:58 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated May 2, 2019, 3:58 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70531/ --- (Updated May 2, 2019, 3:58 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70530: Refactored FrameworkInfo updates for the UPDATE_FRAMEWORK call + race fix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70530/ --- (Updated May 2, 2019, 3:58 p.m.) Review request for mesos and Benjamin Mahler.

Review Request 70583: Move suppressedRoles into Master::_subscribe() as RepeatedPtrField.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70583/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258