Re: Review Request 70660: Fix the XFS build for recent Fedora versions.

2019-05-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70660/#review215313 --- Patch looks great! Reviews applied: [70660] Passed command: expo

Review Request 70660: Fix the XFS build for recent Fedora versions.

2019-05-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70660/ --- Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu. Re

Re: Review Request 70618: Store framework sorters inside RoleInfos.

2019-05-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70618/#review215304 --- Patch looks great! Reviews applied: [70626, 70591, 70618] Passed

Re: Review Request 70656: Fix a bug where racing quota removal request could crash the master.

2019-05-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70656/#review215302 --- Patch looks great! Reviews applied: [70656] Passed command: expo

Re: Review Request 70618: Store framework sorters inside RoleInfos.

2019-05-16 Thread Andrei Sekretenko
> On May 14, 2019, 2:07 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 144-147 (patched) > > > > > > (1) maybe we can create it in the e.g. constructor? > > > > (2) let's jus

Re: Review Request 70618: Store framework sorters inside RoleInfos.

2019-05-16 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70618/ --- (Updated May 16, 2019, 2:17 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 70626: Refactored `untrackReservations()` method.

2019-05-16 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70626/ --- (Updated May 16, 2019, 2:16 p.m.) Review request for mesos and Meng Zhu. Bugs

Re: Review Request 70591: Added `struct RoleInfo` to track role reservations and framework IDs.

2019-05-16 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/ --- (Updated May 16, 2019, 2:16 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 70656: Fix a bug where racing quota removal request could crash the master.

2019-05-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70656/#review215300 --- Ship it! Ship It! - Joseph Wu On May 16, 2019, 5:56 a.m., Me

Review Request 70656: Fix a bug where racing quota removal request could crash the master.

2019-05-16 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70656/ --- Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Joseph Wu. Bu

Re: Review Request 70653: Added logging of slow reverse DNS when accepting SSL connections.

2019-05-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70653/#review215299 --- Patch looks great! Reviews applied: [70653] Passed command: expo

Re: Review Request 70653: Added logging of slow reverse DNS when accepting SSL connections.

2019-05-16 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70653/#review215298 --- Ship it! Ship It! - Benno Evers On May 16, 2019, 9:47 a.m.,

Re: Review Request 70653: Added logging of slow reverse DNS when accepting SSL connections.

2019-05-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70653/#review215297 --- Ship it! Ship It! - Joseph Wu On May 16, 2019, 2:47 a.m., Be

Review Request 70653: Added logging of slow reverse DNS when accepting SSL connections.

2019-05-16 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70653/ --- Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and Jose

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

2019-05-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70651/#review215295 --- Patch looks great! Reviews applied: [70651] Passed command: expo