Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-05-31 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/ --- (Updated May 31, 2019, 3:47 p.m.) Review request for mesos and Alexander Ruklet

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

2019-05-31 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/#review215616 --- The code looks good to me. Thanks! As part of this change, either

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

2019-05-31 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/#review215617 --- Fix it, then Ship it! This looks pretty sweet, thanks for going

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

2019-05-31 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/ --- (Updated May 31, 2019, 2:34 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

2019-05-31 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/ --- (Updated May 31, 2019, 2:06 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 70747: Updated some flag description for libprocess SSL flags.

2019-05-31 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70747/#review215615 --- Ship it! Ship It! - Alexander Rukletsov On May 29, 2019, 1:5

Re: Review Request 70757: Added a privs isolator.

2019-05-31 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70757/#review215611 --- src/slave/containerizer/mesos/launch.cpp Lines 1098 (patched)

Re: Review Request 70741: Adopted container file operations for secrets volumes.

2019-05-31 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70741/#review215610 --- Patch looks great! Reviews applied: [70741] Passed command: expo