Review Request 70939: Updated the UI to show quota limits differently from guarantees.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70939/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8486 https://issu

Re: Review Request 70915: Made `/roles` endpoint also return quota limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70915/#review216116 --- Fix it, then Ship it! src/master/readonly_handler.cpp Lines 72

Re: Review Request 70916: Replaced `Quota` with `Quota2` in the master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70916/ --- (Updated June 24, 2019, 3:22 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 70915: Made `/roles` endpoint also return quota limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70915/ --- (Updated June 24, 2019, 3:19 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 70918: Removed `setQuota` and `removeQuota` methods in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70918/#review216111 --- Fix it, then Ship it! src/master/allocator/mesos/metrics.cpp L

Re: Review Request 70917: Refactored the allocator test to use the `updateQuota` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70917/#review216110 --- Fix it, then Ship it! src/tests/allocator.cpp Lines 27-34 (ori

Re: Review Request 70927: Fixed a memory "leak" of filters in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70927/ --- (Updated June 24, 2019, 7:54 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 70927: Fixed a memory "leak" of filters in the allocator.

> On June 22, 2019, 8:14 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1158 (original), 1164 (patched) > > > > > > While this improves on the previous approach where we poten

[GitHub] [mesos] asfgit closed pull request #338: Documentation: Garbage Collection - Nanoseconds

asfgit closed pull request #338: Documentation: Garbage Collection - Nanoseconds URL: https://github.com/apache/mesos/pull/338 This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: Review Request 70927: Fixed a memory "leak" of filters in the allocator.

> On June 22, 2019, 11:51 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 2319-2325 (original), 2315-2321 (patched) > > > > > > Isn't this dispatch redundant? No, see the comment in

Re: Review Request 70923: Added a registry operation for the DRAIN_AGENT call.

> On June 24, 2019, 11:47 a.m., Meng Zhu wrote: > > src/master/registry_operations.cpp > > Lines 422-433 (patched) > > > > > > I do not see the capability removed anywhere. But in the previous > > patch, we said: >

Re: Review Request 70919: Replaced the old `struct Quota`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70919/#review216103 --- Fix it, then Ship it! src/common/http.cpp Lines 880-884 (patch

Re: Review Request 70915: Made `/roles` endpoint also return quota limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70915/#review216104 --- src/master/readonly_handler.cpp Lines 719-720 (patched)

Re: Review Request 70923: Added a registry operation for the DRAIN_AGENT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70923/#review216102 --- src/master/registry_operations.cpp Lines 422-433 (patched)

Re: Review Request 70916: Replaced `Quota` with `Quota2` in the master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70916/#review216100 --- src/master/quota_handler.cpp Lines 368-374 (original), 368-387 (p

Re: Review Request 70922: Added master minimum capability for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70922/#review216101 --- Fix it, then Ship it! docs/downgrades.md Lines 33-34 (patched)

Re: Review Request 70915: Made `/roles` endpoint also return quota limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70915/#review216097 --- Can you test this against the roles table in the UI and ensure it

Re: Review Request 70933: Refactored raw duration into const variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70933/#review216096 --- Ship it! The commit summary "Refactored raw duration into const

Re: Review Request 70885: Renamed 'libprocess::network::Address::hostname()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70885/#review216094 --- 3rdparty/libprocess/include/process/address.hpp Lines 65-68 (orig

Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9823 https:/

Review Request 70935: Sped up `SlaveTest.KillQueuedTaskDuringExecutorRegistration`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70935/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos Descrip

Re: Review Request 70884: Added optional 'host' string member to UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70884/ --- (Updated June 24, 2019, 1:48 p.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 70795: Updated SSL docs to include new libprocess flag.

> On June 21, 2019, 1:34 a.m., Till Toenshoff wrote: > > docs/ssl.md > > Lines 194 (patched) > > > > > > I wonder if we should already start a deprecation of the `libprocess` > > scheme - that would be: > > - an

Re: Review Request 70749: Introduced optional new scheme for hostname validation.

> On June 21, 2019, 1:32 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 808 (patched) > > > > > > I know you just moved it, but where do these 100ms come from and how > > could we be m

Review Request 70933: Refactored raw duration into const variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70933/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Repository: mesos

[GitHub] [mesos] aaniin opened a new pull request #338: Documentation: Garbage Collection - Nanoseconds

aaniin opened a new pull request #338: Documentation: Garbage Collection - Nanoseconds URL: https://github.com/apache/mesos/pull/338 Hello! While recently enabling garbage collection in our mesos cluster we came across this inconsistency in the documentation for garbage collection.

[GitHub] [mesos] bbannier opened a new pull request #337: Removed executable bit from files would should be `source`'d.

bbannier opened a new pull request #337: Removed executable bit from files would should be `source`'d. URL: https://github.com/apache/mesos/pull/337 This is an automated message from the Apache Git Service. To respond to the