Re: Review Request 70991: Added ability to pass custom SSL context to `Socket::connect()`.

> On July 4, 2019, 11:53 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Line 806 (original), 807 (patched) > > > > > > s/libprocess/legacy/ Actually, please make sure you dont end up with

Re: Review Request 70991: Added ability to pass custom SSL context to `Socket::connect()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70991/#review216396 --- Fix it, then Ship it! Awesome work Benno - thanks! Can't wait

Re: Review Request 70947: Added `reviveOffers(roles)` to V0 Java bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70947/#review216391 --- Ship it! src/java/src/org/apache/mesos/SchedulerDriver.java

Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70985/#review216392 --- Ship it! Ship It! - Benjamin Mahler On July 4, 2019, 3:19

Re: Review Request 70886: Override source address for executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70886/#review216390 --- Bad review! Reviews applied: [70886, 70993, 70933, 70797, 70992,

Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70985/#review216389 --- Patch looks great! Reviews applied: [70894, 70897, 70895, 70982,

Re: Review Request 70797: Added unit tests for hostname validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70797/ --- (Updated July 4, 2019, 7 p.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 70991: Added ability to pass custom SSL context to `Socket::connect()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70991/ --- (Updated July 4, 2019, 7 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70795: Updated SSL docs to include new libprocess flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70795/ --- (Updated July 4, 2019, 6:58 p.m.) Review request for mesos, Alexander

Re: Review Request 70749: Introduced RFC6125-compliant hostname validation scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/ --- (Updated July 4, 2019, 6:52 p.m.) Review request for mesos, Alexander

Re: Review Request 70921: Added OpenSSL-related changes to CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70921/ --- (Updated July 4, 2019, 5:34 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70946: WIP: Added reviveOffers() and the new constructor to Java TestFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70946/#review216388 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 71013: Fixed flaky test `UpdateFrameworkV0Test.SuppressedRoles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71013/#review216385 --- Patch looks great! Reviews applied: [71013] Passed command:

Re: Review Request 70947: Added `reviveOffers(roles)` to V0 Java bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70947/ --- (Updated July 4, 2019, 3:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java bindings.

> On July 3, 2019, 10:32 p.m., Benjamin Mahler wrote: > > src/java/src/org/apache/mesos/MesosSchedulerDriver.java > > Lines 402-404 (patched) > > > > > > Why the extra level of indirection? Why not just make this

Re: Review Request 70991: Updated `Socket::connect()` API according to maintainer feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70991/#review216383 --- 3rdparty/libprocess/src/poll_socket.hpp Lines 16-18 (patched)

Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70985/ --- (Updated July 4, 2019, 3:19 p.m.) Review request for mesos and Benjamin

Re: Review Request 70994: Moved to sepearte methods the (un)suppressing logic common with update.

> On July 3, 2019, 8:47 p.m., Benjamin Mahler wrote: > > How about: > > > > ``` > > Extracted suppression logic in allocator for use in update framework. > > > > This patch moves the logic of suppressing/unsuppressing a role set from > > the inside of 'suppressOffers()'/'reviveOffers()' into

Re: Review Request 70921: Added OpenSSL-related changes to CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70921/#review216382 --- Fix it, then Ship it! Ship It! CHANGELOG Lines 9 (patched)

Re: Review Request 70993: Added warnings about known problems with libevent epoll backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70993/#review216381 --- Ship it! Ship It! - Till Toenshoff On July 2, 2019, 5:53

Re: Review Request 70933: Moved an inline duration for slow DNS logging into a const variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70933/#review216380 --- Ship it! Ship It! - Till Toenshoff On June 24, 2019, 12:22

Re: Review Request 70797: Added unit tests for hostname validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70797/#review216379 --- Ship it! Ship It! - Till Toenshoff On July 2, 2019, 5:53

Re: Review Request 70797: Added unit tests for hostname validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70797/#review216378 --- 3rdparty/libprocess/src/tests/ssl_tests.cpp Line 318 (original),

Re: Review Request 70992: Recorded Socket API change in CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70992/#review216377 --- Ship it! Ship It! - Till Toenshoff On July 4, 2019, 2:28

Re: Review Request 70992: Recorded Socket API change in CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70992/ --- (Updated July 4, 2019, 2:28 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 71013: Fixed flaky test `UpdateFrameworkV0Test.SuppressedRoles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71013/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9882