Review Request 71197: Updated the `disk/du` disk isolator tests with rootfs cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71197/ --- Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu. Bu

Review Request 71192: Propagate ephemeral volume information from rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71192/ --- Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu. Bu

Review Request 71196: Updated the `disk/du` isolator to support rootfs checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71196/ --- Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu. Bu

Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71194/ --- Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu. Bu

Review Request 71193: Supported multiple quota paths in the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71193/ --- Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu. Bu

Review Request 71195: Update `disk/xfs` tests for rootfs quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71195/ --- Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu. Bu

Review Request 71198: Fixed GLog linking with debug targets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71198/ --- Review request for mesos. Repository: mesos Description --- When buildin

Re: Review Request 71198: Fixed GLog linking with debug targets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71198/#review216948 --- Ship it! Ship It! - Benjamin Bannier On July 30, 2019, 9:54

Review Request 71199: Added documentation for GET_OPERATIONS calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71199/ --- Review request for mesos, Benjamin Bannier, Joseph Wu, and Vinod Kone. Reposito

Re: Review Request 71180: Fixed column key name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71180/#review216949 --- Ship it! Ship It! - Greg Mann On July 29, 2019, 9:18 p.m., B

Re: Review Request 71181: Prevented webui from displaying unset drain config field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71181/#review216950 --- Ship it! Ship It! - Greg Mann On July 29, 2019, 9:18 p.m., B

Review Request 71200: Removed `-Werror` from libarchive's cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71200/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description

Re: Review Request 71200: Removed `-Werror` from libarchive's cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71200/#review216952 --- Ship it! Ship It! - Jan Schlicht On July 30, 2019, 11:08 a.m

Re: Review Request 71182: Stored last time a drain request was sent in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71182/#review216951 --- In the description: it's not correct that the timeout would be res

Re: Review Request 71182: Stored last time a drain request was sent in the master.

> On July 30, 2019, 9:50 a.m., Greg Mann wrote: > > In the description: it's not correct that the timeout would be reset if the > > agent fails over. Since the grace period is sent to the executor when the > > first KILL event is set, an agent failover will cause another KILL event to > > be s

Re: Review Request 71199: Added documentation for GET_OPERATIONS calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71199/#review216955 --- Fix it, then Ship it! docs/operator-http-api.md Lines 1666 (pa

Re: Review Request 71183: Stored last time a drain request was sent in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71183/#review216954 --- include/mesos/agent/agent.proto Lines 574 (patched)

Re: Review Request 71184: Added expected drain end time to webui's agent screen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71184/#review216956 --- src/webui/app/agents/agent.html Line 64 (original), 64 (patched)

Re: Review Request 71197: Updated the `disk/du` disk isolator tests with rootfs cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71197/#review216957 --- Patch looks great! Reviews applied: [71192, 71193, 71194, 71195,

Re: Review Request 71199: Added documentation for GET_OPERATIONS calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71199/#review216958 --- docs/operator-http-api.md Lines 3679-3682 (patched)

Re: Review Request 71198: Fixed GLog linking with debug targets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71198/#review216959 --- Ship it! Ship It! - Joseph Wu On July 30, 2019, 12:54 a.m.,

Re: Review Request 71200: Removed `-Werror` from libarchive's cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71200/#review216960 --- What problem/warning is surfacing when this flag is present? - Jo

Re: Review Request 71200: Removed `-Werror` from libarchive's cmake build.

> On July 30, 2019, 1:33 p.m., Joseph Wu wrote: > > What problem/warning is surfacing when this flag is present? Assuming your are asking out of curiosity as we would never want to build any bundled dependency with `-Werror` since we have no intention of fixing these projects. I attached the

Re: Review Request 71200: Removed `-Werror` from libarchive's cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71200/#review216964 --- Ship it! Ship It! - Joseph Wu On July 30, 2019, 2:08 a.m., B

Re: Review Request 71183: Stored last time a drain request was sent in the agent.

> On July 30, 2019, 11:56 a.m., Greg Mann wrote: > > src/slave/slave.hpp > > Line 913 (original), 913 (patched) > > > > > > In the agent API, the agent will no longer have the drain config when > > it finishes drain

Re: Review Request 71182: Stored last time a drain request was sent in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71182/ --- (Updated July 30, 2019, 2:39 p.m.) Review request for mesos and Greg Mann. Ch

Re: Review Request 71184: Added expected drain end time to webui's agent screen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71184/ --- (Updated July 30, 2019, 2:40 p.m.) Review request for mesos and Greg Mann. Ch

Re: Review Request 71183: Stored last time a drain request was sent in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71183/ --- (Updated July 30, 2019, 2:40 p.m.) Review request for mesos and Greg Mann. Ch

Re: Review Request 71184: Added expected drain end time to webui's agent screen.

> On July 30, 2019, 12:19 p.m., Greg Mann wrote: > > src/webui/app/agents/agent.html > > Line 64 (original), 64 (patched) > > > > > > Why "grace time" instead of "grace period"? I am not a native speaker, but to me "

Re: Review Request 71199: Added documentation for GET_OPERATIONS calls.

> On July 30, 2019, 11:26 a.m., Joseph Wu wrote: > > docs/operator-http-api.md > > Lines 3679-3682 (patched) > > > > > > Since this is the agent version of the call, I think you can go with > > either: > > > >

Re: Review Request 71199: Added documentation for GET_OPERATIONS calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71199/ --- (Updated July 30, 2019, 1:20 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 71184: Added expected drain end time to webui's agent screen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71184/#review216970 --- Patch looks great! Reviews applied: [71180, 71181, 71182, 71183,

Review Request 71204: Added gitlint config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71204/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9360 https://issue

Review Request 71203: Added check script to check for license headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71203/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9360 https://issue

Review Request 71205: Switch commit hooks to pre-commit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9360 https://issue

Review Request 71208: Revert "Updated cpplint to be compatible with Python 3."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71208/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9360 https://issue

Review Request 71209: Enabled a number of additional pre-commit checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9360 https://issue

Review Request 71206: Removed old mesos-style and references.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71206/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9360 https://issue

Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71207/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9360 https://issue

Re: Review Request 71209: Enabled a number of additional pre-commit checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review216975 --- Bad review! Reviews applied: [71209, 71208, 71207, 71206, 71205,

Review Request 71210: Removed total resources tracking in the random sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71210/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository: me

Review Request 71212: Updated operator HTTP API documentation regarding `GET_QUOTA`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71212/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: MESOS-96

Review Request 71213: Updated operator HTTP API documentation regarding `UPDATE_QUOTA`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71213/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository: me

Review Request 71214: Marked `SET_QUOTA` and `REMOVE_QUOTA` as deprecated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71214/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: MESOS-96

Re: Review Request 71172: Looked up parent's IP for the non-checkpointed nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71172/#review216976 --- Ship it! This part of code is fragile. Probably we need a unit

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70728/#review216979 --- Fix it, then Ship it! src/tests/mesos.hpp Lines 3038 (patched)