Re: Review Request 71197: Updated the `disk/du` disk isolator tests with rootfs cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71197/#review217047 --- Bad patch! Reviews applied: [71192, 71193, 71194, 71195, 71196,

Re: Review Request 71230: Moved the sorter code under the `master/allocator/mesos/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71230/#review217046 --- Patch looks great! Reviews applied: [71230] Passed command:

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

> On Aug. 1, 2019, 2:15 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 335 (patched) > > > > > > According to this comment > >

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71194/ --- (Updated Aug. 2, 2019, 2:27 a.m.) Review request for mesos, Xudong Ni, Gilbert

Re: Review Request 71197: Updated the `disk/du` disk isolator tests with rootfs cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71197/ --- (Updated Aug. 2, 2019, 1:40 a.m.) Review request for mesos, Xudong Ni, Gilbert

Re: Review Request 71196: Updated the `disk/du` isolator to support rootfs checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71196/ --- (Updated Aug. 2, 2019, 1:40 a.m.) Review request for mesos, Xudong Ni, Gilbert

Re: Review Request 71196: Updated the `disk/du` isolator to support rootfs checks.

> On Aug. 1, 2019, 4:06 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/posix/disk.cpp > > Line 268 (original), 298 (patched) > > > > > > `info->directories.contains(path)`? After applying

Review Request 71230: Moved the sorter code under the `master/allocator/mesos/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71230/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Re: Review Request 71229: Fixed the webui roles table resource sorting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71229/#review217042 --- Patch looks great! Reviews applied: [71229] Passed command:

Re: Review Request 71229: Fixed the webui roles table resource sorting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71229/#review217041 --- Ship it! Ship It! - Vinod Kone On Aug. 1, 2019, 7:14 p.m.,

Review Request 71229: Fixed the webui roles table resource sorting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71229/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Repository: mesos

Re: Review Request 71196: Updated the `disk/du` isolator to support rootfs checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71196/#review217040 --- src/slave/containerizer/mesos/isolators/posix/disk.cpp Lines

Re: Review Request 71222: Added a test `VolumeSecretIsolatorCleanupTest.ROOT_FailInPreparing`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71222/#review217038 --- Patch looks great! Reviews applied: [71201, 71221, 71222]

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71194/#review217030 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 335

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217031 --- Patch looks great! Reviews applied: [71143, 71144, 71145, 71146,

Re: Review Request 70831: Fixed synchronization in MasterTest.UpdateSlaveMessageWithPendingOffers.

> On Aug. 1, 2019, 10:08 a.m., Chun-Hung Hsiao wrote: > > src/tests/master_tests.cpp > > Lines 9014 (patched) > > > > > > Alternatively, we can avoid this expectation and do the following: > > ``` > >

Re: Review Request 71224: Removed lossy `long` to `double` conversion in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71224/#review217028 --- Ship it! The comment has been totally misleaing before -

Re: Review Request 71224: Removed lossy `long` to `double` conversion in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71224/ --- (Updated Aug. 1, 2019, 11:03 a.m.) Review request for mesos and Andrei

Re: Review Request 71197: Updated the `disk/du` disk isolator tests with rootfs cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71197/#review217027 --- Patch looks great! Reviews applied: [71192, 71193, 71194, 71195,

Review Request 71224: Removed lossy `long` to `double` conversion in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71224/ --- Review request for mesos and Andrei Sekretenko. Repository: mesos

Re: Review Request 70831: Fixed synchronization in MasterTest.UpdateSlaveMessageWithPendingOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70831/#review217026 --- src/tests/master_tests.cpp Lines 9014 (patched)

Re: Review Request 70831: Fixed synchronization in MasterTest.UpdateSlaveMessageWithPendingOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70831/#review217025 --- Ship it! Ship It! - Chun-Hung Hsiao On June 11, 2019, 12:38

Re: Review Request 71182: Stored last time a drain request was sent in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71182/ --- (Updated Aug. 1, 2019, 9:52 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 71183: Stored last time a drain request was sent in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71183/ --- (Updated Aug. 1, 2019, 9:52 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 71148: Explicitly disabled periodic reconciliation for some provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71148/#review217024 --- Fix it, then Ship it!

Re: Review Request 71147: Update config factory to set resource provider reconciliation interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71147/#review217023 --- Ship it! Ship It! - Chun-Hung Hsiao On July 29, 2019, 8:56

Review Request 71222: Added a test `VolumeSecretIsolatorCleanupTest.ROOT_FailInPreparing`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71222/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9893

Review Request 71221: Moved const string `.secret` to paths.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71221/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9893

Re: Review Request 71214: Marked `SET_QUOTA` and `REMOVE_QUOTA` as deprecated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71214/#review217022 --- Patch looks great! Reviews applied: [71212, 71213, 71214]